Page MenuHomeFreeBSD
Feed Advanced Search

Tue, Oct 15

mav committed rS353584: MFC r352743: Add kern.cam.da.X.quirks tunable, similar existing for ada..
MFC r352743: Add kern.cam.da.X.quirks tunable, similar existing for ada.
Tue, Oct 15, 6:47 PM
mav committed rS353583: MFC r352939: Improve latency of synchronous 128KB writes..
MFC r352939: Improve latency of synchronous 128KB writes.
Tue, Oct 15, 6:45 PM
mav committed rS353582: MFC r352939: Improve latency of synchronous 128KB writes..
MFC r352939: Improve latency of synchronous 128KB writes.
Tue, Oct 15, 6:44 PM
mav committed rS353581: MFC r352787: Replace argument checks with assertions..
MFC r352787: Replace argument checks with assertions.
Tue, Oct 15, 6:42 PM
mav committed rS353580: MFC r352787: Replace argument checks with assertions..
MFC r352787: Replace argument checks with assertions.
Tue, Oct 15, 6:39 PM

Sat, Oct 12

mav committed rS353454: Allocate device softc from the device domain..
Allocate device softc from the device domain.
Sat, Oct 12, 7:03 PM

Tue, Oct 1

mav committed rS352939: Improve latency of synchronous 128KB writes..
Improve latency of synchronous 128KB writes.
Tue, Oct 1, 8:10 PM

Sun, Sep 29

mav committed rS352862: MFC r352369: Relax TX draining in ns8250_bus_transmit()..
MFC r352369: Relax TX draining in ns8250_bus_transmit().
Sun, Sep 29, 2:56 AM
mav committed rS352861: MFC r352369: Relax TX draining in ns8250_bus_transmit()..
MFC r352369: Relax TX draining in ns8250_bus_transmit().
Sun, Sep 29, 2:56 AM

Sat, Sep 28

mav added a comment to D21807: VirtIO SCSI online disk resize.
In D21807#476430, @pjd wrote:
Sat, Sep 28, 3:31 PM
mav committed rS352830: MFC r352579: Allocate callout wheel from the respective memory domain..
MFC r352579: Allocate callout wheel from the respective memory domain.
Sat, Sep 28, 2:15 AM
mav committed rS352828: MFC r351422: Report Clock Power Management support and status..
MFC r351422: Report Clock Power Management support and status.
Sat, Sep 28, 1:31 AM
mav committed rS352827: MFC r352544: Improve ioat(4) NUMA-awareness..
MFC r352544: Improve ioat(4) NUMA-awareness.
Sat, Sep 28, 12:59 AM

Fri, Sep 27

mav added inline comments to D21807: VirtIO SCSI online disk resize.
Fri, Sep 27, 1:40 PM
mav added a comment to D21807: VirtIO SCSI online disk resize.
In D21807#476160, @pjd wrote:

What do you mean by 'too strict parsing of ASC/ASCQ'?

Fri, Sep 27, 1:38 PM
mav committed rS352787: Replace argument checks with assertions..
Replace argument checks with assertions.
Fri, Sep 27, 2:09 AM

Thu, Sep 26

mav committed rS352779: MFS r352772: MFC r349342 (by imp):.
MFS r352772: MFC r349342 (by imp):
Thu, Sep 26, 11:27 PM
mav committed rS352773: MFC r349342 (by imp):.
MFC r349342 (by imp):
Thu, Sep 26, 7:48 PM
mav committed rS352772: MFC r349342 (by imp):.
MFC r349342 (by imp):
Thu, Sep 26, 7:48 PM
mav added a comment to D21807: VirtIO SCSI online disk resize.

This virtio API looks ugly. They conform themselves that device should also report normal UNIT ATTENTION with the same status, which is already handled by CAM DA driver. If we assume that device does generate UNIT ATTENTION, then we should be able to make cam send TUR request to see it by using AC_SCSI_AEN async. Alternatively, it is possible to simulate UNIT ATTENTION receive by using AC_UNIT_ATTENTION with fake CCB, including ASC/ASCQ received from virtio API. Your method should also work, but what I don\t very like it too strict parsing ASC/ASCQ and sending not exactly correct async.

Thu, Sep 26, 7:42 PM
mav committed rS352743: Add kern.cam.da.X.quirks tunable, similar existing for ada..
Add kern.cam.da.X.quirks tunable, similar existing for ada.
Thu, Sep 26, 2:49 PM
mav closed D20677: Introduce quirks tunable for da driver.
Thu, Sep 26, 2:49 PM
mav committed rS352728: Microoptimize sched_pickcpu() CPU affinity on SMT..
Microoptimize sched_pickcpu() CPU affinity on SMT.
Thu, Sep 26, 12:35 AM

Wed, Sep 25

mav committed rS352713: Microoptimize sched_pickcpu() after r352658..
Microoptimize sched_pickcpu() after r352658.
Wed, Sep 25, 7:29 PM
mav committed rS352708: MFC r352493: Fix typo, setting hidden flag instead of reparse..
MFC r352493: Fix typo, setting hidden flag instead of reparse.
Wed, Sep 25, 6:47 PM
mav committed rS352687: MFC r352493: Fix typo, setting hidden flag instead of reparse..
MFC r352493: Fix typo, setting hidden flag instead of reparse.
Wed, Sep 25, 3:51 PM
mav committed rS352686: MFC r352493: Fix typo, setting hidden flag instead of reparse..
MFC r352493: Fix typo, setting hidden flag instead of reparse.
Wed, Sep 25, 3:50 PM
mav committed rS352677: Fix wrong assertion in r352658..
Fix wrong assertion in r352658.
Wed, Sep 25, 11:59 AM

Tue, Sep 24

mav committed rS352658: Fix/improve interrupt threads scheduling..
Fix/improve interrupt threads scheduling.
Tue, Sep 24, 8:01 PM

Mon, Sep 23

mav committed rS352630: Make nvme(4) driver some more NUMA aware..
Make nvme(4) driver some more NUMA aware.
Mon, Sep 23, 5:53 PM

Sat, Sep 21

mav committed rS352579: Allocate callout wheel from the respective memory domain..
Allocate callout wheel from the respective memory domain.
Sat, Sep 21, 3:38 PM

Sep 19 2019

mav committed rS352544: Improve ioat(4) NUMA-awareness..
Improve ioat(4) NUMA-awareness.
Sep 19 2019, 10:16 PM

Sep 18 2019

mav accepted D20677: Introduce quirks tunable for da driver.
Sep 18 2019, 7:42 PM
mav committed rS352493: Fix typo, setting hidden flag instead of reparse..
Fix typo, setting hidden flag instead of reparse.
Sep 18 2019, 7:33 PM

Sep 17 2019

mav requested changes to D20677: Introduce quirks tunable for da driver.

Generally I think it is good, but I think it should be set higher, after the "softc->quirks |= DA_Q_NO_6_BYTE;" line.

Sep 17 2019, 10:04 PM

Sep 15 2019

mav committed rS352369: Relax TX draining in ns8250_bus_transmit()..
Relax TX draining in ns8250_bus_transmit().
Sep 15 2019, 11:57 PM
mav committed rS352360: MFC r352258: Remove Tagged Command Queuing feature reporting..
MFC r352258: Remove Tagged Command Queuing feature reporting.
Sep 15 2019, 5:59 PM
mav committed rS352359: MFC r352258: Remove Tagged Command Queuing feature reporting..
MFC r352258: Remove Tagged Command Queuing feature reporting.
Sep 15 2019, 5:58 PM

Sep 13 2019

mav added inline comments to D21638: Add kqueue support for ZFS..
Sep 13 2019, 5:30 PM
mav committed rS352299: MFC r352201: Fix assumptions of only one device per SES slot..
MFC r352201: Fix assumptions of only one device per SES slot.
Sep 13 2019, 3:49 PM
mav committed rS352298: MFC r352201: Fix assumptions of only one device per SES slot..
MFC r352201: Fix assumptions of only one device per SES slot.
Sep 13 2019, 3:48 PM
mav committed rS352297: MFC r352257: Report Trusted Computing feature set support..
MFC r352257: Report Trusted Computing feature set support.
Sep 13 2019, 3:21 PM
mav committed rS352296: MFC r352257: Report Trusted Computing feature set support..
MFC r352257: Report Trusted Computing feature set support.
Sep 13 2019, 3:21 PM
mav committed rS352295: MFC r352200: Remove struct ata_res_pass16, unneeded after r352082..
MFC r352200: Remove struct ata_res_pass16, unneeded after r352082.
Sep 13 2019, 3:20 PM
mav committed rS352294: MFC r352200: Remove struct ata_res_pass16, unneeded after r352082..
MFC r352200: Remove struct ata_res_pass16, unneeded after r352082.
Sep 13 2019, 3:20 PM
mav committed rS352293: MFC r352111: Initialize page/subpage in case of `modepage -d`..
MFC r352111: Initialize page/subpage in case of `modepage -d`.
Sep 13 2019, 3:19 PM
mav committed rS352292: MFC r352111: Initialize page/subpage in case of `modepage -d`..
MFC r352111: Initialize page/subpage in case of `modepage -d`.
Sep 13 2019, 3:19 PM
mav committed rS352291: MFC r352082, r352103: Fix number of problems found while testing on SAT devices..
MFC r352082, r352103: Fix number of problems found while testing on SAT devices.
Sep 13 2019, 3:19 PM
mav committed rS352290: MFC r352082, r352103: Fix number of problems found while testing on SAT devices..
MFC r352082, r352103: Fix number of problems found while testing on SAT devices.
Sep 13 2019, 3:16 PM
mav committed rS352289: MFC r352018: Unify cam_send_ccb() error reporting..
MFC r352018: Unify cam_send_ccb() error reporting.
Sep 13 2019, 3:13 PM
mav committed rS352287: MFC r352018: Unify cam_send_ccb() error reporting..
MFC r352018: Unify cam_send_ccb() error reporting.
Sep 13 2019, 2:44 PM
mav committed rS352286: Supply SAT layer with valid transfer sizes..
Supply SAT layer with valid transfer sizes.
Sep 13 2019, 2:43 PM
mav committed rS352285: MFC r352011: Supply SAT layer with valid transfer sizes..
MFC r352011: Supply SAT layer with valid transfer sizes.
Sep 13 2019, 2:43 PM

Sep 12 2019

mav committed rS352258: Remove Tagged Command Queuing feature reporting..
Remove Tagged Command Queuing feature reporting.
Sep 12 2019, 5:42 PM
mav committed rS352257: Report Trusted Computing feature set support..
Report Trusted Computing feature set support.
Sep 12 2019, 5:21 PM

Sep 11 2019

mav committed rS352235: MFC r348268 (by sef), r348293 (by cem):.
MFC r348268 (by sef), r348293 (by cem):
Sep 11 2019, 11:46 PM
mav committed rS352234: MFC r342024 (by mmacy): Generalize AES iov optimization.
MFC r342024 (by mmacy): Generalize AES iov optimization
Sep 11 2019, 11:41 PM
mav committed rS352201: Fix assumptions of only one device per SES slot..
Fix assumptions of only one device per SES slot.
Sep 11 2019, 3:25 AM

Sep 10 2019

mav committed rS352200: Remove struct ata_res_pass16, unneeded after r352082..
Remove struct ata_res_pass16, unneeded after r352082.
Sep 10 2019, 11:51 PM

Sep 9 2019

mav committed rS352111: Initialize page/subpage in case of `modepage -d`..
Initialize page/subpage in case of `modepage -d`.
Sep 9 2019, 10:08 PM
mav committed rS352103: Add one more error message to r352082..
Add one more error message to r352082.
Sep 9 2019, 7:00 PM
mav committed rS352082: Fix number of problems found while testing on SAT devices..
Fix number of problems found while testing on SAT devices.
Sep 9 2019, 5:36 PM

Sep 7 2019

mav committed rS352018: Unify cam_send_ccb() error reporting..
Unify cam_send_ccb() error reporting.
Sep 7 2019, 4:52 PM
mav committed rS352011: Supply SAT layer with valid transfer sizes..
Supply SAT layer with valid transfer sizes.
Sep 7 2019, 3:56 PM

Sep 3 2019

mav committed rS351760: MFC r351134: Add support for 'j', 't' and 'z' flags to kernel sscanf()..
MFC r351134: Add support for 'j', 't' and 'z' flags to kernel sscanf().
Sep 3 2019, 4:39 PM
mav committed rS351759: MFC r351134: Add support for 'j', 't' and 'z' flags to kernel sscanf()..
MFC r351134: Add support for 'j', 't' and 'z' flags to kernel sscanf().
Sep 3 2019, 4:38 PM
mav committed rS351754: MFC r351606: Take proper lock in ses_setphyspath_callback()..
MFC r351606: Take proper lock in ses_setphyspath_callback().
Sep 3 2019, 4:25 PM
mav committed rS351752: MFC r351606: Take proper lock in ses_setphyspath_callback()..
MFC r351606: Take proper lock in ses_setphyspath_callback().
Sep 3 2019, 4:20 PM
mav committed rS351746: MFC r351550: Always check cam_periph_error() status for ERESTART..
MFC r351550: Always check cam_periph_error() status for ERESTART.
Sep 3 2019, 2:55 PM
mav committed rS351745: MFC r351550: Always check cam_periph_error() status for ERESTART..
MFC r351550: Always check cam_periph_error() status for ERESTART.
Sep 3 2019, 2:52 PM

Aug 29 2019

mav committed rS351606: Take proper lock in ses_setphyspath_callback()..
Take proper lock in ses_setphyspath_callback().
Aug 29 2019, 5:02 PM
mav added a comment to D20892: Add support for PCI Device ID 0x148B in ntb_hw_amd driver.

I have submitted the manpage for Review (https://reviews.freebsd.org/D21462). Please have a look and let me know your comments.

Aug 29 2019, 1:51 PM
mav committed rS351605: Man page for AMD Non-Transparent Bridge (ntb_hw_amd) driver..
Man page for AMD Non-Transparent Bridge (ntb_hw_amd) driver.
Aug 29 2019, 1:47 PM
Herald added a reviewer for D21462: Manpage for AMD Non-Transparent Bridge (ntb_hw_amd) driver: manpages.
Aug 29 2019, 1:47 PM
mav added a comment to D21462: Manpage for AMD Non-Transparent Bridge (ntb_hw_amd) driver.

I'll tune few minor things, like copyright year in the future, but otherwise it looks good.

Aug 29 2019, 1:43 PM

Aug 28 2019

mav committed rS351589: Fix AHCI Enclosure Management, broken by r351356..
Fix AHCI Enclosure Management, broken by r351356.
Aug 28 2019, 10:04 PM
mav committed rS351588: MFC r351352: Improve NVMe hot unplug handling..
MFC r351352: Improve NVMe hot unplug handling.
Aug 28 2019, 9:13 PM
mav committed rS351586: MFC r351320: Formalize NVMe controller consumer life cycle..
MFC r351320: Formalize NVMe controller consumer life cycle.
Aug 28 2019, 8:58 PM
mav committed rS351583: MFC r350677: Make GCC happy about math in r350676..
MFC r350677: Make GCC happy about math in r350676.
Aug 28 2019, 8:24 PM
mav committed rS351582: MFC r350676: Make `camcontrol modepage` support block descriptors..
MFC r350676: Make `camcontrol modepage` support block descriptors.
Aug 28 2019, 8:23 PM
mav committed rS351581: MFC r350457: Make `camcontrol modepage` to use 10 byte commands..
MFC r350457: Make `camcontrol modepage` to use 10 byte commands.
Aug 28 2019, 8:22 PM
mav committed rS351580: MFC r350424: Use present now scsi_mode_sense_subpage()..
MFC r350424: Use present now scsi_mode_sense_subpage().
Aug 28 2019, 8:21 PM
mav committed rS351579: MFC r350393: Decode some more IDENTIFY DEVICE bits..
MFC r350393: Decode some more IDENTIFY DEVICE bits.
Aug 28 2019, 8:20 PM
mav committed rS351574: MFV/ZoL: Fix wrong assertion in libzfs diff error handling.
MFV/ZoL: Fix wrong assertion in libzfs diff error handling
Aug 28 2019, 5:40 PM
mav closed D20118: Fix erroneous assert in libzfs diff.
Aug 28 2019, 5:39 PM
D20118: Fix erroneous assert in libzfs diff is now accepted and ready to land.
Aug 28 2019, 4:57 PM

Aug 27 2019

mav committed rS351550: Always check cam_periph_error() status for ERESTART..
Always check cam_periph_error() status for ERESTART.
Aug 27 2019, 4:41 PM
mav added a comment to D20892: Add support for PCI Device ID 0x148B in ntb_hw_amd driver.

Theoretically, I don't see any trouble in retaining the db_count in case of MSI and INTx fallback. But, how will it be helpful to have multiple doorbell with single interrupt? Can you give an idea please? Also, When you say,

You just need to provide valid amd_ntb_db_vector_mask() for that case.

db_valid_mask will be set as (db_count - 1 ) always (I assume, this should not be changed). So, if we don't reduce the db_count, how amd_ntb_db_vector_mask will create an impact?

Aug 27 2019, 2:21 PM
mav committed rS351539: MFC r351105, r351107: Limit memory window usage in ntb_transport to 256MB..
MFC r351105, r351107: Limit memory window usage in ntb_transport to 256MB.
Aug 27 2019, 4:16 AM
mav committed rS351538: MFC r351072: Implement new methods for Intel and PLX NTB..
MFC r351072: Implement new methods for Intel and PLX NTB.
Aug 27 2019, 4:15 AM
mav committed rS351537: MFC r351056, r351083: Add support for PCI Device ID 0x148B in ntb_hw_amd driver..
MFC r351056, r351083: Add support for PCI Device ID 0x148B in ntb_hw_amd driver.
Aug 27 2019, 4:14 AM
mav committed rS351536: MFC r349594, r349595, r349601: Add driver for NTB in AMD SoC..
MFC r349594, r349595, r349601: Add driver for NTB in AMD SoC.
Aug 27 2019, 4:13 AM
mav committed rS351535: MFC r351352: Improve NVMe hot unplug handling..
MFC r351352: Improve NVMe hot unplug handling.
Aug 27 2019, 4:04 AM
mav committed rS351534: MFC r351320: Formalize NVMe controller consumer life cycle..
MFC r351320: Formalize NVMe controller consumer life cycle.
Aug 27 2019, 4:04 AM
mav committed rS351533: MFC r351038: Print few more useful identify fields..
MFC r351038: Print few more useful identify fields.
Aug 27 2019, 4:02 AM
mav committed rS351532: MFC r351028: Report NOIOB and NPWG fields as stripe size..
MFC r351028: Report NOIOB and NPWG fields as stripe size.
Aug 27 2019, 4:02 AM
mav committed rS351531: MFC r351004, r351006: Make nvd(4) report NGUID or EUI64 as GEOM::lunid..
MFC r351004, r351006: Make nvd(4) report NGUID or EUI64 as GEOM::lunid.
Aug 27 2019, 4:01 AM
mav committed rS351530: MFC r350676, r350677: Make `camcontrol modepage` support block descriptors..
MFC r350676, r350677: Make `camcontrol modepage` support block descriptors.
Aug 27 2019, 3:55 AM
mav committed rS351529: MFC r350457: Make `camcontrol modepage` to use 10 byte commands..
MFC r350457: Make `camcontrol modepage` to use 10 byte commands.
Aug 27 2019, 3:54 AM
mav committed rS351528: MFC r350424: Use present now scsi_mode_sense_subpage()..
MFC r350424: Use present now scsi_mode_sense_subpage().
Aug 27 2019, 3:53 AM