Page MenuHomeFreeBSD
Feed Advanced Search

Yesterday

mav committed rS359686: Fix panic on kern.cam.ctl.ha_role change after r333446..
Fix panic on kern.cam.ctl.ha_role change after r333446.
Tue, Apr 7, 3:19 AM

Mon, Apr 6

mav committed rS359662: Relax too strict SES element descriptors check in r355430..
Relax too strict SES element descriptors check in r355430.
Mon, Apr 6, 6:42 PM
mav accepted D24303: carp tests: Basic functionality test.

Generally looks good to me, especially if we just test locking. For genera-purpose testing would be good to test master election, failover, etc.

Mon, Apr 6, 1:51 PM

Thu, Apr 2

mav committed rS359554: MFC r359112: MFOpenZFS: make zil max block size tunable.
MFC r359112: MFOpenZFS: make zil max block size tunable
Thu, Apr 2, 12:30 AM
mav committed rS359553: MFC r359112: MFOpenZFS: make zil max block size tunable.
MFC r359112: MFOpenZFS: make zil max block size tunable
Thu, Apr 2, 12:30 AM
mav committed rS359552: MFC r359110: Add missing STAILQ_INIT() in ciss_disable_adapter()..
MFC r359110: Add missing STAILQ_INIT() in ciss_disable_adapter().
Thu, Apr 2, 12:29 AM
mav committed rS359551: MFC r359110: Add missing STAILQ_INIT() in ciss_disable_adapter()..
MFC r359110: Add missing STAILQ_INIT() in ciss_disable_adapter().
Thu, Apr 2, 12:28 AM

Wed, Apr 1

mav committed rS359500: Add support for AHCI BIOS/OS Handoff..
Add support for AHCI BIOS/OS Handoff.
Wed, Apr 1, 3:28 AM
mav committed rS359499: Add ID for JMicron JMB582/JMB585 AHCI controller..
Add ID for JMicron JMB582/JMB585 AHCI controller.
Wed, Apr 1, 3:19 AM

Fri, Mar 27

mav committed rS359359: MFC r358959: Increase buffer in mprsas_log_command() from 192 to 224 bytes..
MFC r358959: Increase buffer in mprsas_log_command() from 192 to 224 bytes.
Fri, Mar 27, 1:30 PM
mav committed rS359358: MFC r358959: Increase buffer in mprsas_log_command() from 192 to 224 bytes..
MFC r358959: Increase buffer in mprsas_log_command() from 192 to 224 bytes.
Fri, Mar 27, 1:29 PM

Thu, Mar 26

mav committed rS359315: MFC r359146: Fix SES on device slots without phys after r349321..
MFC r359146: Fix SES on device slots without phys after r349321.
Thu, Mar 26, 12:43 AM
mav committed rS359314: MFC r359146: Fix SES on device slots without phys after r349321..
MFC r359146: Fix SES on device slots without phys after r349321.
Thu, Mar 26, 12:42 AM

Thu, Mar 19

mav committed rS359146: Fix SES on device slots without phys after r349321..
Fix SES on device slots without phys after r349321.
Thu, Mar 19, 5:21 PM
mav committed rS359112: MFOpenZFS: make zil max block size tunable.
MFOpenZFS: make zil max block size tunable
Thu, Mar 19, 1:06 AM
mav committed rS359110: Add missing STAILQ_INIT() in ciss_disable_adapter()..
Add missing STAILQ_INIT() in ciss_disable_adapter().
Thu, Mar 19, 12:20 AM

Wed, Mar 18

mav committed rS359109: MFC r349011 (by imp):.
MFC r349011 (by imp):
Wed, Mar 18, 11:53 PM
mav committed rS359108: MFC r349011 (by imp):.
MFC r349011 (by imp):
Wed, Mar 18, 11:53 PM
mav committed rS359107: MFC r331528 (by scottl): Update a TBD string with a real model number.
MFC r331528 (by scottl): Update a TBD string with a real model number
Wed, Mar 18, 11:22 PM

Mon, Mar 16

mav committed rS359018: Fix infinite scan on a pool with only special allocations.
Fix infinite scan on a pool with only special allocations
Mon, Mar 16, 7:03 PM
mav accepted D24086: Update OpenZFS ports.
Mon, Mar 16, 1:27 PM

Fri, Mar 13

mav committed rS358959: Increase buffer in mprsas_log_command() from 192 to 224 bytes..
Increase buffer in mprsas_log_command() from 192 to 224 bytes.
Fri, Mar 13, 2:51 PM

Thu, Mar 12

mav committed rS358905: MFC r358683: Remove vfs.zfs.top_maxinflight tunable/sysctl..
MFC r358683: Remove vfs.zfs.top_maxinflight tunable/sysctl.
Thu, Mar 12, 4:00 AM

Tue, Mar 10

mav committed rS358836: MFC r358580: Increase number of write completion threads, matching ZoL..
MFC r358580: Increase number of write completion threads, matching ZoL.
Tue, Mar 10, 3:19 PM
mav committed rS358835: MFC r358580: Increase number of write completion threads, matching ZoL..
MFC r358580: Increase number of write completion threads, matching ZoL.
Tue, Mar 10, 3:19 PM

Mar 5 2020

mav committed rS358683: Remove vfs.zfs.top_maxinflight tunable/sysctl..
Remove vfs.zfs.top_maxinflight tunable/sysctl.
Mar 5 2020, 7:44 PM

Mar 4 2020

mav committed rS358608: MFC r358357: MFZoL: Relax restriction on zfs_ioc_next_obj() iteration.
MFC r358357: MFZoL: Relax restriction on zfs_ioc_next_obj() iteration
Mar 4 2020, 4:45 AM
mav committed rS358607: MFC r358357: MFZoL: Relax restriction on zfs_ioc_next_obj() iteration.
MFC r358357: MFZoL: Relax restriction on zfs_ioc_next_obj() iteration
Mar 4 2020, 4:44 AM
mav committed rS358606: MFC r358342: MFZoL: Fix resilver writes in vdev_indirect_io_start.
MFC r358342: MFZoL: Fix resilver writes in vdev_indirect_io_start
Mar 4 2020, 4:43 AM
mav committed rS358605: MFC r358342: MFZoL: Fix resilver writes in vdev_indirect_io_start.
MFC r358342: MFZoL: Fix resilver writes in vdev_indirect_io_start
Mar 4 2020, 4:43 AM
mav committed rS358604: MFC r358339: MFZoL: Fix issue with scanning dedup blocks as scan ends.
MFC r358339: MFZoL: Fix issue with scanning dedup blocks as scan ends
Mar 4 2020, 4:42 AM
mav committed rS358603: MFC r358339: MFZoL: Fix issue with scanning dedup blocks as scan ends.
MFC r358339: MFZoL: Fix issue with scanning dedup blocks as scan ends
Mar 4 2020, 4:42 AM
mav committed rS358602: MFC r358337: MFZoL: Fix 2 small bugs with cached dsl_scan_phys_t.
MFC r358337: MFZoL: Fix 2 small bugs with cached dsl_scan_phys_t
Mar 4 2020, 4:41 AM
mav committed rS358601: MFC r358337: MFZoL: Fix 2 small bugs with cached dsl_scan_phys_t.
MFC r358337: MFZoL: Fix 2 small bugs with cached dsl_scan_phys_t
Mar 4 2020, 4:40 AM
mav committed rS358600: MFC r358336, r358340: MFZoL: Fix txg_sync_thread hang in scan_exec_io().
MFC r358336, r358340: MFZoL: Fix txg_sync_thread hang in scan_exec_io()
Mar 4 2020, 4:39 AM
mav committed rS358599: MFC r358340: Fix patch mismerge in r358336..
MFC r358340: Fix patch mismerge in r358336.
Mar 4 2020, 4:38 AM
mav committed rS358598: MFC r358336: MFZoL: Fix txg_sync_thread hang in scan_exec_io().
MFC r358336: MFZoL: Fix txg_sync_thread hang in scan_exec_io()
Mar 4 2020, 4:37 AM

Mar 3 2020

mav committed rS358580: Increase number of write completion threads, matching ZoL..
Increase number of write completion threads, matching ZoL.
Mar 3 2020, 3:05 PM

Feb 28 2020

mav added a comment to D23852: scsi_scan_bus: ignore Initiator ID for SAS transport in.

I am OK with that, but I think it can be too easy to forget, same as wrong value is set without understanding now. I am thinking whether introduction of some special constant value for initiator_id equal to UINT_MAX or something could be more explicit?

Feb 28 2020, 3:45 PM
mav added a comment to D23852: scsi_scan_bus: ignore Initiator ID for SAS transport in.
In D23852#524734, @avg wrote:

I would expect that if an initiator can also be a target then its target ID -- which, if I understand correctly, you suggest to be treated as an initiator ID -- would be from a different namespace than IDs of its targets.

Feb 28 2020, 1:13 AM

Feb 27 2020

mav added a comment to D23852: scsi_scan_bus: ignore Initiator ID for SAS transport in.

It is not a problem of UINT_MAX, it is a problem to ignore potentially correct reported value.

Feb 27 2020, 8:48 PM
mav added a comment to D23852: scsi_scan_bus: ignore Initiator ID for SAS transport in.

I agree with everything you say we should do. But we are not there yet, and until that time SIMs have to keep some sort of mapping table for CAM to use. From the CAM point now all target IDs of the SCSI domain the HBA is connected to, including the initiator_id are from that mapping table. I am not sure what exactly makes no sense to you in my descrintion of how things are working for FC now and why exactly the same is not applicable to SAS to add this dirty hack?

Feb 27 2020, 7:51 PM
mav accepted D23854: Unbreak openzfs ports.

I have no objections, but it would be good to request review from some port committers.

Feb 27 2020, 7:28 PM
mav added a comment to D23852: scsi_scan_bus: ignore Initiator ID for SAS transport in.

The patch will make XPT_SCAN_TGT/XPT_SCAN_BUS to scan target they should not.

Feb 27 2020, 7:17 PM
mav added a comment to D23852: scsi_scan_bus: ignore Initiator ID for SAS transport in.

As I have told, SAS may also work as target, we just miss respective SIM. And the code skipping the initiaror_id during scan allows to not scan own target, if we ever have non-FC targets. What is so difficult in fixing few SAS SIMs to report initiator_id out of the range of valid initiator role targets?

Feb 27 2020, 6:19 PM
mav requested changes to D23852: scsi_scan_bus: ignore Initiator ID for SAS transport in.

I think it is a wrong way to go. While specific initiator ID value has sense only on parallel SCSI and loop mode FC and is obsolete these days, the idea of having some id reserved for the local HBA itself makes a lot of sense for FC now, when isp(4) driver can operate both initiator and target role same time, and the initiator id is used to represent target role periphs, while other ids are used rot initiator role. Such concepts looks totally valid to me. Even though we do not have SAS target driver (I dreamed about it for years), I don't think we should make it impossible instead of trivially fixing few drivers.

Feb 27 2020, 4:09 PM

Feb 26 2020

mav committed rS358357: MFZoL: Relax restriction on zfs_ioc_next_obj() iteration.
MFZoL: Relax restriction on zfs_ioc_next_obj() iteration
Feb 26 2020, 8:39 PM
mav committed rS358342: MFZoL: Fix resilver writes in vdev_indirect_io_start.
MFZoL: Fix resilver writes in vdev_indirect_io_start
Feb 26 2020, 4:52 PM
mav committed rS358340: Fix patch mismerge in r358336..
Fix patch mismerge in r358336.
Feb 26 2020, 4:04 PM
mav committed rS358339: MFZoL: Fix issue with scanning dedup blocks as scan ends.
MFZoL: Fix issue with scanning dedup blocks as scan ends
Feb 26 2020, 4:00 PM
mav committed rS358337: MFZoL: Fix 2 small bugs with cached dsl_scan_phys_t.
MFZoL: Fix 2 small bugs with cached dsl_scan_phys_t
Feb 26 2020, 3:48 PM
mav committed rS358336: MFZoL: Fix txg_sync_thread hang in scan_exec_io().
MFZoL: Fix txg_sync_thread hang in scan_exec_io()
Feb 26 2020, 3:45 PM

Feb 25 2020

mav committed rS358313: MFC r349381: Avoid extra taskq_dispatch() calls by DMU..
MFC r349381: Avoid extra taskq_dispatch() calls by DMU.
Feb 25 2020, 3:53 PM
mav committed rS358312: MFC r349381: Avoid extra taskq_dispatch() calls by DMU..
MFC r349381: Avoid extra taskq_dispatch() calls by DMU.
Feb 25 2020, 3:53 PM

Feb 22 2020

mav accepted D23792: Add 'ctld -t'..
Feb 22 2020, 6:53 PM
mav committed rS358238: MFC r357685: Bind CTL backends taskqueues to the CTL process..
MFC r357685: Bind CTL backends taskqueues to the CTL process.
Feb 22 2020, 4:49 AM

Feb 21 2020

mav committed rS358204: MFC r357657: Remove duplicate dbufs accounting..
MFC r357657: Remove duplicate dbufs accounting.
Feb 21 2020, 4:33 AM
mav committed rS358201: MFC r357920: Add support for Hygon NTB PCI device in ntb_hw_amd driver..
MFC r357920: Add support for Hygon NTB PCI device in ntb_hw_amd driver.
Feb 21 2020, 4:30 AM
mav committed rS358200: MFC r357919: Add Hygon PCI ID and description for AHCI SATA controller..
MFC r357919: Add Hygon PCI ID and description for AHCI SATA controller.
Feb 21 2020, 4:29 AM
mav committed rS358199: MFC r357919: Add Hygon PCI ID and description for AHCI SATA controller..
MFC r357919: Add Hygon PCI ID and description for AHCI SATA controller.
Feb 21 2020, 4:29 AM

Feb 20 2020

mav committed rS358137: MFC r357639: Reduce number of atomic_add() calls in aggsum..
MFC r357639: Reduce number of atomic_add() calls in aggsum.
Feb 20 2020, 1:04 AM

Feb 18 2020

mav committed rS358060: MFC r357502: Few microoptimizations to dbuf layer..
MFC r357502: Few microoptimizations to dbuf layer.
Feb 18 2020, 1:22 AM
mav committed rS358059: MFC r357453: Unblock kstat.zfs.misc.dbufstats sysctls..
MFC r357453: Unblock kstat.zfs.misc.dbufstats sysctls.
Feb 18 2020, 1:19 AM

Feb 14 2020

mav committed rS357920: Add support for Hygon NTB PCI device in ntb_hw_amd driver..
Add support for Hygon NTB PCI device in ntb_hw_amd driver.
Feb 14 2020, 3:05 PM
mav closed D23565: ntb: Add Hygon Dhyana support.
Feb 14 2020, 3:05 PM
mav accepted D23565: ntb: Add Hygon Dhyana support.
Feb 14 2020, 3:00 PM
mav added inline comments to D23565: ntb: Add Hygon Dhyana support.
Feb 14 2020, 2:58 PM
mav committed rS357919: Add Hygon PCI ID and description for AHCI SATA controller..
Add Hygon PCI ID and description for AHCI SATA controller.
Feb 14 2020, 2:55 PM
mav closed D23556: ahci: Add Hygon Dhyana support.
Feb 14 2020, 2:55 PM
mav accepted D23556: ahci: Add Hygon Dhyana support.
Feb 14 2020, 2:55 PM

Feb 11 2020

mav committed rS357747: Enable commit access for Ryan Moeller (freqlabs)..
Enable commit access for Ryan Moeller (freqlabs).
Feb 11 2020, 12:44 AM

Feb 8 2020

mav committed rS357685: Bind CTL backends taskqueues to the CTL process..
Bind CTL backends taskqueues to the CTL process.
Feb 8 2020, 10:00 PM
mav committed rS357684: MFC r353678 (by avg):.
MFC r353678 (by avg):
Feb 8 2020, 9:56 PM

Feb 7 2020

mav committed rS357657: Remove duplicate dbufs accounting..
Remove duplicate dbufs accounting.
Feb 7 2020, 3:51 PM
mav committed rS357656: MFC r326956 (by cem):.
MFC r326956 (by cem):
Feb 7 2020, 3:28 PM
mav added inline comments to D23565: ntb: Add Hygon Dhyana support.
Feb 7 2020, 2:38 PM
mav added a comment to D23556: ahci: Add Hygon Dhyana support.

Hi. Does the Hygon really have only one AHCI ID where AMD had 5?

Feb 7 2020, 2:33 PM

Feb 6 2020

mav committed rS357639: Reduce number of atomic_add() calls in aggsum..
Reduce number of atomic_add() calls in aggsum.
Feb 6 2020, 8:33 PM
mav added a comment to D23541: Make BIO_SPEEDUP opt-in.

I won't object too much, but first addition of quite specialized command and then workaround for it does not make me particularly happy.

Feb 6 2020, 8:27 PM
mav added a comment to D23541: Make BIO_SPEEDUP opt-in.

I would honestly prefer drivers to report reasonable errors on unknown commands. That would fix the issue once and for all.

Feb 6 2020, 8:19 PM
mav accepted D23483: Fix for unbalanced EPOCH(9) usage in kernel interrupt handler.
Feb 6 2020, 4:23 PM

Feb 5 2020

mav committed rS357555: MFC r356993: Update route MTUs for bridge, lagg and vlan interfaces..
MFC r356993: Update route MTUs for bridge, lagg and vlan interfaces.
Feb 5 2020, 12:47 AM

Feb 4 2020

mav committed rS357502: Few microoptimizations to dbuf layer..
Few microoptimizations to dbuf layer.
Feb 4 2020, 3:54 PM
mav accepted D23483: Fix for unbalanced EPOCH(9) usage in kernel interrupt handler.

Looks good to me.

Feb 4 2020, 3:43 PM
mav accepted D23483: Fix for unbalanced EPOCH(9) usage in kernel interrupt handler.
Feb 4 2020, 3:23 PM
mav added a comment to D23483: Fix for unbalanced EPOCH(9) usage in kernel interrupt handler.

I am not sure what is the point of atomic there, except may be preventing compiler from optimizing it out, if that can happen somehow. Otherwise it looks fine to me. I don't remember the interrupt teardown semantics here to say whether use-after-free is possible, but I agree with @gallatin that flags may change in run time, causing epoch leak, so this code must be here.

Feb 4 2020, 3:23 PM

Feb 3 2020

mav added reviewers for D23478: rework how ZVOLs are updated in response to DSL operations: mmacy, ryan_freqlabs.com.
Feb 3 2020, 6:31 PM
mav committed rS357453: Unblock kstat.zfs.misc.dbufstats sysctls..
Unblock kstat.zfs.misc.dbufstats sysctls.
Feb 3 2020, 5:10 PM

Jan 30 2020

mav committed rS357297: MFC r356707: Map ECKSUM and EFRAGS from ZFS onto real errnos..
MFC r356707: Map ECKSUM and EFRAGS from ZFS onto real errnos.
Jan 30 2020, 4:39 PM
mav committed rS357296: MFC r343111,343113-343115 (by mckusick):.
MFC r343111,343113-343115 (by mckusick):
Jan 30 2020, 4:11 PM

Jan 28 2020

mav accepted D22077: Speed up "zpool import" in the presence of many zvols.

I have no objections, other than I would not use braces for the if's, or at least put the opening one in the first case on the same like, as Ryan proposed.

Jan 28 2020, 10:31 PM

Jan 22 2020

mav committed rS356993: Update route MTUs for bridge, lagg and vlan interfaces..
Update route MTUs for bridge, lagg and vlan interfaces.
Jan 22 2020, 8:37 PM
mav committed rS356961: MFC r356474, r356480, r356482, r356506:.
MFC r356474, r356480, r356482, r356506:
Jan 22 2020, 1:08 AM
mav committed rS356960: MFC r351357 (by imp): Document RST support in nvme(4) and ahci(4)..
MFC r351357 (by imp): Document RST support in nvme(4) and ahci(4).
Jan 22 2020, 1:04 AM
mav committed rS356959: MFC r347967 (by cem): nvd.4: Reference nda(4).
MFC r347967 (by cem): nvd.4: Reference nda(4)
Jan 22 2020, 1:03 AM
mav committed rS356958: MFC r341709 (by imp): Add nda(4) cross reference to nvme(4).
MFC r341709 (by imp): Add nda(4) cross reference to nvme(4)
Jan 22 2020, 12:52 AM
mav committed rS356957: MFC r355774 (by mmel): Properly synchronize completion DMA buffers..
MFC r355774 (by mmel): Properly synchronize completion DMA buffers.
Jan 22 2020, 12:49 AM
mav committed rS356956: MFC r355721 (by imp): Move to using bool instead of boolean_t.
MFC r355721 (by imp): Move to using bool instead of boolean_t
Jan 22 2020, 12:46 AM
mav committed rS356955: MFC r355631 (by imp): Move reset to the interrutp processing stage.
MFC r355631 (by imp): Move reset to the interrutp processing stage
Jan 22 2020, 12:44 AM
mav committed rS356954: MFC r355465 (by imp): trackers always know what qpair they are on.
MFC r355465 (by imp): trackers always know what qpair they are on
Jan 22 2020, 12:41 AM