Page MenuHomeFreeBSD
Differential D48686

cam: Implement ascq ranges correctly
AbandonedPublic
Actions

Authored by imp on Jan 25 2025, 8:10 PM.
Tags
None
Referenced Files
F158952023: D48686.id149973.diff
Mon, Jun 8, 4:53 AM
Unknown Object (File)
Sat, May 30, 1:36 AM
Unknown Object (File)
Thu, May 28, 6:54 AM
Unknown Object (File)
Wed, May 27, 11:11 PM
Unknown Object (File)
Thu, May 14, 12:51 PM
Unknown Object (File)
Thu, May 14, 2:46 AM
Unknown Object (File)
Wed, May 13, 12:08 PM
Unknown Object (File)
Mon, May 11, 3:19 PM
View All 84 Files
Subscribers
None

Details

Reviewers
mav
chs
ken
Group Reviewers
cam
Summary

Ensure that the range is between the first and second entries. At the
moment, all the SSQ_RANGE entries are tagged with 0xFF, no change is
expeccted.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62029
Build 58913: arc lint + arc unit

Event Timeline

imp created this revision.Jan 25 2025, 8:10 PM
Herald added a reviewer: cam. · View Herald TranscriptJan 25 2025, 8:10 PM
imp requested review of this revision.Jan 25 2025, 8:10 PM
imp added a parent revision: D48685: cam: Fix off by one error in ASC/ASCQ lookup.
Harbormaster completed remote builds in B62029: Diff 149973.Jan 25 2025, 8:10 PM
imp added a child revision: D48687: cam/da: Document what an 'invalid pack' means..Jan 25 2025, 8:10 PM
mav requested changes to this revision.Jan 27 2025, 4:08 PM

This change is unneeded. ascq <= table_entry->ascq is already checked few lines above.

This revision now requires changes to proceed.Jan 27 2025, 4:08 PM
imp abandoned this revision.Jan 27 2025, 5:13 PM

Bah! You're right. Punting on this one.

Revision Contents
Changeset List

PathSize
sys/
cam/
scsi/
7 lines

Diff 149973

View Options

sys/cam/scsi/scsi_all.c

Loading...