Differential D48688

cam/da: Only mark pack as valid if we know the size in daopen
ClosedPublic
Actions

Authored by imp on Jan 25 2025, 8:10 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Aug 14, 9:59 PM

	Unknown Object (File)
	Fri, Aug 14, 9:59 PM

	Unknown Object (File)
	Fri, Aug 14, 9:58 PM

	Unknown Object (File)
	Fri, Aug 14, 9:58 PM

	Unknown Object (File)
	Wed, Aug 12, 11:46 PM

	Unknown Object (File)
	Wed, Aug 12, 8:37 PM

	Unknown Object (File)
	Wed, Aug 12, 8:37 PM

	Unknown Object (File)
	Wed, Aug 12, 8:37 PM

Subscribers

None

Details

Reviewers

mav
chs
ken

Group Reviewers

Commits

rG82fc49a0bebf: cam/da: Only mark pack as valid if we know the size in daopen

Summary

Only mark the pack as 'valid' (eg clear the invalid bit) when we know
the size of the underlying drive and the periph hasn't been
invalidated. Previously, we'd unconditionally clear this bit, but
if the size isn't known, no I/O to the drive is possible.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jan 25 2025, 8:10 PM

Herald added a reviewer: cam. · View Herald TranscriptJan 25 2025, 8:10 PM

imp requested review of this revision.Jan 25 2025, 8:10 PM

imp added a parent revision: D48687: cam/da: Document what an 'invalid pack' means..

imp added a child revision: D48689: cam/da: Call cam_periph_invalidate on ENXIO in dadone.

Harbormaster completed remote builds in B62031: Diff 149975.Jan 25 2025, 8:10 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2025, 9:43 PM

Closed by commit rG82fc49a0bebf: cam/da: Only mark pack as valid if we know the size in daopen (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG82fc49a0bebf: cam/da: Only mark pack as valid if we know the size in daopen.

Revision Contents
Changeset List

Path

Size

sys/

cam/

scsi/

11 lines

Diff 150725

sys/cam/scsi/scsi_da.c

Loading...