Page MenuHomeFreeBSD

cam: Fix off by one error in ASC/ASCQ lookup
ClosedPublic

Authored by imp on Jan 25 2025, 8:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 8, 8:40 PM
Unknown Object (File)
Fri, Oct 3, 11:06 AM
Unknown Object (File)
Fri, Oct 3, 4:25 AM
Unknown Object (File)
Thu, Oct 2, 10:44 PM
Unknown Object (File)
Wed, Oct 1, 7:31 PM
Unknown Object (File)
Sat, Sep 27, 10:53 PM
Unknown Object (File)
Wed, Sep 17, 6:59 PM
Unknown Object (File)
Sep 12 2025, 10:30 PM
Subscribers
None

Details

Summary

To implement ranges of ASC/ASCQ codes, we set SS_RANGE on an entry with
the entry being the end (highest) of the range (with the prior entry
being the start). When looking up a ASC/ASCQ code, however, we return
the second entry, which just has the range info. Instead, return the
prior entry in these cases so we can print the ASC/ASCQ code string
correctly.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Jan 25 2025, 8:10 PM
imp added a parent revision: D48684: cam: Fail ASC 0x40.

I've noticed this issue too while looking on the previous patch.

This revision is now accepted and ready to land.Jan 27 2025, 4:05 PM
This revision was automatically updated to reflect the committed changes.