Page MenuHomeFreeBSD

cam: Fix off by one error in ASC/ASCQ lookup
ClosedPublic

Authored by imp on Sat, Jan 25, 8:10 PM.
Tags
None
Referenced Files
F109416521: D48685.diff
Tue, Feb 4, 7:10 PM
Unknown Object (File)
Fri, Jan 31, 9:16 AM
Unknown Object (File)
Thu, Jan 30, 3:12 AM
Unknown Object (File)
Wed, Jan 29, 10:06 PM
Unknown Object (File)
Wed, Jan 29, 7:56 PM
Unknown Object (File)
Wed, Jan 29, 7:54 PM
Unknown Object (File)
Tue, Jan 28, 6:07 PM
Unknown Object (File)
Tue, Jan 28, 3:04 AM
Subscribers
None

Details

Summary

To implement ranges of ASC/ASCQ codes, we set SS_RANGE on an entry with
the entry being the end (highest) of the range (with the prior entry
being the start). When looking up a ASC/ASCQ code, however, we return
the second entry, which just has the range info. Instead, return the
prior entry in these cases so we can print the ASC/ASCQ code string
correctly.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Sat, Jan 25, 8:10 PM
imp added a parent revision: D48684: cam: Fail ASC 0x40.

I've noticed this issue too while looking on the previous patch.

This revision is now accepted and ready to land.Mon, Jan 27, 4:05 PM
This revision was automatically updated to reflect the committed changes.