Page MenuHomeFreeBSD

cam/da: Remove redundant bp assignment
AbandonedPublic

Authored by imp on Feb 4 2025, 6:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 4, 6:09 PM
Unknown Object (File)
Sun, Mar 2, 5:47 AM
Unknown Object (File)
Fri, Feb 21, 4:57 PM
Unknown Object (File)
Wed, Feb 19, 10:38 PM
Unknown Object (File)
Fri, Feb 14, 7:24 AM
Unknown Object (File)
Thu, Feb 13, 8:10 PM
Unknown Object (File)
Mon, Feb 10, 8:27 PM
Unknown Object (File)
Mon, Feb 10, 12:07 PM
Subscribers
None

Details

Reviewers
mav
ken
Group Reviewers
cam
Summary

We assigned bp before we fell into this loop. Since nothing can change
the bp associated with a ccb after we've assigned it in the da driver,
there's no need for this assignment.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62254
Build 59138: arc lint + arc unit

Event Timeline

When the selected delete method isn't supported, and we retry with others, we can make bp go NULL since we requeue the command so it's reprocessed in dastart again. different delete methods have different limitations on size, so we can't just transform it to something else or fail the I/O.