Page MenuHomeFreeBSD
Differential D48686

cam: Implement ascq ranges correctly
AbandonedPublic
Actions

Authored by imp on Jan 25 2025, 8:10 PM.
Tags
None
Referenced Files
F111032909: D48686.diff
Wed, Feb 26, 11:46 AM
Unknown Object (File)
Sun, Feb 16, 3:41 PM
Unknown Object (File)
Wed, Feb 5, 5:10 PM
Unknown Object (File)
Tue, Feb 4, 6:07 PM
Unknown Object (File)
Mon, Feb 3, 5:52 AM
Unknown Object (File)
Sat, Feb 1, 10:36 PM
Unknown Object (File)
Fri, Jan 31, 1:24 PM
Subscribers
None

Details

Reviewers
mav
chs
ken
Group Reviewers
cam
Summary

Ensure that the range is between the first and second entries. At the
moment, all the SSQ_RANGE entries are tagged with 0xFF, no change is
expeccted.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62029
Build 58913: arc lint + arc unit

Event Timeline

imp created this revision.Jan 25 2025, 8:10 PM
Herald added a reviewer: cam. · View Herald TranscriptJan 25 2025, 8:10 PM
imp requested review of this revision.Jan 25 2025, 8:10 PM
imp added a parent revision: D48685: cam: Fix off by one error in ASC/ASCQ lookup.
Harbormaster completed remote builds in B62029: Diff 149973.Jan 25 2025, 8:10 PM
imp added a child revision: D48687: cam/da: Document what an 'invalid pack' means..Jan 25 2025, 8:10 PM
mav requested changes to this revision.Mon, Jan 27, 4:08 PM

This change is unneeded. ascq <= table_entry->ascq is already checked few lines above.

This revision now requires changes to proceed.Mon, Jan 27, 4:08 PM
imp abandoned this revision.Mon, Jan 27, 5:13 PM

Bah! You're right. Punting on this one.

Revision Contents
Changeset List

PathSize
sys/
cam/
scsi/
7 lines

Diff 149973

View Options

sys/cam/scsi/scsi_all.c

Loading...