Page MenuHomeFreeBSD

jlduran_gmail.com (Jose Luis Duran)
User

Projects

User Details

User Since
May 30 2017, 11:42 AM (359 w, 6 d)

Recent Activity

Today

jlduran_gmail.com added inline comments to D44871: adduser: A few more improvements..
Mon, Apr 22, 7:02 PM
jlduran_gmail.com added inline comments to D44871: adduser: A few more improvements..
Mon, Apr 22, 7:02 PM
jlduran_gmail.com added inline comments to D44871: adduser: A few more improvements..
Mon, Apr 22, 6:50 PM

Mar 19 2024

jlduran_gmail.com added a comment to D43242: rc.initdiskless: Disable soft-updates in mdmfs (again).

Seems like this should land? We're just missing a commit log message based on the commentary in this review.

Mar 19 2024, 2:59 PM
jlduran_gmail.com updated the summary of D43242: rc.initdiskless: Disable soft-updates in mdmfs (again).
Mar 19 2024, 2:56 PM

Mar 1 2024

jlduran_gmail.com added a comment to D44162: Cirrus-CI: bump Clang versions to 17 and 18.
In D44162#1007618, @dim wrote:

It is worth noting that building with clang 18 currently fails (https://api.cirrus-ci.com/v1/task/5600331233492992/logs/build_world.log), I imagine this will be ironed out as we go along.

Yeah this is https://github.com/llvm/llvm-project/pull/75748, which I pulled into the llvm-18-update branch. But I don't know if it is in the llvm18 port.

Mar 1 2024, 3:37 PM
jlduran_gmail.com added a comment to D44162: Cirrus-CI: bump Clang versions to 17 and 18.

It is worth noting that building with clang 18 currently fails (https://api.cirrus-ci.com/v1/task/5600331233492992/logs/build_world.log), I imagine this will be ironed out as we go along.

Mar 1 2024, 10:15 AM

Feb 29 2024

jlduran_gmail.com accepted D44162: Cirrus-CI: bump Clang versions to 17 and 18.

Use 16 and 17 for now, 18 gave me pkg: No packages available to install matching 'llvm18-lite' have been found in the repositories. Will replace 16 with 18 later.

Feb 29 2024, 11:06 PM

Feb 12 2024

jlduran_gmail.com accepted D43826: rc.subr add Exists so we can find sed.
Feb 12 2024, 4:04 AM

Feb 11 2024

jlduran_gmail.com added a comment to D43826: rc.subr add Exists so we can find sed.

This looks good. It makes an extra effort to find sed.
I just wonder if it is possible to define SED=${SED:-$(Exists -x /usr/bin/sed /rescue/sed)} only once in rc.subr, maybe at the beginning?
ShellCheck usually recommends avoiding backticks (https://www.shellcheck.net/wiki/SC2006).

Feb 11 2024, 4:47 PM

Feb 6 2024

jlduran_gmail.com added a comment to D42876: ntp: change ntp_leapfile_sources to use IERS version of leap-seconds.list, as IETF is no longer providing the service..

Updated in 11da791920ba285f0832f09cb504ac81e35ff8d1.

Feb 6 2024, 11:34 PM

Jan 20 2024

jlduran_gmail.com added a comment to D43516: New version of jng (2.0).

Nice!
I have slightly tested it, and it is backwards compatible... even with the old (unrelated) bug 268397 (this is probably a race somewhere else), that reproduces easily by stopping/starting the jail service 10 times (repo/branch here: https://github.com/jlduran/jng-jib-jails-test/tree/jng2)

Jan 20 2024, 3:23 PM
jlduran_gmail.com added a comment to D43522: firmware: Allow binary files to be loaded by /boot/loader.

Minor typo.

Jan 20 2024, 2:44 PM

Jan 4 2024

jlduran_gmail.com added a comment to D43242: rc.initdiskless: Disable soft-updates in mdmfs (again).
In D43242#987249, @imp wrote:

Please don't do both pull requests and phab reviews for the same thing.

Jan 4 2024, 3:19 PM
jlduran_gmail.com updated the test plan for D43242: rc.initdiskless: Disable soft-updates in mdmfs (again).
Jan 4 2024, 7:37 AM

Dec 30 2023

jlduran_gmail.com requested review of D43242: rc.initdiskless: Disable soft-updates in mdmfs (again).
Dec 30 2023, 8:15 AM
jlduran_gmail.com added a comment to D43232: nanobsd: Revert back to 1G (really 927M) partitions for rescue..

I was not able to run the _.disk.iso image (maybe it gets truncated?), nowadays, a memstick makes more sense anyway.

Dec 30 2023, 7:38 AM
jlduran_gmail.com requested review of D43241: rc.initdiskless: Remove bogus plus sign.
Dec 30 2023, 7:28 AM
jlduran_gmail.com accepted D43232: nanobsd: Revert back to 1G (really 927M) partitions for rescue..
Dec 30 2023, 2:02 AM

Dec 28 2023

jlduran_gmail.com added a comment to D43161: vtnet: Better adjust for ethernet alignment..

This one landed as e9da71cd35d46ca13da4396d99e0af1703290e68 ?

Dec 28 2023, 6:40 AM

Dec 13 2023

jlduran_gmail.com updated the summary of D43035: nanobsd: Fix the fix to a typo.
Dec 13 2023, 6:06 PM
jlduran_gmail.com requested review of D43035: nanobsd: Fix the fix to a typo.
Dec 13 2023, 4:29 PM
jlduran_gmail.com added a comment to R11:4826396e5d15: security/vuxml: correct last SA's affected range.

Hi! It appears that bug #275743 is reporting something similar for 12.4.

Dec 13 2023, 4:20 PM

Dec 11 2023

jlduran_gmail.com added a comment to D42968: freebsd-update: Mention upgrading packages, not just ports.

This is simple, yet useful enough... being more specific may confuse users (just like me). I for one, do a pkg upgrade -y, however, pkg will recommend you a pkg bootstrap -f, but I never know if pkg-static is actually preferred.

Dec 11 2023, 8:22 PM

Dec 9 2023

jlduran_gmail.com added inline comments to D42908: Cirrus-CI: forcably upgrade pkg to latest.
Dec 9 2023, 1:23 AM

Dec 7 2023

jlduran_gmail.com abandoned D42926: mtree: Sync with upstream.

Note to self:
It will likely land as two separate commits:

  1. Vendor import of vendor/NetBSD/mtree.
  2. Vendor import of vendor/NetBSD/tests.
Dec 7 2023, 4:00 PM
jlduran_gmail.com added a comment to D42876: ntp: change ntp_leapfile_sources to use IERS version of leap-seconds.list, as IETF is no longer providing the service..

b1c95af45488bef649e9a84890e2414ff80b3a00 landed, somehow I preferred this one from the IERS.

Dec 7 2023, 3:30 PM

Dec 6 2023

jlduran_gmail.com updated the summary of D42926: mtree: Sync with upstream.
Dec 6 2023, 2:13 PM
jlduran_gmail.com requested review of D42926: mtree: Sync with upstream.
Dec 6 2023, 2:12 PM

Dec 5 2023

jlduran_gmail.com abandoned D42907: Alternative version of D42903.
Dec 5 2023, 10:32 PM
jlduran_gmail.com added a comment to D42908: Cirrus-CI: forcably upgrade pkg to latest.

Or if someone from ports can MFC pkg into quarterly, even better. But this is good for now. Thank you!

Dec 5 2023, 6:49 PM
jlduran_gmail.com added a comment to D42903: Cirrus-CI: let build user run git.

I've chosen to retain the git config change and not do chown of the source tree (only one of them is required). IMO it's useful to test with a read-only tree to since any such write is a bug in the normal build process.

Yes!

Dec 5 2023, 6:46 PM
jlduran_gmail.com retitled D42907: Alternative version of D42903 from Alternate version of D42903 to Alternative version of D42903.
Dec 5 2023, 3:35 PM
jlduran_gmail.com added a comment to D42907: Alternative version of D42903.
NOTE: Some actions are still failing (until D42868 lands).
Dec 5 2023, 3:33 PM
jlduran_gmail.com added a comment to D42907: Alternative version of D42903.

Sorry, I got the revision numbers initially wrong. This is my take on D42903.

Dec 5 2023, 3:27 PM
jlduran_gmail.com retitled D42907: Alternative version of D42903 from Alternate version of D42868 to Alternate version of D42903.
Dec 5 2023, 3:25 PM
jlduran_gmail.com requested review of D42907: Alternative version of D42903.
Dec 5 2023, 3:24 PM
jlduran_gmail.com added a comment to D42903: Cirrus-CI: let build user run git.

https://cirrus-ci.com/task/5157804504252416?logs=setup#L15 states that pkg version is 1.20.8, so @override_prefix is not yet available (starting on 1.20.9):

Dec 5 2023, 6:07 AM

Dec 2 2023

jlduran_gmail.com added a comment to D36309: Allow to specify umask(1) for a service started with rc(8).

Is there a reason why this change was not MFCd? Thank you!

Forgot about it. I've just merged it downto stable/12.

Dec 2 2023, 12:41 PM · rc

Dec 1 2023

jlduran_gmail.com added a comment to D42847: sort: test against all month formats in month-sort.

quite a few other platforms don't have them.

I had missed this important bit. Thank you!

Dec 1 2023, 7:55 PM
jlduran_gmail.com accepted D42868: sort: Only build FreeBSD-specific ALTMON_x stuff when ATLMON_1 is defined.
In D42868#977777, @imp wrote:

I plan to push this EOD if I don't hear anything (since it is a build and CI breakage).
However, if there's something better in the wings, I'll back off.. and if something better comes along after my deadline, I'm totally cool deferring to that as well. (unless it is ifdef apple :).

Dec 1 2023, 7:28 PM
jlduran_gmail.com added a comment to D42847: sort: test against all month formats in month-sort.

Thank you for this nice addition! It does, however, fail when cross-building on macOS:

Hum. Thanks for the report. So we're missing definitions of ALTMON_*. I don't see a preprocessor constant that we can use to gate that

I was thinking about adding an extra header file to tools/build/cross-build/include/mac (with these definitions) and using it to cross-build... but yes, let's gather other opinions.

I think that doesn't make sense unless the corresponding locale files (e.g., /usr/share/local/el_GR.UTF-8/LC_TIME) are also installed on the host?

Hum... Maybe I'm missing something:

➜  uname -a                                      
Darwin macbook-pro.home.arpa 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:28:12 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T8103 arm64
➜  cat /usr/share/locale/el_GR.UTF-8/LC_TIME
Ιαν
Φεβ
Μαρ
Απρ
Μαϊ
Ιον
Ιολ
Αυγ
Σεπ
Οκτ
Νοε
Δεκ
Ιανουαρίου
Φεβρουαρίου
Μαρτίου
Απριλίου
Μαΐου
Ιουνίου
Ιουλίου
Αυγούστου
Σεπτεμβρίου
Οκτωβρίου
Νοεμβρίου
Δεκεμβρίου
Κυρ
Δευ
Τρι
Τετ
Πεμ
Παρ
Σαβ
Κυριακή
Δευτέρα
Τρίτη
Τετάρτη
Πέμπτη
Παρασκευή
Σάββατο
%H:%M:%S
%d/%m/%Y
%a %e %b %X %Y
πμ
μμ
%a %e %b %Y %X %Z
Ιανουάριος
Φεβρουάριος
Μάρτιος
Απρίλιος
Μάϊος
Ιούνιος
Ιούλιος
Αύγουστος
Σεπτέμβριος
Οκτώβριος
Νοέμβριος
Δεκέμβριος
dm
%I:%M:%S %p
Dec 1 2023, 7:08 PM
jlduran_gmail.com added a comment to D42847: sort: test against all month formats in month-sort.

Thank you for this nice addition! It does, however, fail when cross-building on macOS:

Hum. Thanks for the report. So we're missing definitions of ALTMON_*. I don't see a preprocessor constant that we can use to gate that

Dec 1 2023, 6:53 PM
jlduran_gmail.com added a comment to D42847: sort: test against all month formats in month-sort.

Thank you for this nice addition! It does, however, fail when cross-building on macOS:
https://pipelinesghubeus2.actions.githubusercontent.com/8Zobszzx1fzKxF8BHSJLzmYvAIfV7kuYLyhz5o35SqgHcKvvbE/_apis/pipelines/1/runs/19723/signedlogcontent/7?urlExpires=2023-12-01T17%3A06%3A05.6816198Z&urlSigningMethod=HMACV1&urlSignature=SNFGWVRwQUneUXeKKdbEWuKQ64ngWnBLEXpcY8%2FCEI0%3D
The reason being, Darwin does not have those constants (defined in a250649bd8d6999d8511cb826085deb34236f3f3 ):
https://github.com/apple-oss-distributions/Libc/blob/main/include/langinfo.h
On Linux, this is not a problem (https://www.gnu.org/software/libc/manual/html_node/The-Elegant-and-Fast-Way.html).
I trust you would know how best to proceed, whether manually adding the constants to the cross-build tools or #ifdef-ing APPLE or else.
Thank you again!

Dec 1 2023, 5:33 PM

Nov 28 2023

jlduran_gmail.com requested review of D42791: zfs tests: Silence clang warning.
Nov 28 2023, 7:24 PM
jlduran_gmail.com added a comment to D41436: netlink: Add tests when adding an interface route.

Is that really testing for the same case?

# setup_vnet(pytest:TestRtNlRoute:test_add_route4_ll_gw)
run: '/sbin/sysctl net.inet6.ip6.dad_count=0'
run: '/sbin/ifconfig epair0a up'
run: '/usr/sbin/ndp -i epair0a -disabled'
run: '/sbin/ifconfig epair0a inet6 2001:db8::1/64'
run: '/sbin/ifconfig epair0a inet6'
run: '/sbin/ifconfig tun create'

The whole point of D41330 was to handle the case where the interface doesn't have a v4/v6 address.

Nov 28 2023, 7:03 PM
jlduran_gmail.com updated the diff for D41436: netlink: Add tests when adding an interface route.
  • Add test for IPv6
  • Update commit message (plural)
Nov 28 2023, 6:51 PM
jlduran_gmail.com planned changes to D41436: netlink: Add tests when adding an interface route.
In D41436#976151, @rcm wrote:
In D41436#976125, @rcm wrote:

Would it be possible to also get a v6 case?

Line 29?

ah yes, I should have scrolled up.

Is that really testing for the same case?

# setup_vnet(pytest:TestRtNlRoute:test_add_route4_ll_gw)
run: '/sbin/sysctl net.inet6.ip6.dad_count=0'
run: '/sbin/ifconfig epair0a up'
run: '/usr/sbin/ndp -i epair0a -disabled'
run: '/sbin/ifconfig epair0a inet6 2001:db8::1/64'
run: '/sbin/ifconfig epair0a inet6'
run: '/sbin/ifconfig tun create'

The whole point of D41330 was to handle the case where the interface doesn't have a v4/v6 address.

Nov 28 2023, 5:49 PM
jlduran_gmail.com added a comment to D41436: netlink: Add tests when adding an interface route.
In D41436#976125, @rcm wrote:

Would it be possible to also get a v6 case?

Line 29?

Nov 28 2023, 5:23 PM
jlduran_gmail.com added a reviewer for D41436: netlink: Add tests when adding an interface route: rcm.
Nov 28 2023, 2:41 PM

Nov 26 2023

jlduran_gmail.com added a comment to D41330: netlink: fix adding an interface route.

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275341
Fixes:

# ifconfig wg1 create
# ifconfig wg1 up
# route -n add 10.2.0.0/24 -interface wg1
Nov 26 2023, 12:52 AM

Nov 9 2023

jlduran_gmail.com added a comment to D42114: ping: Avoid reporting NaNs.

Sorry to bother again, would it be possible to MFC just this commit (4d348e83b738347f6aaf2b110459a01c5402d04e) to stable/13, the other commits in this series cannot be applied.
Reported by: Jenkins
https://ci.freebsd.org/view/Test/job/FreeBSD-stable-13-riscv64-test/936/testReport/sbin.ping/

Nov 9 2023, 7:49 PM

Nov 8 2023

jlduran_gmail.com added a comment to D42498: bsdbox: fix the build.

make -C lib/libifconfig && make -C lib/libnv && make -C tools/bsdbox works. Thanks!

Nov 8 2023, 7:51 AM

Nov 6 2023

jlduran_gmail.com added a comment to D42114: ping: Avoid reporting NaNs.

I would like to kindly request an MFC to stable/14 of at least this fix.
Reported by: Jenkins
https://ci.freebsd.org/view/Test/job/FreeBSD-stable-14-riscv64-test/lastCompletedBuild/testReport/sbin.ping/ping_test/ping6_c1_s8_t1/
(pasting RISC-V, as aarch64 images are failing)

Done, thanks for the reminder.

Nov 6 2023, 5:00 PM
jlduran_gmail.com added a comment to D42114: ping: Avoid reporting NaNs.

I would like to kindly request an MFC to stable/14 of at least this fix.
Reported by: Jenkins
https://ci.freebsd.org/view/Test/job/FreeBSD-stable-14-riscv64-test/lastCompletedBuild/testReport/sbin.ping/ping_test/ping6_c1_s8_t1/
(pasting RISC-V, as aarch64 images are failing)

Nov 6 2023, 2:36 PM

Nov 2 2023

jlduran_gmail.com updated the summary of D42438: dtc: Sync with upstream commit 23387dd.
Nov 2 2023, 12:49 AM
jlduran_gmail.com requested review of D42438: dtc: Sync with upstream commit 23387dd.
Nov 2 2023, 12:40 AM

Oct 26 2023

jlduran_gmail.com added inline comments to D42369: bsdinstall: Remove unused variables in fetchmissingdists.
Oct 26 2023, 10:13 PM

Oct 21 2023

jlduran_gmail.com added a comment to D42321: Add expected failure for atime test failing on.

With this applied:

# kyua test -k /usr/tests/sys/fs/tmpfs/Kyuafile
...
82/82 passed (0 failed)

I believe this is the only (consistent) test failure in 14.0-R

Oct 21 2023, 5:11 PM
jlduran_gmail.com added a comment to D42321: Add expected failure for atime test failing on.

I think that we should import https://github.com/NetBSD/src/commit/38862c874c4a2bcca9dce5c0966ea19ddabd523e first.
I wonder if we should skip only the failing one?

Oct 21 2023, 5:10 PM

Oct 18 2023

jlduran_gmail.com added a comment to D42268: ping tests: Fix test on 32-bit platforms.

I do not have a 32-bit VM at the moment, would it be possible to run the test on ci.freebsd.org, and verify that test:

Unfortunately there's no easy way to manually test patches using ci.freebsd.org yet. In the meantime I downloaded an i386 VM image and verified that the test passes.

Oct 18 2023, 6:29 PM
jlduran_gmail.com added a comment to D42270: pf: Update documentation regarding matching, scrubbing and reassembly.

Thank you! I think the project insists that the documentation be in American English:

Oct 18 2023, 12:46 PM

Oct 17 2023

jlduran_gmail.com requested review of D42268: ping tests: Fix test on 32-bit platforms.
Oct 17 2023, 4:26 PM

Oct 16 2023

jlduran_gmail.com added a comment to D41040: xargs: Avoid a possible multiplication overflow.

Test disabled in 2682a15527241278c9aa46c4907d3b07460b8ec0.

Oct 16 2023, 11:53 PM

Oct 14 2023

jlduran_gmail.com updated subscribers of D42203: Add ping6 as MLINK to ping.

As long as we are keeping the old ping6 as an alias, I believe this is OK. Try pinging @asomers .

Oct 14 2023, 4:32 PM

Oct 12 2023

jlduran_gmail.com requested review of D42175: ping tests: Run tests unprivileged inside a vnet.
Oct 12 2023, 6:48 PM
jlduran_gmail.com requested review of D42174: ping tests: Silence deprecation warnings.
Oct 12 2023, 6:46 PM

Oct 11 2023

jlduran_gmail.com abandoned D38485: ping: Add units to SIGINFO's statistics.
Oct 11 2023, 8:04 PM

Oct 10 2023

jlduran_gmail.com added a comment to D42114: ping: Avoid reporting NaNs.

I'll submit it with the unification of ping/ping6's statistics section (D39126).

Are some of your older ping patches ready to commit? Please point me at them if so.

Oct 10 2023, 6:44 AM

Oct 9 2023

jlduran_gmail.com accepted D42129: file: Support testing multiple magic files..
Oct 9 2023, 9:31 AM

Oct 7 2023

jlduran_gmail.com reclaimed D42114: ping: Avoid reporting NaNs.

Updated commit message.

Oct 7 2023, 10:37 AM
jlduran_gmail.com updated the summary of D42114: ping: Avoid reporting NaNs.
Oct 7 2023, 10:36 AM

Oct 6 2023

jlduran_gmail.com abandoned D42114: ping: Avoid reporting NaNs.

As you well pointed out, here is the fix from NetBSD:

Oct 6 2023, 10:09 PM
jlduran_gmail.com added a comment to D42114: ping: Avoid reporting NaNs.

I'll investigate a bit further. I am able to reproduce it on my mac:

Oct 6 2023, 9:52 PM
jlduran_gmail.com added a comment to D42114: ping: Avoid reporting NaNs.

If we were computing with real numbers, then it should be impossible for vari to ever be negative. And in fact, all of the failing tests use -t 1, which means that n will be 1, so vari should always be exactly zero. So the fact that you're seeing these errors must mean that we're hitting some kind of floating point round-off error.

Oct 6 2023, 8:25 PM
jlduran_gmail.com requested review of D42114: ping: Avoid reporting NaNs.
Oct 6 2023, 6:13 PM

Sep 28 2023

jlduran_gmail.com requested review of D42006: dtc: Ensure it is built in C++17 mode.
Sep 28 2023, 8:10 AM
jlduran_gmail.com added a comment to D42004: freebsd-update: skip special kernel handling for non-host upgrades.

Will this affect upgrading poudriere jails with a kernel, see poudriere-jail(8)'s -K?

Sep 28 2023, 12:54 AM

Sep 27 2023

jlduran_gmail.com added a comment to D41482: dtc: Sync with upstream commit 26a0fe5.

I noticed this change broke macOS cross-builds on GitHub. I guess due to the fact that man clang on macOS says: The default C++ language standard is gnu++98.

Sep 27 2023, 5:27 PM

Sep 11 2023

jlduran_gmail.com updated subscribers of D41105: Cleanup pthread locks in ofed RDMA verbs.

Ping. Any reviewers?

Sep 11 2023, 6:03 PM

Sep 6 2023

jlduran_gmail.com accepted D41751: release: remove inet blackhole sysctls from GCE config.
Sep 6 2023, 2:33 PM
jlduran_gmail.com updated subscribers of D41751: release: remove inet blackhole sysctls from GCE config.

Nice! Thank you!
Also PMTUD problems, UNIX traceroute "not working", the list of issues can be long.
I'll go ahead and disturb @freebsd-transport, to ask if they have something to say against this change.

Sep 6 2023, 11:23 AM

Aug 17 2023

jlduran_gmail.com updated the diff for D41482: dtc: Sync with upstream commit 26a0fe5.
  • Remove extra white lines after the $FreeBSD$ tag removal
Aug 17 2023, 2:29 AM

Aug 16 2023

jlduran_gmail.com updated the diff for D41482: dtc: Sync with upstream commit 26a0fe5.
  • Rebase (remove FreeBSD RCSIDs).
Aug 16 2023, 7:28 PM
jlduran_gmail.com requested review of D41482: dtc: Sync with upstream commit 26a0fe5.
Aug 16 2023, 3:39 PM

Aug 12 2023

jlduran_gmail.com updated subscribers of D41436: netlink: Add tests when adding an interface route.

@emaste I was just curious if there is a release-blocking metabug, just like PR 271607, but for phabricator?
I believe D41330 should be in the blocking list.

Aug 12 2023, 4:40 PM
jlduran_gmail.com requested review of D41436: netlink: Add tests when adding an interface route.
Aug 12 2023, 4:31 PM

Aug 11 2023

jlduran_gmail.com added a comment to D41399: GoogleTest 1.14.0: import.

As you might already know, commit 28f6c2f292806bf31230a959bc4b19d7081669a7 broke GCC 12 compilation (https://cirrus-ci.com/task/6695038801936384).
I did the lazy thing and added:

CXXFLAGS.gcc+= -Wno-error

to gmock_main/Makefile and gtest_main/Makefile, but I believe a more granular approach is also desired for GCC.

Aug 11 2023, 6:19 PM

Aug 9 2023

jlduran_gmail.com added inline comments to D41354: ath(4): Remove MIPS AHB frontend and join PCI one w/ main support again.
Aug 9 2023, 4:22 PM
jlduran_gmail.com added inline comments to D41354: ath(4): Remove MIPS AHB frontend and join PCI one w/ main support again.
Aug 9 2023, 12:39 AM

Aug 5 2023

jlduran_gmail.com updated the diff for D41287: arm64: Fix typo in comments.

Rebase.

Aug 5 2023, 5:27 PM · Contributor Reviews (src)

Aug 3 2023

jlduran_gmail.com updated the test plan for D41287: arm64: Fix typo in comments.
Aug 3 2023, 11:14 PM · Contributor Reviews (src)

Aug 1 2023

jlduran_gmail.com added inline comments to D40893: arm64: Decode the ID_AA64MMFR3_EL1 register.
Aug 1 2023, 8:43 PM
jlduran_gmail.com requested review of D41287: arm64: Fix typo in comments.
Aug 1 2023, 8:39 PM · Contributor Reviews (src)

Jul 31 2023

jlduran_gmail.com added inline comments to D41040: xargs: Avoid a possible multiplication overflow.
Jul 31 2023, 4:48 PM

Jul 28 2023

jlduran_gmail.com added inline comments to D40893: arm64: Decode the ID_AA64MMFR3_EL1 register.
Jul 28 2023, 8:13 PM

Jul 19 2023

jlduran_gmail.com added a comment to D41101: amd64 crt1: Explicitly use a PLT entry for main in the PIC case..

Thank you!
I also had to add:

LDFLAGS+=       -Wl,-znoexecstack

to secure/lib/libcrypto/**/**/Makefile.

Jul 19 2023, 9:26 PM
jlduran_gmail.com added a comment to D36309: Allow to specify umask(1) for a service started with rc(8).

Is there a reason why this change was not MFCd? Thank you!

Jul 19 2023, 4:45 PM · rc

Jul 14 2023

jlduran_gmail.com requested review of D41040: xargs: Avoid a possible multiplication overflow.
Jul 14 2023, 10:07 PM
jlduran_gmail.com added inline comments to D41023: xargs: Prevent overflow in linelen calculation if nargs is large..
Jul 14 2023, 6:28 PM