User Details
- User Since
- May 30 2017, 11:42 AM (313 w, 1 d)
Sat, May 20
Fri, May 5
Apr 25 2023
Apr 22 2023
It is worth noting that the man pages in this directory are not installed by make install.
Apr 13 2023
GitHub branch/internal pull request: https://github.com/jlduran/freebsd-src/pull/26
Apr 10 2023
GitHub branch/internal pull request: https://github.com/jlduran/freebsd-src/pull/25
Apr 6 2023
I believe that in some cases, complex templates can be created, for example:
outside | +---+---+ fw2 --- fw2 +---+---+ | inside
can be a class named SimplePFSync that you can inherit in your tests. You would need to understand what SimplePFSync does and returns first (as a newcomer), also it will likely reside in some common file somewhere else (as I understand you prefer to see the setup explicitly in the test), but it should allow you to focus on what's being tested. It is a matter of personal preference, of course.
If this is is just a PoC for the discussion in D39420, please ignore. Otherwise, I believe this will need an ObsoleteFiles.inc entry?
The only drawback I can find to python tests is that they run a bit slower (for now [1]), allegedly compensated by reduced development time :-))
Apr 4 2023
Apr 3 2023
- Fix indentation
Tangential question: Should we add some atf-sh tests with the test plan, even if simplistic, for this and some of your previous ifconfig(8) improvements? If you think it's worth the trouble, I'll try to submit them.
Mar 28 2023
Cross-builds on GitHub are failing for macOS, as secure_getenv() does not exist. Should I add it to tools/build/cross-build/include/mac/stdlib.h?
Mar 25 2023
Taken from a truss output:
open("/lib/libcap_dns.so.2",O_RDONLY|O_CLOEXEC|O_VERIFY,066000) ERR#2 'No such file or directory' open("/usr/lib/libcap_dns.so.2",O_RDONLY|O_CLOEXEC|O_VERIFY,066000) ERR#2 'No such file or directory' open("/usr/lib/compat/libcap_dns.so.2",O_RDONLY|O_CLOEXEC|O_VERIFY,066000) ERR#2 'No such file or directory' open("/usr/local/lib/libcap_dns.so.2",O_RDONLY|O_CLOEXEC|O_VERIFY,066000) ERR#2 'No such file or directory' open("/usr/local/lib/compat/pkg/libcap_dns.so.2",O_RDONLY|O_CLOEXEC|O_VERIFY,066000) ERR#2 'No such file or directory' open("/usr/local/lib/perl5/5.30/mach/CORE/libcap_dns.so.2",O_RDONLY|O_CLOEXEC|O_VERIFY,066000) ERR#2 'No such file or directory' open("/usr/local/lib/perl5/5.32/mach/CORE/libcap_dns.so.2",O_RDONLY|O_CLOEXEC|O_VERIFY,066000) ERR#2 'No such file or directory' open("/usr/local/llvm11/lib/libcap_dns.so.2",O_RDONLY|O_CLOEXEC|O_VERIFY,066000) ERR#2 'No such file or directory' open("/usr/local/llvm15/lib/libcap_dns.so.2",O_RDONLY|O_CLOEXEC|O_VERIFY,066000) ERR#2 'No such file or directory' open("/lib/casper/libcap_dns.so.2",O_RDONLY|O_CLOEXEC|O_VERIFY,066000) = 3 (0x3)
After this change, it'll match on the first attempt.
Mar 24 2023
- Move the tests to a separate commit
- Drop style(9) changes
Mar 23 2023
Yes, it’s on https://github.com/jlduran/freebsd-src/commits/ping-fix-20b4130. However, I’d like to clean it up a little. Tomorrow will do. Thank you!
This can now be abandoned. Thank you!
Mar 22 2023
Address issues:
- Move the interrupt handler function onsignal() to main.c. When a SIGINT is received, check to avoid PR 4696, although I was not able to reproduce it. I am currently working on adding tests for interrupts and this will become a test. I suspect cap_gethostbyname2 is not bound to the same threading issues as gethostbyname2 (back when the bug was filed)
- Unify F_NUMERIC and F_HOSTNAME constants, given numeric output is the default, use F_HOSTNAME (-n and -H should be mutually exclusive?)
- Reduce diffs between ping.c and ping6.c whenever possible
Mar 21 2023
Mar 20 2023
Mar 17 2023
- Reset seenint and seeninfo counters for SIGINT and SIGINFO respectively, just like ping6.c
- Do not use D38483 as a parent revision
This revision now gets in the middle of a more important one. Let's abandon it... if there is interest, revisit.
Address suggestions:
- Remove SIGINFO guards
- Remove onint()
Mar 16 2023
- Address comments
- Set D39125 as the parent revision
Sigh, use the right base for the diff.
Mar 15 2023
I was planning on proposing —specifically for GitHub pull requests— to use their own Super-Linter, maybe submitting a mandoc linter as well.
It uses clang-format, however checkstyle9.pl is less aggressive than clang-format (and from a brief test, more accurate!). It also has the advantage that it can be used in almost any development setup. Nice!
Mar 13 2023
Mar 11 2023
Try a different approach.
Given this is the base revision for a number of others, some merge conflicts may arise. At any rate,w2 I have a branch with all the other accepted revisions already rebased just in case.
The code inside pr_retip() is only done here for completeness, as it will be completely removed later on.
Actually, I'll be submitting a separate review, it's a long diff.
I placed the unified code into main.c, as more elements are unified, they'll also be placed in main.c?
I'll wait over the weekend to let these changes soak in, before formally creating the review. But, if you want to take a preliminary look:
https://github.com/jlduran/freebsd-src/tree/ping-interrupts-ping6-unification
Mar 10 2023
Mar 5 2023
Just as a reference, here is OpenBSD's commit:
https://github.com/openbsd/src/commit/0c54afce7b19bf1867acebc6219af5943ce387c3
Mar 3 2023
Amazing!
Mar 1 2023
I like the overall idea, thank you for adding more conf.ds to FreeBSD!
Feb 27 2023
I have also confirmed it is present on 13.2-BETA3.
It is essentially another IPv4 lookup scheme developed by zec@ and luigi@ more info in the 2012 published paper, and the Phabricator review D-29821, designed as an alternative to using ASICs, targeting high-end routers.
I have not been able to test it, maybe olivier@ ?, but I think the idea here is to just mention its existence.
(Intentionally not tagging users/reviewers)
Feb 26 2023
First of all, thank you for taking care of documenting this type of changes!
I believe we almost forgot about DXR, something along the lines that it can be loaded with fib_dxr.ko.
Unfortunately, the best documentation I could find in base is in the code itself (and in the diff before it landed).
Feb 25 2023
Should this file be created under .github, given it is specifically for GitHub contributions, so it does not "pollute" the top-level directory?
Thank you for clarifying!
Nice!
Here are a few basic suggestions.
Thank you!
Feb 24 2023
Now that the fix is in place, just commit the tests.
I have also tested this revision, and it is passing all my tests.
I also agree that this is the simpler approach, since it essentially reverts hlen to being a signed integer again.
If this revision gets accepted, I'll update mine to just submit the tests.
Feb 23 2023
Feb 20 2023
No problem at all. Take all the time needed. I can imagine how things are at the moment. I have also stalled the submission of other, minor fixes planned until the slush curfew is lifted.
Feb 18 2023
Feb 15 2023
Elegant test implementation! I wonder if the Freudians will find it too scatological.
Feb 14 2023
Address suggestions (not sure if this fits the bill).
EDIT: Let me know if adding const to a bunch of required places is preferred.
I'll test locally with a packet containing LSRR options with just a couple of routers + NOP and see the remaining hlen value.
Address suggestions:
- Change the warning message
Address suggestions:
In this first iteration, simply duplicate the code from the final statistics section into SIGINFO's.
- Avoid a potential square root of a negative number calculation (based on an alternative to D38480, this change should not part of this revision)
I have a branch where it unifies the code into a single summary() function, however it changes a lot more of the code that I would like/have tests for at the moment. Besides, the code ends up being almost identical to ping6.c's. Let's leave the unification for later in the ping/ping6 series.
A few cosmetic things discovered from this exercise are:
- ping's SIGINFO prints out to stderr (ping6 to stdout)
- ping/ping6 should just become ping when displayed to the user
- ping uses the expression "somebody's printing up packets!", I prefer ping6's "somebody's duplicating packets!" when a duplicate packet is received
- ping calls the population standard deviation "stddev", while ping6 calls it "std-dev". I'm OK either way, but it should be the same for both
Feb 13 2023
Feb 12 2023
- Remove pr_retip()
Feb 11 2023
Address comments:
- Add single NOP case
- Remove unneeded int cast
- There is no need to decrease hlen, as cp is advancing to the next octet, (single NOP case added as proof). However, let's be pedantic (and true to the original implementation), and decrease it.