Differential D41751

release: remove inet blackhole sysctls from GCE config
ClosedPublic
Actions

Authored by emaste on Sep 6 2023, 12:06 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Aug 31, 9:42 AM

	Unknown Object (File)
	Sun, Aug 30, 6:56 PM

	Unknown Object (File)
	Tue, Aug 25, 5:50 PM

	Unknown Object (File)
	Tue, Aug 25, 3:58 PM

	Unknown Object (File)
	Mon, Aug 17, 12:33 PM

	Unknown Object (File)
	Fri, Aug 14, 2:51 PM

	Unknown Object (File)
	Fri, Aug 14, 3:15 AM

	Unknown Object (File)
	Tue, Aug 11, 6:20 AM

Subscribers

freebsd-transport

Details

Reviewers

swills
jlduran
delphij

Group Reviewers

Commits

rGbebd79e63847: release: remove inet blackhole sysctls from GCE config
rG3284a5929d50: release: remove inet blackhole sysctls from GCE config
rG413687812ba7: release: remove inet blackhole sysctls from GCE config
rG5623352ec005: release: remove inet blackhole sysctls from GCE config
rGb7528b16c603: release: remove inet blackhole sysctls from GCE config

Summary

Other cloud images do not do this, and it can produce confusing results.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.Sep 6 2023, 12:06 AM

Herald added a subscriber: jrtc27. · View Herald TranscriptSep 6 2023, 12:06 AM

See e.g. https://github.com/cirruslabs/cirrus-ci-docs/issues/483 and https://github.com/golang/go/issues/28883

And discussion in https://github.com/python/cpython/pull/91961

Also https://github.com/smol-rs/async-io/issues/110

lwhsu added a subscriber: lwhsu.Sep 6 2023, 8:07 AM

Nice! Thank you!
Also PMTUD problems, UNIX traceroute "not working", the list of issues can be long.
I'll go ahead and disturb @freebsd-transport, to ask if they have something to say against this change.

emaste added a reviewer: jlduran.Sep 6 2023, 2:05 PM

emaste added a subscriber: cperciva.

jlduran accepted this revision.Sep 6 2023, 2:32 PM

This revision is now accepted and ready to land.Sep 6 2023, 2:32 PM

delphij accepted this revision.Sep 6 2023, 4:29 PM

Closed by commit rGb7528b16c603: release: remove inet blackhole sysctls from GCE config (authored by emaste). · Explain WhySep 6 2023, 6:57 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGb7528b16c603: release: remove inet blackhole sysctls from GCE config.

Herald added a subscriber: imp. · View Herald TranscriptSep 6 2023, 6:57 PM

emaste added a commit: rG5623352ec005: release: remove inet blackhole sysctls from GCE config.Sep 8 2023, 8:37 PM

emaste added a commit: rG413687812ba7: release: remove inet blackhole sysctls from GCE config.Sep 9 2023, 3:15 PM

emaste added a commit: rG3284a5929d50: release: remove inet blackhole sysctls from GCE config.

emaste added a commit: rGbebd79e63847: release: remove inet blackhole sysctls from GCE config.Sep 9 2023, 4:56 PM

Revision Contents
Changeset List

Path

Size

release/

tools/

2 lines

Diff 126985

release/tools/gce.conf

Loading...