Page MenuHomeFreeBSD

bsdinstall: Remove unused variables in fetchmissingdists
Needs ReviewPublic

Authored by fernape on Oct 26 2023, 12:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 2:08 AM
Unknown Object (File)
Fri, Apr 19, 11:46 AM
Unknown Object (File)
Wed, Apr 3, 9:24 PM
Unknown Object (File)
Wed, Apr 3, 9:23 PM
Unknown Object (File)
Feb 22 2024, 4:22 AM
Unknown Object (File)
Dec 23 2023, 3:21 AM
Unknown Object (File)
Dec 14 2023, 10:58 AM
Unknown Object (File)
Dec 10 2023, 5:38 PM

Details

Reviewers
None
Group Reviewers
Src Committers
Summary

ALL_DISTRIBUTIONS and VERIFY_MANIFEST_SIG

They are neither used in the script nor exported.
Not referenced anywhere in bsdinstall/*

Test Plan

Apply patch and try to run an installation in a jail.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 54173
Build 51063: arc lint + arc unit

Event Timeline

jlduran_gmail.com added inline comments.
usr.sbin/bsdinstall/scripts/fetchmissingdists
56
78

VERIFY_MANIFEST_SIG looks like the basis of an unimplemented feature, reading the xxx comment below, left over from 40923b0c81cc2c151388ec5ead59f4bed89ac432.

Ping

It seems like your review is being ignored for months. Maybe if you look for who made last changes in these files and ask them directly could help. Or even sending an email to freebsd-current asking for people to take a look here