Page MenuHomeFreeBSD

bsdinstall: Remove unused variables in fetchmissingdists
ClosedPublic

Authored by fernape on Oct 26 2023, 12:19 PM.
Tags
None
Referenced Files
F88230967: D42369.diff
Fri, Jul 12, 7:38 PM
Unknown Object (File)
Thu, Jul 11, 9:31 PM
Unknown Object (File)
Fri, Jul 5, 7:58 AM
Unknown Object (File)
Fri, Jun 28, 12:38 AM
Unknown Object (File)
Sun, Jun 23, 1:29 PM
Unknown Object (File)
Sat, Jun 15, 7:49 PM
Unknown Object (File)
Thu, Jun 13, 6:26 PM
Unknown Object (File)
Jun 3 2024, 1:29 AM

Details

Summary

ALL_DISTRIBUTIONS and VERIFY_MANIFEST_SIG

They are neither used in the script nor exported.
Not referenced anywhere in bsdinstall/*

Test Plan

Apply patch and try to run an installation in a jail.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jlduran_gmail.com added inline comments.
usr.sbin/bsdinstall/scripts/fetchmissingdists
56
78

VERIFY_MANIFEST_SIG looks like the basis of an unimplemented feature, reading the xxx comment below, left over from 40923b0c81cc2c151388ec5ead59f4bed89ac432.

Ping

It seems like your review is being ignored for months. Maybe if you look for who made last changes in these files and ask them directly could help. Or even sending an email to freebsd-current asking for people to take a look here

Since these aren't exported or used anywhere, I think they are safe to remove.

This revision is now accepted and ready to land.May 9 2024, 10:11 PM