Cirrus-CI: let build user run git

[brooks]

Summary

The git checkout it owned by root, but builds are run as "user". git
refuses to operating in such an environment unless the directory is
trusted.

Fixes CI after 99b8c0c35b0fcc633649209621243d678a13542a.

Sponsored by: DARPA

[brooks]

This commit message is a lie in that it only exposes the next problem https://cirrus-ci.com/task/5157804504252416?logs=package#L4435

[emaste]

Maybe worth a comment -- we're collecting quite a bit of magic lore in here.

[jlduran_gmail.com]

https://cirrus-ci.com/task/5157804504252416?logs=setup#L15 states that pkg version is 1.20.8, so @override_prefix is not yet available (starting on 1.20.9):

• Upgrade pkg first (this step can be reverted next quarter):

xxx_upgrade_pkg_script:
- fetch http://pkg.freebsd.org/FreeBSD:13:amd64/latest/All/pkg-1.20.9.pkg
- pkg install -y ./pkg-1.20.9.pkg
- rm -f pkg-1.20.9.pkg

• Use -m in pw useradd, so it creates the /home/user directory with the proper permissions (saves a few steps)
• chown -R user:user $CIRRUS_WORKING_DIR else it's owned by root (however, make sysent will fail unless it is run as user, and check-ldirs, and makeman so those should be wrapped in su user -c as well?)

.cirrus.yml

83

Creates the /home/user directory with the right ownership.

87

[brooks]

Use pw useradd -m

[brooks]

I've chosen to retain the git config change and not do chown of the source tree (only one of them is required). IMO it's useful to test with a read-only tree to since any such write is a bug in the normal build process.

I've also created D42903 with the pkg fix to make it more revertible and plan to commit it with Author: Jose Luis Duran <[e-mail]>

[jlduran_gmail.com]

In D42903#978678, @brooks wrote:

I've chosen to retain the git config change and not do chown of the source tree (only one of them is required). IMO it's useful to test with a read-only tree to since any such write is a bug in the normal build process.

Yes!

I've also created D42903 with the pkg fix to make it more revertible and plan to commit it with Author: Jose Luis Duran <[e-mail]>

Don't worry much about my name/authorship... Thank you!