Page MenuHomeFreeBSD
Differential D41101

amd64 crt1: Explicitly use a PLT entry for main in the PIC case.
ClosedPublic
Actions

Authored by jhb on Jul 19 2023, 6:31 PM.
Tags
None
Referenced Files
F136265189: D41101.id124886.diff
Sun, Nov 16, 10:45 PM
F136192587: D41101.id124884.diff
Sun, Nov 16, 2:34 PM
Unknown Object (File)
Sun, Nov 16, 4:17 AM
Unknown Object (File)
Sun, Nov 2, 6:58 AM
Unknown Object (File)
Thu, Oct 30, 3:22 AM
Unknown Object (File)
Wed, Oct 29, 10:35 AM
Unknown Object (File)
Wed, Oct 29, 9:22 AM
Unknown Object (File)
Wed, Oct 29, 8:58 AM
View All Files
Subscribers
imp
jlduran

Details

Reviewers
kib
dchagin
Commits
rGe5c4737955d5: amd64 crt1: Explicitly use a PLT entry for main in the PIC case.
Summary

This ensures GNU as generates a R_X86_64_PLT32 relocation instead of
R_X86_64_32.

Fixes: c969310c992a csu: Implement _start using as to satisfy unwinders on x86_64

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Jul 19 2023, 6:31 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 19 2023, 6:31 PM
jhb requested review of this revision.Jul 19 2023, 6:31 PM
Harbormaster completed remote builds in B52728: Diff 124884.Jul 19 2023, 6:31 PM
jhb added a comment.Jul 19 2023, 6:32 PM

This fixes linking dynamic binaries again with GCC 12.

kib accepted this revision.Jul 19 2023, 6:40 PM
This revision is now accepted and ready to land.Jul 19 2023, 6:40 PM
Closed by commit rGe5c4737955d5: amd64 crt1: Explicitly use a PLT entry for main in the PIC case. (authored by jhb). · Explain WhyJul 19 2023, 6:54 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGe5c4737955d5: amd64 crt1: Explicitly use a PLT entry for main in the PIC case..
jlduran added a subscriber: jlduran.EditedJul 19 2023, 9:26 PM

Thank you!
I also had to add:

LDFLAGS+=       -Wl,-znoexecstack

to secure/lib/libcrypto/**/**/Makefile.

EDIT: https://github.com/freebsd/freebsd-src/pull/800

jhb added a comment.Jul 20 2023, 5:45 PM
In D41101#935894, @jlduran_gmail.com wrote:

Thank you!
I also had to add:

LDFLAGS+=       -Wl,-znoexecstack

to secure/lib/libcrypto/**/**/Makefile.

EDIT: https://github.com/freebsd/freebsd-src/pull/800

I have a separate review for this: D41102

Revision Contents
Changeset List

PathSize
lib/
csu/
amd64/
7 lines

Diff 124886

View Options

lib/csu/amd64/crt1_s.S

Loading...