Page MenuHomeFreeBSD

adduser: A few more improvements.
ClosedPublic

Authored by des on Apr 19 2024, 4:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 2, 2:15 AM
Unknown Object (File)
Tue, Jul 2, 2:15 AM
Unknown Object (File)
Tue, Jul 2, 2:15 AM
Unknown Object (File)
Tue, Jul 2, 1:59 AM
Unknown Object (File)
Sat, Jun 29, 12:46 AM
Unknown Object (File)
Fri, Jun 28, 6:38 PM
Unknown Object (File)
Tue, Jun 25, 3:58 PM
Unknown Object (File)
Sun, Jun 23, 7:43 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Apr 19 2024, 4:04 PM
In D44871#1023012, @jrm wrote:

Looks good to me.

Then accept it, please.

This revision is now accepted and ready to land.Apr 20 2024, 4:47 PM
This revision was automatically updated to reflect the committed changes.
jlduran_gmail.com added inline comments.
usr.sbin/adduser/adduser.sh
480

Sorry, for the late review, as this is already committed, but I do not understand this change. Wouldn't it throw an error?

usr.sbin/adduser/adduser.sh
480–481

It looks good to me. It's now saying if the zfs kernel module isn't loaded *or* the user opted not to have the zfs home dataset created.

usr.sbin/adduser/adduser.sh
480

Oh, I see what you're saying. The syntax is wrong. The ; then is missing.

usr.sbin/adduser/adduser.sh
480

Precisely! You beat me to it. Thank you!

480–481

I guess, what I meant was, isn't it missing a ; then and indenting with 4 spaces instead of a tab the next line?