Page MenuHomeFreeBSD

GoogleTest 1.14.0: import
ClosedPublic

Authored by ngie on Aug 9 2023, 7:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 1:25 AM
Unknown Object (File)
Tue, Apr 23, 11:48 PM
Unknown Object (File)
Sun, Apr 21, 5:08 AM
Unknown Object (File)
Sat, Apr 6, 4:24 PM
Unknown Object (File)
Mar 31 2024, 8:58 PM
Unknown Object (File)
Mar 31 2024, 8:58 PM
Unknown Object (File)
Mar 31 2024, 8:58 PM
Unknown Object (File)
Mar 31 2024, 8:58 PM

Details

Summary

GoogleTest 1.14.0 now requires C++14 to build. Change googletest.test.inc.mk
to reflect this requirement.

Adjust the build integration logic to handle the new version of
GoogleTest (add/remove headers/sources as needed).

Tighten down warnings via CXXFLAGS.clang instead of ignoring all warnings.
Some new warnings snuck in after I did my last round of fix submissions
upstream.

Also address some overlinking added in the previous version import.

Expect WhenDynamicCastToTest.AmbiguousCast to fail

This change reapplies the expected failure from 1.10.0.

Ref: https://github.com/google/googletest/issues/2172

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ngie requested review of this revision.Aug 9 2023, 7:47 PM
ngie added reviewers: tests, asomers.
ngie edited the summary of this revision. (Show Details)

Looks reasonable

lib/googletest/tests/gtest_main/Makefile
35

what's the story behind this bit?

Add expected failure from 1.10.0

lib/googletest/tests/gtest_main/Makefile
35

what's the story behind this bit?

I was trying to reduce overlinking I added in a previous iteration. gtest_main should link gtest.

ngie edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Aug 9 2023, 8:18 PM

As you might already know, commit 28f6c2f292806bf31230a959bc4b19d7081669a7 broke GCC 12 compilation (https://cirrus-ci.com/task/6695038801936384).
I did the lazy thing and added:

CXXFLAGS.gcc+= -Wno-error

to gmock_main/Makefile and gtest_main/Makefile, but I believe a more granular approach is also desired for GCC.

This revision was automatically updated to reflect the committed changes.