Page MenuHomeFreeBSD

ping tests: Fix test on 32-bit platforms
ClosedPublic

Authored by jlduran on Oct 17 2023, 4:26 PM.
Tags
None
Referenced Files
F150394970: D42268.id128939.diff
Tue, Mar 31, 8:37 PM
Unknown Object (File)
Tue, Mar 31, 3:48 AM
Unknown Object (File)
Mon, Mar 30, 11:01 PM
Unknown Object (File)
Thu, Mar 19, 1:53 AM
Unknown Object (File)
Tue, Mar 17, 1:51 PM
Unknown Object (File)
Tue, Mar 17, 1:42 PM
Unknown Object (File)
Sun, Mar 15, 9:14 PM
Unknown Object (File)
Wed, Mar 4, 11:53 PM

Details

Summary
Actually use INT_MAX (0x7fffffff), not UINT_MAX (0xffffffff) to avoid
overflowing and missing the test.

Reported by:    Jenkins
Test Plan

The idea is to hit the test, not to overflow 32-bit architecture's time_t.
I do not have a 32-bit VM at the moment, would it be possible to run the test on ci.freebsd.org, and verify that test:
https://ci.freebsd.org/view/Test/job/FreeBSD-main-i386-test/17993/testReport/junit/sbin.ping.test_ping/py/TestPing__test_pinger__0_0_special_warp_/
Passes on i386?:

/usr/tests# kyua debug sbin/ping/test_ping.py:TestPing::test_pinger[_0_0_special_warp]

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I do not have a 32-bit VM at the moment, would it be possible to run the test on ci.freebsd.org, and verify that test:

Unfortunately there's no easy way to manually test patches using ci.freebsd.org yet. In the meantime I downloaded an i386 VM image and verified that the test passes.

This revision is now accepted and ready to land.Oct 18 2023, 1:22 PM

I do not have a 32-bit VM at the moment, would it be possible to run the test on ci.freebsd.org, and verify that test:

Unfortunately there's no easy way to manually test patches using ci.freebsd.org yet. In the meantime I downloaded an i386 VM image and verified that the test passes.

Thank you!

Please submit a PR with the patch, or mail git format-patch output to me directly.

This revision was automatically updated to reflect the committed changes.