In D5312#116404, @imp wrote:

This looks ready to go. If you happen to know why MIPS is different, it would be cool if you could address that in the comment. If not, then no big deal. Differences like that will be a mystery later if we don't document what we know today.

Done in https://svnweb.freebsd.org/base?view=revision&revision=296080

Done with https://svnweb.freebsd.org/base?view=revision&revision=296079

Done with https://svnweb.freebsd.org/base?view=revision&revision=296059
I am not sure why this review wasn't closed automatically

Closed by https://svnweb.freebsd.org/doc?view=revision&revision=48255
I am not sure why this review wasn't closed automatically.

Addressed review comments.
I decided to drop sys/boot/common/self_reloc.c changes, as currently self relocation is not supported by the MIPS ubldr.

The actual MIPS ubldr support will come with D5313.

Thanks for the reviews. I've responded to some of the comments and will take care of them and submit a new version.

Re-submit patch as I hadn't imported auto-props.txt when generating the first version.

Cleaned up some leftover issues.

I am not sure whether more reviewers are required?

Will resubmit in a different revision.

Patch updated.

Patch updated.

Patch updated to use sys/sys/intr.h for the common parts between ARM and MIPS.
Also, FDT-related headers are now conditionally included in order to allow MIPS systems that do not support FDT to move to INTRNG should they wish to.

Sorry, I attached the wrong patch... Now with the right one.

Diff updated per Adrian's latest suggestion.

Thanks Adrian, I'll do what you suggest and will submit a new diff.

Would it be possible for someone to look at this change so we can decide if it's ok to go with it or just forget about it?

Made this revision dependent on D5196 only because the diff was created after the diff for D5196, so they may be better applied in the same order if accepted.

Diff updated.

Renamed sys/mips/mips/intr.c to sys/mips/mips/mips_pic.c per Alexander Kabaev's request (sorry, I must have misunderstood what you meant originally).

I've updated the patch, addressing kan's comments. I'll send out a separate review for enabling bus pass on MIPS (together with enabling it for the mips_pic (intr.c) tomorrow. I'll also update the bus_space_fdt removal patch tomorrow.

I meant to talk to you about possibly moving the Atheros SoCs to MIPS24K, but then got distracted with other things :-)
Yeah, I guess we can move the SoCs later. I did that for the Ralink SoCs in sys/mips/ralink for now, will be using the new cpu options with the Ralink/Mediatek FDT stuff too.

After discussion with imp@, removed the CPU_MIPS24KE option, as 24KE is not really different than 24K, apart from having DSP ASE, which can be detected dynamically via Config3 register.

After discussion with imp@, removed the CPU_MIPS24KE option, as 24KE is not really different than 24K, apart from having DSP ASE, which can be detected dynamically via Config3 register.

After discussion with imp@, removed the CPU_MIPS24KE option, as 24KE is not really different than 24K, apart from having DSP ASE, which can be detected dynamically via Config3 register.

Backed out the sys/mips/include/asm.h change as it is probably too risky at the moment.

Updated diff added. Now we use the ncells parameter to return the number of elements in case idx == -1 is passed as a parameter. This allows us to continue to interpret the return value as simply 0 == success and anything else is a failure, while also being the least intrusive (IMHO) option to allow us to be able to get the length of the list.

Please disregard the above patches for now. I'll update and submit a new diff.
The major flaw in the above diffs is that they wrongly assume that the standard error values are negative, which they're not.

Updated diff with more context provided.