Any further comments on this @jrtc27 @andrew?

• Use LDRB for bool arm64_pid_in_contextidr
• Use LDRW for P_PID + add comment
• Remove \label from pid_in_contextidr macro
• Change ASSYM(PR_PID... to P_PID

Move to hypervisor.h

use ADRP to save a load

• Retain both MRS_REG + MRS_REG_ALT_NAME variants

• Added both BSC + FSC to cover both readings of this field

As per review comments

• fix indents and comments

• rename PA_TO_PTE -> PHYS_TO_PTE for symmetry with reverse operation PTE_TO_PHYS
• pmap_kenter: remove unnecessary & ~L3_OFFSET

• rename PTE_TO_PA -> PTE_TO_PHYS
• fix secondary indents + multi-line comments as per man style

In D39828#907120, @andrew wrote:

In D39828#907117, @kib wrote:

What does OE mean? O is perhaps output.

Should be OA for Output address, the field name in the documentation.

In D39828#906959, @kib wrote:

I was initially confused by the macro name and no description. The purpose is to convert a physical address into the output address field of a PTE, not into PTE. At least a comment would be useful, if not a different name.

• add comment

• remove unnecessary brackets