Page MenuHomeFreeBSD

jchandra (Jayachandran C)
User

Projects

User Details

User Since
Feb 17 2015, 10:41 PM (209 w, 3 d)

Recent Activity

Thu, Feb 7

jchandra added a comment to D19097: Add missing pmap dsb instructions.

Tested with overnight 'make -j 224 buildworld' without failures.

How long does that take?

Thu, Feb 7, 9:00 PM
jchandra accepted D19097: Add missing pmap dsb instructions.

This fixes the failure on ThunderX2 when INVARIANTS are turned off. The failure was:

Thu, Feb 7, 6:52 PM
jchandra committed rS343860: pci_host_generic_acpi: use IORT data for MSI/MSI-X.
pci_host_generic_acpi: use IORT data for MSI/MSI-X
Thu, Feb 7, 4:50 AM
jchandra closed D18004: pci_host_generic_acpi: use IORT data for MSI/MSI-X.
Thu, Feb 7, 4:50 AM · ARM
jchandra committed rS343856: arm64 gicv3: add IORT and NUMA support.
arm64 gicv3: add IORT and NUMA support
Thu, Feb 7, 3:02 AM
jchandra closed D18003: arm64 gicv3: add IORT and NUMA support.
Thu, Feb 7, 3:02 AM · ARM
jchandra committed rS343853: arm64 acpi: Add support for IORT table.
arm64 acpi: Add support for IORT table
Thu, Feb 7, 2:30 AM
jchandra closed D18002: arm64 acpi: Add support for IORT table.
Thu, Feb 7, 2:30 AM

Wed, Feb 6

jchandra added inline comments to D19077: uart_dev_pl011: add EARLY_PRINTF support.
Wed, Feb 6, 9:29 PM
jchandra updated the diff for D18004: pci_host_generic_acpi: use IORT data for MSI/MSI-X.
Wed, Feb 6, 3:03 AM · ARM
jchandra planned changes to D18004: pci_host_generic_acpi: use IORT data for MSI/MSI-X.

Will rebase and submit a new rev addressing the comment.

Wed, Feb 6, 1:30 AM · ARM

Tue, Feb 5

jchandra closed D19073: arm, acpi: increase size of memory region arrays.
Tue, Feb 5, 6:25 AM · arm64
jchandra committed rS343764: arm, acpi: increase size of memory region arrays.
arm, acpi: increase size of memory region arrays
Tue, Feb 5, 6:25 AM

Mon, Feb 4

jchandra abandoned D19078: arm64: update early printf support.

Fix the action to match comment above.

Mon, Feb 4, 10:35 PM
jchandra accepted D19078: arm64: update early printf support.
Mon, Feb 4, 10:34 PM
jchandra abandoned D19077: uart_dev_pl011: add EARLY_PRINTF support.

On second thought, for now I think I will drop this until we have a better EARLY_PRINTF

Mon, Feb 4, 10:33 PM
jchandra created D19078: arm64: update early printf support.
Mon, Feb 4, 7:44 PM
jchandra added reviewers for D19077: uart_dev_pl011: add EARLY_PRINTF support: andrew, ARM.
Mon, Feb 4, 7:40 PM
jchandra created D19077: uart_dev_pl011: add EARLY_PRINTF support.
Mon, Feb 4, 7:40 PM
jchandra created D19073: arm, acpi: increase size of memory region arrays.
Mon, Feb 4, 4:14 AM · arm64

Dec 8 2018

jchandra committed rS341744: arm64: add ACPI based NUMA support.
arm64: add ACPI based NUMA support
Dec 8 2018, 7:42 PM
jchandra closed D17943: arm64: add ACPI based NUMA support.
Dec 8 2018, 7:42 PM · arm64
jchandra committed rS341743: acpica: support parsing of arm64 affinity in acpi_pxm.c.
acpica: support parsing of arm64 affinity in acpi_pxm.c
Dec 8 2018, 7:32 PM
jchandra closed D17942: acpica: support parsing of arm64 affinity in acpi_pxm.c.
Dec 8 2018, 7:32 PM
jchandra committed rS341742: acpica : move SRAT/SLIT parsing to sys/dev/acpica.
acpica : move SRAT/SLIT parsing to sys/dev/acpica
Dec 8 2018, 7:11 PM
jchandra closed D17941: acpica : move SRAT/SLIT parsing to sys/dev/acpica.
Dec 8 2018, 7:11 PM
jchandra committed rS341741: x86/acpica/srat.c: Add API for parsing proximity tables.
x86/acpica/srat.c: Add API for parsing proximity tables
Dec 8 2018, 6:34 PM
jchandra closed D17940: x86/acpica/srat.c: Add API for parsing proximity tables.
Dec 8 2018, 6:34 PM · arm64

Dec 5 2018

jchandra added a comment to D17940: x86/acpica/srat.c: Add API for parsing proximity tables.

markj: Regarding the question on pxm prefix. I used the convention starting with the filename. I kind of settled for acpi_pxm since I could not think of a better filename and prefix (which covers SRAT for resource affinity and SLIT for locality).

Dec 5 2018, 7:17 AM · arm64

Dec 4 2018

jchandra added a comment to D17940: x86/acpica/srat.c: Add API for parsing proximity tables.

markj: please see the inline comment, and let me know if think there is further changes needed. Thanks.

Dec 4 2018, 5:38 AM · arm64

Nov 20 2018

jchandra updated the diff for D18002: arm64 acpi: Add support for IORT table.

Few fixes to earlier revision-

  • IORT table walking fixed (not to use acpi_walk_subtables since the header is slightly different)
  • proximity is changed to int, so that we can return -1 when SRAT does not have an entry.
  • return o copy data is changed to void since it returned only 0 - this simplified the code a bit.
Nov 20 2018, 6:23 AM
jchandra planned changes to D18002: arm64 acpi: Add support for IORT table.

New version planned with correct way of walking IORT.

Nov 20 2018, 3:37 AM

Nov 19 2018

jchandra closed D17841: gitv3_its: fixes for multiple GIC ITS blocks.
Nov 19 2018, 3:53 AM
jchandra committed rS340602: gitv3_its: fixes for multiple GIC ITS blocks.
gitv3_its: fixes for multiple GIC ITS blocks
Nov 19 2018, 3:53 AM
jchandra committed rS340601: pci_host_generic : move activate/release to generic code.
pci_host_generic : move activate/release to generic code
Nov 19 2018, 3:43 AM
jchandra closed D17793: pci_host_generic : move activate/release to generic code.
Nov 19 2018, 3:43 AM
jchandra closed D17792: pci_host_generic, acpi_resource: drop unneeded code.
Nov 19 2018, 3:34 AM
jchandra committed rS340600: pci_host_generic, acpi_resource: drop unneeded code.
pci_host_generic, acpi_resource: drop unneeded code
Nov 19 2018, 3:34 AM
jchandra committed rS340599: acpica, pci_host_generic_acpi: redo pci_host_generic_acpi.c.
acpica, pci_host_generic_acpi: redo pci_host_generic_acpi.c
Nov 19 2018, 3:16 AM
jchandra closed D17791: acpica, pci_host_generic_acpi: redo pci_host_generic_acpi.c.
Nov 19 2018, 3:16 AM
jchandra committed rS340598: acpica: rework INTRNG interrupts.
acpica: rework INTRNG interrupts
Nov 19 2018, 3:03 AM
jchandra closed D17790: acpica: rework INTRNG interrupt mapping.
Nov 19 2018, 3:03 AM
jchandra committed rS340597: pci_host_generic*: basic implementation of bus range.
pci_host_generic*: basic implementation of bus range
Nov 19 2018, 2:55 AM
jchandra closed D17657: pci_host_generic*: basic implementation of bus range.
Nov 19 2018, 2:55 AM · ARM
jchandra committed rS340596: pci_host_generic: allocate resources against devices.
pci_host_generic: allocate resources against devices
Nov 19 2018, 2:43 AM
jchandra closed D17656: pci_host_generic: allocate resources against devices.
Nov 19 2018, 2:43 AM · ARM
jchandra committed rS340595: pci_host_generic: remove unneeded ThunderX2 quirk.
pci_host_generic: remove unneeded ThunderX2 quirk
Nov 19 2018, 2:38 AM
jchandra closed D17655: pci_host_generic: remove unneeded ThunderX2 quirk.
Nov 19 2018, 2:38 AM
jchandra updated the diff for D17942: acpica: support parsing of arm64 affinity in acpi_pxm.c.

Addressed markj's comments.

  • use the UID instead of APIC id in prints for arm64
  • the comment on 'max' is already handled in preceding commit
Nov 19 2018, 1:46 AM
jchandra updated the diff for D17941: acpica : move SRAT/SLIT parsing to sys/dev/acpica.

Addressed markj's comment - removed unnecessary includes.

Nov 19 2018, 1:40 AM
jchandra updated the diff for D17940: x86/acpica/srat.c: Add API for parsing proximity tables.

Addressed comments from jhb's review:

  • fixed comment stye & reworded as suggested.
  • removed 'id' field until it is needed (in a later patch)
Nov 19 2018, 1:38 AM · arm64

Nov 16 2018

jchandra created D18004: pci_host_generic_acpi: use IORT data for MSI/MSI-X.
Nov 16 2018, 6:05 AM · ARM
jchandra updated the diff for D18003: arm64 gicv3: add IORT and NUMA support.
Nov 16 2018, 6:03 AM · ARM
jchandra created D18003: arm64 gicv3: add IORT and NUMA support.
Nov 16 2018, 5:50 AM · ARM
jchandra created D18002: arm64 acpi: Add support for IORT table.
Nov 16 2018, 5:48 AM
jchandra planned changes to D17941: acpica : move SRAT/SLIT parsing to sys/dev/acpica.

Thanks for the review - will post new version dropping a few includes.

Nov 16 2018, 1:58 AM
jchandra planned changes to D17940: x86/acpica/srat.c: Add API for parsing proximity tables.

Thanks for the review, will update the diff with the changes (and a fix related use of max).

Nov 16 2018, 1:50 AM · arm64
jchandra planned changes to D17942: acpica: support parsing of arm64 affinity in acpi_pxm.c.

Thanks for the review, will update the diff.

Nov 16 2018, 1:43 AM

Nov 14 2018

jchandra abandoned D17717: pci_host_generic_acpi: use NUMA node when allocating MSI/MSI-X.

Need to take another look at this after handling IORT table parsing.

Nov 14 2018, 6:23 AM · ARM
jchandra abandoned D17716: arm64 acpi: parse proximity domain for CPUs and GIC ITS blocks.

I have submitted another patch for doing NUMA for CPUs similar to x86. This can be dropped.

Nov 14 2018, 6:22 AM · ARM

Nov 11 2018

jchandra created D17943: arm64: add ACPI based NUMA support.
Nov 11 2018, 2:47 AM · arm64
jchandra retitled D17942: acpica: support parsing of arm64 affinity in acpi_pxm.c from acpica: support parsing of arm64 affinity acpi_pxm.c to acpica: support parsing of arm64 affinity in acpi_pxm.c.
Nov 11 2018, 2:42 AM
jchandra added reviewers for D17942: acpica: support parsing of arm64 affinity in acpi_pxm.c: andrew, jhb, arm64.
Nov 11 2018, 2:41 AM
jchandra created D17942: acpica: support parsing of arm64 affinity in acpi_pxm.c.
Nov 11 2018, 2:40 AM
jchandra created D17941: acpica : move SRAT/SLIT parsing to sys/dev/acpica.
Nov 11 2018, 2:37 AM
jchandra created D17940: x86/acpica/srat.c: Add API for parsing proximity tables.
Nov 11 2018, 2:35 AM · arm64

Nov 5 2018

jchandra created D17841: gitv3_its: fixes for multiple GIC ITS blocks.
Nov 5 2018, 8:08 AM

Nov 3 2018

jchandra updated the diff for D17791: acpica, pci_host_generic_acpi: redo pci_host_generic_acpi.c.

Fixed issues noted by andrew.

Nov 3 2018, 1:40 AM
jchandra added inline comments to D17791: acpica, pci_host_generic_acpi: redo pci_host_generic_acpi.c.
Nov 3 2018, 1:02 AM

Nov 1 2018

jchandra created D17793: pci_host_generic : move activate/release to generic code.
Nov 1 2018, 1:36 AM
jchandra added reviewers for D17792: pci_host_generic, acpi_resource: drop unneeded code: arm64, andrew, jhb.
Nov 1 2018, 12:05 AM
jchandra created D17792: pci_host_generic, acpi_resource: drop unneeded code.
Nov 1 2018, 12:04 AM
jchandra created D17791: acpica, pci_host_generic_acpi: redo pci_host_generic_acpi.c.
Nov 1 2018, 12:01 AM

Oct 31 2018

jchandra updated the summary of D17790: acpica: rework INTRNG interrupt mapping.
Oct 31 2018, 11:52 PM
jchandra created D17790: acpica: rework INTRNG interrupt mapping.
Oct 31 2018, 11:52 PM
jchandra abandoned D17659: acpica, pci_host_generic_acpi: redo pci_host_generic_acpi.c.

Had to redo link interrupts - dropping this rev. Will post a commit to fixup link interrupts and a new version of this change to use the new interrupt routing.

Oct 31 2018, 11:33 PM · ARM
jchandra planned changes to D17716: arm64 acpi: parse proximity domain for CPUs and GIC ITS blocks.

Keep on hold until we do ACPI NUMA.

Oct 31 2018, 11:29 PM · ARM
jchandra planned changes to D17717: pci_host_generic_acpi: use NUMA node when allocating MSI/MSI-X.

I will keep this on hold until we do ACPI based NUMA correctly. x86/acpica/srat.c seems to do most of the things we require, along with memory proximity and SLIT parsing - that would be a better starting point.

Oct 31 2018, 11:28 PM · ARM

Oct 29 2018

jchandra added inline comments to D17659: acpica, pci_host_generic_acpi: redo pci_host_generic_acpi.c.
Oct 29 2018, 9:26 PM · ARM
jchandra planned changes to D17659: acpica, pci_host_generic_acpi: redo pci_host_generic_acpi.c.

The legacy interrupt routing part is not correct. I will redo this - that needs some changes in acpica code as well.

Oct 29 2018, 9:24 PM · ARM

Oct 27 2018

jchandra added inline comments to D17717: pci_host_generic_acpi: use NUMA node when allocating MSI/MSI-X.
Oct 27 2018, 10:57 PM · ARM
jchandra added inline comments to D17717: pci_host_generic_acpi: use NUMA node when allocating MSI/MSI-X.
Oct 27 2018, 9:51 PM · ARM

Oct 26 2018

jchandra set the repository for D17716: arm64 acpi: parse proximity domain for CPUs and GIC ITS blocks to rS FreeBSD src repository.
Oct 26 2018, 10:52 PM · ARM
jchandra created D17717: pci_host_generic_acpi: use NUMA node when allocating MSI/MSI-X.
Oct 26 2018, 10:52 PM · ARM
jchandra created D17716: arm64 acpi: parse proximity domain for CPUs and GIC ITS blocks.
Oct 26 2018, 10:49 PM · ARM

Oct 23 2018

jchandra added inline comments to D17657: pci_host_generic*: basic implementation of bus range.
Oct 23 2018, 6:55 PM · ARM
jchandra added a comment to D17655: pci_host_generic: remove unneeded ThunderX2 quirk.

Is there an easy way to tell which revision silicon we have? I'd like to check the TX2 I have access to.

Oct 23 2018, 6:38 PM
jchandra added a reviewer for D17657: pci_host_generic*: basic implementation of bus range: andrew.
Oct 23 2018, 5:55 AM · ARM
jchandra added a reviewer for D17656: pci_host_generic: allocate resources against devices: andrew.
Oct 23 2018, 5:54 AM · ARM
jchandra added a reviewer for D17655: pci_host_generic: remove unneeded ThunderX2 quirk: andrew.
Oct 23 2018, 5:54 AM
jchandra added a reviewer for D17659: acpica, pci_host_generic_acpi: redo pci_host_generic_acpi.c: andrew.
Oct 23 2018, 5:53 AM · ARM

Oct 22 2018

jchandra created D17659: acpica, pci_host_generic_acpi: redo pci_host_generic_acpi.c.
Oct 22 2018, 11:54 PM · ARM
jchandra created D17657: pci_host_generic*: basic implementation of bus range.
Oct 22 2018, 11:47 PM · ARM
jchandra created D17656: pci_host_generic: allocate resources against devices.
Oct 22 2018, 11:41 PM · ARM
jchandra created D17655: pci_host_generic: remove unneeded ThunderX2 quirk.
Oct 22 2018, 11:40 PM

Oct 21 2018

jchandra committed rS339517: arm generic_timer: fix armv8 timer desc.
arm generic_timer: fix armv8 timer desc
Oct 21 2018, 2:12 AM

Feb 27 2017

jchandra added a comment to D9785: reg-io-width option for UART drivers.

I had a different solution of a similar issue for Netlogic XLP. Instead of handling it in UART, I had subclassed the simplebus with a updated implementation of bus_alloc_resource(https://svnweb.freebsd.org/base/head/sys/mips/nlm/xlp_simplebus.c). I provided a different bustag for UART (and other devices) that needed 4-byte access that implementation. The bus implementation took care of reading 4 bytes and extracting and returning the significant byte.

Feb 27 2017, 5:52 PM

Feb 26 2017

jchandra committed rS314318: Enable pl011 UART FIFOs.
Enable pl011 UART FIFOs
Feb 26 2017, 10:05 PM
jchandra closed D8819: Enable FIFO on pl011 uart by committing rS314318: Enable pl011 UART FIFOs.
Feb 26 2017, 10:05 PM

Dec 19 2016

jchandra committed rS310289: Fix whitespace issues in pl011 uart driver.
Fix whitespace issues in pl011 uart driver
Dec 19 2016, 7:40 PM