In D20974#458277, @greg_unrelenting.technology wrote:

In D20974#458088, @emaste wrote:

In D20974#457245, @greg_unrelenting.technology wrote:

Would be nice to test on ThunderX2 :)

Does not attach on ThunderX2 (no sbsawdt0 in dmesg).

oh.. https://www.mail-archive.com/kernel-packages@lists.launchpad.net/msg272248.html

I guess we don't have any more platforms to test..

address andrew's comment.

Fix the check for warning (i > 1 now), fix up error message, and add a comment.

I took a second look at this, and ran some more testing. I need to fix up a bug and add more comments.

In D20416#441876, @andrew wrote:

How frequently is srat_resolve_its_pxm called?

fixes for addressing andrew's not on KABI.

Let me know if you need a new rev with bool.

This fixes https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236333

In D19097#408663, @andrew wrote:

In D19097#408644, @jchandra wrote:

Tested with overnight 'make -j 224 buildworld' without failures.

How long does that take?

This fixes the failure on ThunderX2 when INVARIANTS are turned off. The failure was:

Will rebase and submit a new rev addressing the comment.

Dropping this for now. We need better EARLY_PRINTF support like andrew noted above before adding this.

On second thought, for now I think I will drop this until we have a better EARLY_PRINTF

markj: Regarding the question on pxm prefix. I used the convention starting with the filename. I kind of settled for acpi_pxm since I could not think of a better filename and prefix (which covers SRAT for resource affinity and SLIT for locality).

markj: please see the inline comment, and let me know if think there is further changes needed. Thanks.

Few fixes to earlier revision-

• IORT table walking fixed (not to use acpi_walk_subtables since the header is slightly different)
• proximity is changed to int, so that we can return -1 when SRAT does not have an entry.
• return o copy data is changed to void since it returned only 0 - this simplified the code a bit.

New version planned with correct way of walking IORT.

Addressed markj's comments.

• use the UID instead of APIC id in prints for arm64
• the comment on 'max' is already handled in preceding commit

Addressed markj's comment - removed unnecessary includes.

Addressed comments from jhb's review:

• fixed comment stye & reworded as suggested.
• removed 'id' field until it is needed (in a later patch)