Differential D17942

acpica: support parsing of arm64 affinity in acpi_pxm.c
ClosedPublic
Actions

Authored by jchandra on Nov 11 2018, 2:40 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 25, 5:28 AM

	Unknown Object (File)
	Nov 22 2024, 4:17 PM

	Unknown Object (File)
	Nov 7 2024, 12:27 PM

	Unknown Object (File)
	Oct 27 2024, 3:09 AM

	Unknown Object (File)
	Oct 22 2024, 10:23 PM

	Unknown Object (File)
	Oct 6 2024, 10:50 AM

	Unknown Object (File)
	Oct 6 2024, 2:06 AM

	Unknown Object (File)
	Oct 5 2024, 10:40 PM

View All 65 Files

Subscribers

Details

Reviewers

andrew
jhb
markj

Group Reviewers

Commits

rS352497: MFC r341743-r341744
rS341743: acpica: support parsing of arm64 affinity in acpi_pxm.c

Summary

ACPI SRAT table on arm64 uses GICC entries to provide CPU locality information. These entries uses a AcpiProcessorUid to identify the cpu (unlike on x86 where entries have an APIC ID).

Update acpi_pxm.c to extend the cpus_add/cpus_find/cpus_get_info functions to be able to handle AcpiProcessorUid, and then use it when parsing ACPI_SRAT_GICC_AFFINITY entry for arm64.

Add dev/acpica/acpi_pxm.c to arm64 compilation if acpi is enabled.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jchandra created this revision.Nov 11 2018, 2:40 AM

Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptNov 11 2018, 2:40 AM

Harbormaster completed remote builds in B20748: Diff 50277.Nov 11 2018, 2:40 AM

jchandra added reviewers: andrew, jhb, arm64.Nov 11 2018, 2:41 AM

jchandra retitled this revision from acpica: support parsing of arm64 affinity acpi_pxm.c to acpica: support parsing of arm64 affinity in acpi_pxm.c.

andrew added a reviewer: markj.Nov 13 2018, 10:38 AM

markj added inline comments.Nov 15 2018, 10:26 PM

sys/dev/acpica/acpi_pxm.c
247 ↗	(On Diff #50277)	It doesn't really matter here, but this should be imin().
316 ↗	(On Diff #50277)	"APIC ID" looks like the wrong term.

Thanks for the review, will update the diff.

sys/dev/acpica/acpi_pxm.c
247 ↗	(On Diff #50277)	This is a bug (had the Linux behavior in mind) - I should use imax() here.
316 ↗	(On Diff #50277)	Yes, will fix.

Addressed markj's comments.

use the UID instead of APIC id in prints for arm64
the comment on 'max' is already handled in preceding commit

Also fixed one issue - in arm64 cpu_add was checking last_cpu limit incorrectly.

Harbormaster completed remote builds in B20884: Diff 50579.Nov 19 2018, 1:46 AM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 8 2018, 7:32 PM

Closed by commit rS341743: acpica: support parsing of arm64 affinity in acpi_pxm.c (authored by jchandra). · Explain Why

This revision was automatically updated to reflect the committed changes.

jchandra added a commit: rS352497: MFC r341743-r341744.Sep 18 2019, 10:55 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

conf/

1 line

dev/

acpica/

64 lines

Diff 51764

head/sys/conf/files.arm64

Loading...

head/sys/dev/acpica/acpi_pxm.c

Loading...