Differential D17657

pci_host_generic*: basic implementation of bus range
ClosedPublic
Actions

Authored by jchandra on Oct 22 2018, 11:47 PM.

Details

Reviewers

andrew

Group Reviewers

arm64

Commits

rS340597: pci_host_generic*: basic implementation of bus range

Summary

Both ACPI and FDT support bus ranges for pci host bridges. Add a
default implementation for now. This is no intention to introduce
any functional difference with this change. This will be used in the
next set of changes for ACPI based host bridge.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jchandra created this revision.Oct 22 2018, 11:47 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 22 2018, 11:47 PM

Harbormaster completed remote builds in B20344: Diff 49477.Oct 22 2018, 11:47 PM

jchandra added a reviewer: andrew.Oct 23 2018, 5:55 AM

andrew added inline comments.Oct 23 2018, 9:14 AM

sys/dev/pci/pci_host_generic_acpi.c
140–141 ↗	(On Diff #49477)	Are these numbers defined anywhere?

jchandra marked an inline comment as done.Oct 23 2018, 6:55 PM

jchandra added inline comments.

sys/dev/pci/pci_host_generic_acpi.c
140–141 ↗	(On Diff #49477)	The ACPI code here tried to make 2 PCI domains - one for bus 0-7f and one for 0x80-0xff. In this commit I have not changed this mechanism - just trying to save the value instead of making ACPI call multiple times. In https://reviews.freebsd.org/D17659 I have redone this part. The domain should come from the _SEG call and the bus range should be from bus resource specified in the ACPI resources. So basically, this commit is just to add bus_start, no functional changes. The next commit does the change in implementation.