Page MenuHomeFreeBSD
Differential D20416

acpi_iort: add some error handling
ClosedPublic
Actions

Authored by jchandra on May 26 2019, 11:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 10:43 AM
Unknown Object (File)
Sat, Sep 27, 11:58 AM
Unknown Object (File)
Fri, Sep 26, 3:55 AM
Unknown Object (File)
Sun, Sep 21, 8:50 PM
Unknown Object (File)
Wed, Sep 17, 4:33 PM
Unknown Object (File)
Sat, Sep 13, 6:23 AM
Unknown Object (File)
Sep 9 2025, 4:01 AM
Unknown Object (File)
Aug 15 2025, 8:01 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
andrew
manu
Group Reviewers
arm64
Commits
rS352500: MFC r349348:
rS349348: arm64 acpi_iort: add some error handling
Summary

Print warnings for bad kernel configuration (NUMA disabled with multiple domains) and for firmware errors (incorrect proximity domain entries).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jchandra created this revision.May 26 2019, 11:31 PM
Herald added a reviewer: manu. · View Herald TranscriptMay 26 2019, 11:31 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
Harbormaster completed remote builds in B24520: Diff 57926.May 26 2019, 11:31 PM
andrew added a comment.May 30 2019, 9:28 AM

How frequently is srat_resolve_its_pxm called?

jchandra added a comment.May 30 2019, 5:51 PM
In D20416#441876, @andrew wrote:

How frequently is srat_resolve_its_pxm called?

The SRAT has affinity entries for each memory segment, CPU and ITS block. Comes upto ~260 entries on my ThunderX2. We go into the main logic of srat_resolve_its_pxm() only for ITS blocks (2 entries).

jchandra planned changes to this revision.May 30 2019, 11:15 PM

I took a second look at this, and ran some more testing. I need to fix up a bug and add more comments.

Will update this diff.

jchandra updated this revision to Diff 58101.May 31 2019, 3:44 AM

Fix the check for warning (i > 1 now), fix up error message, and add a comment.

Harbormaster completed remote builds in B24617: Diff 58101.May 31 2019, 3:44 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 24 2019, 9:25 PM
Closed by commit rS349348: arm64 acpi_iort: add some error handling (authored by jchandra). · Explain Why
This revision was automatically updated to reflect the committed changes.
jchandra added a commit: rS349348: arm64 acpi_iort: add some error handling.
jchandra added a commit: rS352500: MFC r349348:.Sep 18 2019, 11:18 PM

Revision Contents
Changeset List

PathSize
head/
sys/
arm64/
acpica/
34 lines

Diff 58969

View Options

head/sys/arm64/acpica/acpi_iort.c

Loading...