Page MenuHomeFreeBSD

gpio: remove redundant calls to bus_attach_children
ClosedPublic

Authored by vexeduxr on Jul 1 2025, 2:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 7, 2:10 AM
Unknown Object (File)
Wed, Nov 5, 11:06 PM
Unknown Object (File)
Fri, Oct 31, 7:19 AM
Unknown Object (File)
Wed, Oct 29, 10:04 AM
Unknown Object (File)
Wed, Oct 29, 9:54 AM
Unknown Object (File)
Tue, Oct 14, 11:49 AM
Unknown Object (File)
Tue, Oct 14, 11:49 AM
Unknown Object (File)
Tue, Oct 14, 11:49 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Strictly speaking, they are not entirely useless. A multi-function device can expose multiple different buses, so it can add another child when gpiobus_attach_bus() is called. In an ideal world, we should have an explicit bus_attach_children() function at the end of each respective driver (especially if it exposes multiple functions).
However, this is only a theoretical notice , nothing more.

This revision is now accepted and ready to land.Jul 2 2025, 11:20 AM

Revert the max77620 and as3722 changes. They are handled differently.

This revision now requires review to proceed.Jul 2 2025, 3:53 PM

We could create a version gpiobus_attach_bus that doesn't call bus_attach_children for use by multi-function devices. That would mean all buses are added together for more control.

This revision is now accepted and ready to land.Jul 2 2025, 4:45 PM

This looks good. No need to hold things up for Andy's suggestion, but I think I like it for future consideration.