Page MenuHomeFreeBSD

hyperv/vmbus: Add APIs for various types of transactions.
ClosedPublic

Authored by sepherosa_gmail.com on Aug 10 2016, 3:31 AM.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sepherosa_gmail.com retitled this revision from to hyperv/vmbus: Add APIs for various types of transactions..
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sys/dev/hyperv/vmbus/vmbus_xact.c
63 ↗(On Diff #19173)

Suggest to put FLAGS into the name to make it more explicit.

77 ↗(On Diff #19173)

this can be moved after dma alloc.

272 ↗(On Diff #19173)

can we make resp0 as a stack variable?

sys/dev/hyperv/vmbus/vmbus_xact.c
63 ↗(On Diff #19173)

It's also a common practice to use YYY'F', if the macro name is getting too long.

77 ↗(On Diff #19173)

I don't see why it matters.

272 ↗(On Diff #19173)

No, you can't. These API do not assume response size.

This revision was automatically updated to reflect the committed changes.