Differential D7456

hyperv/vmbus: Add APIs for various types of transactions.
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Aug 10 2016, 3:31 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jun 24, 11:27 PM

	Unknown Object (File)
	Mon, Jun 22, 5:55 PM

	Unknown Object (File)
	Sun, Jun 21, 10:08 PM

	Unknown Object (File)
	Tue, Jun 16, 1:30 AM

	Unknown Object (File)
	May 19 2026, 9:57 PM

	Unknown Object (File)
	May 18 2026, 4:04 PM

	Unknown Object (File)
	May 18 2026, 12:37 AM

	Unknown Object (File)
	May 17 2026, 7:59 PM

Subscribers

None

Details

Reviewers

howard0su_gmail.com
honzhan_microsoft.com
decui_microsoft.com
delphij
royger

Commits

rS303947: hyperv/vmbus: Add APIs for various types of transactions.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sepherosa_gmail.com updated this revision to Diff 19173.Aug 10 2016, 3:31 AM

sepherosa_gmail.com retitled this revision from to hyperv/vmbus: Add APIs for various types of transactions..

sepherosa_gmail.com updated this object.

sepherosa_gmail.com edited the test plan for this revision. (Show Details)

sepherosa_gmail.com added reviewers: delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.

howard0su_gmail.com added inline comments.Aug 10 2016, 4:03 AM

sys/dev/hyperv/vmbus/vmbus_xact.c
63 ↗	(On Diff #19173)	Suggest to put FLAGS into the name to make it more explicit.
77 ↗	(On Diff #19173)	this can be moved after dma alloc.
272 ↗	(On Diff #19173)	can we make resp0 as a stack variable?

sepherosa_gmail.com added inline comments.Aug 10 2016, 5:00 AM

sys/dev/hyperv/vmbus/vmbus_xact.c
63 ↗	(On Diff #19173)	It's also a common practice to use YYY'F', if the macro name is getting too long.
77 ↗	(On Diff #19173)	I don't see why it matters.
272 ↗	(On Diff #19173)	No, you can't. These API do not assume response size.

Closed by commit rS303947: hyperv/vmbus: Add APIs for various types of transactions. (authored by sephe). · Explain WhyAug 11 2016, 5:50 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

conf/

1 line

1 line

dev/

hyperv/

include/

54 lines

vmbus/

278 lines

modules/

hyperv/

vmbus/

3 lines

Diff 19196

head/sys/conf/files.amd64

Loading...

head/sys/conf/files.i386

Loading...

head/sys/dev/hyperv/include/vmbus_xact.h

Loading...

head/sys/dev/hyperv/vmbus/vmbus_xact.c

Loading...

head/sys/modules/hyperv/vmbus/Makefile

Loading...