Page MenuHomeFreeBSD
Differential D7456

hyperv/vmbus: Add APIs for various types of transactions.
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Aug 10 2016, 3:31 AM.
Tags
None
Referenced Files
F156987321: D7456.id19196.diff
Sun, May 17, 7:59 PM
F156920995: D7456.id19173.diff
Sun, May 17, 9:11 AM
Unknown Object (File)
Fri, May 15, 8:39 AM
Unknown Object (File)
Mon, May 11, 1:55 PM
Unknown Object (File)
Mon, May 11, 1:53 PM
Unknown Object (File)
Tue, Apr 28, 5:16 AM
Unknown Object (File)
Sun, Apr 26, 10:23 PM
Unknown Object (File)
Sun, Apr 26, 6:49 PM
View All Files
Subscribers
None

Details

Reviewers
howard0su_gmail.com
honzhan_microsoft.com
decui_microsoft.com
delphij
royger
Commits
rS303947: hyperv/vmbus: Add APIs for various types of transactions.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sepherosa_gmail.com updated this revision to Diff 19173.Aug 10 2016, 3:31 AM
sepherosa_gmail.com retitled this revision from to hyperv/vmbus: Add APIs for various types of transactions..
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sepherosa_gmail.com added reviewers: delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
howard0su_gmail.com added inline comments.Aug 10 2016, 4:03 AM
sys/dev/hyperv/vmbus/vmbus_xact.c
63

Suggest to put FLAGS into the name to make it more explicit.

77

this can be moved after dma alloc.

272

can we make resp0 as a stack variable?

sepherosa_gmail.com added inline comments.Aug 10 2016, 5:00 AM
sys/dev/hyperv/vmbus/vmbus_xact.c
63

It's also a common practice to use YYY'F', if the macro name is getting too long.

77

I don't see why it matters.

272

No, you can't. These API do not assume response size.

Closed by commit rS303947: hyperv/vmbus: Add APIs for various types of transactions. (authored by sephe). · Explain WhyAug 11 2016, 5:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
conf/
1 line
1 line
dev/
hyperv/
include/
54 lines
vmbus/
278 lines
modules/
hyperv/
vmbus/
3 lines

Diff 19173

View Options

sys/conf/files.amd64

Loading...
View Options

sys/conf/files.i386

Loading...
View Options

sys/dev/hyperv/include/vmbus_xact.h

Loading...
View Options

sys/dev/hyperv/vmbus/vmbus_xact.c

Loading...
View Options

sys/modules/hyperv/vmbus/Makefile

Loading...