Differential D7756

pxeboot: add nfs.read_size tunable
ClosedPublic
Actions

Authored by howard0su_gmail.com on Sep 2 2016, 7:10 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 21, 7:57 PM

	Unknown Object (File)
	Wed, Nov 6, 12:30 AM

	Unknown Object (File)
	Oct 24 2024, 1:29 AM

	Unknown Object (File)
	Oct 11 2024, 12:51 PM

	Unknown Object (File)
	Oct 2 2024, 10:19 AM

	Unknown Object (File)
	Oct 1 2024, 1:30 PM

	Unknown Object (File)
	Oct 1 2024, 10:13 AM

	Unknown Object (File)
	Sep 24 2024, 6:09 AM

View All 80 Files

Subscribers

Contributor Reviews (src)

Details

Reviewers

Group Reviewers

Commits

rS305588: pxeboot: Add nfs.read_size tunable.

Summary

Increase the read size results better boot performance.

Test Plan

tested with virtual machine

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

howard0su_gmail.com updated this revision to Diff 19974.Sep 2 2016, 7:10 AM

howard0su_gmail.com retitled this revision from to pxeboot: add nfs.read_size tunable.

howard0su_gmail.com updated this object.

howard0su_gmail.com edited the test plan for this revision. (Show Details)

Herald added a reviewer: manpages. · View Herald TranscriptSep 2 2016, 7:10 AM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript

rpokala added a subscriber: rpokala.Sep 2 2016, 2:23 PM

rpokala added inline comments.

sys/boot/i386/pxeldr/pxeboot.8
83 ↗	(On Diff #19974)	Please move this down, after the next paragraph. That way, all the references to DHCP configuration are together, and all the references to loader are together.

wblock added a subscriber: wblock.Sep 2 2016, 9:39 PM

wblock added inline comments.

sys/boot/i386/pxeldr/pxeboot.8
76 ↗	(On Diff #19974)	Please start new sentences on new lines.
83 ↗	(On Diff #19974)	Slight rewording: Valid values range from 1024 to 4096 bytes.

Address comments on man page

Herald edited edge metadata. · View Herald TranscriptSep 3 2016, 2:21 PM

Update

Herald edited edge metadata. · View Herald TranscriptSep 3 2016, 2:24 PM

updated a new revision to address comments.

rpokala accepted this revision.Sep 4 2016, 4:53 AM

rpokala added a reviewer: rpokala.

This revision is now accepted and ready to land.Sep 4 2016, 4:53 AM

Closed by commit rS305588: pxeboot: Add nfs.read_size tunable. (authored by sephe). · Explain WhySep 8 2016, 9:11 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libstand/

33 lines

sys/

boot/

i386/

pxeldr/

8 lines

Diff 20190

head/lib/libstand/nfs.c

Loading...

head/sys/boot/i386/pxeldr/pxeboot.8

Loading...