Page MenuHomeFreeBSD
Differential D5922

usb: malloc with M_WAITOK never returns NULL
Needs ReviewPublic
Actions

Authored by howard0su_gmail.com on Apr 12 2016, 12:43 AM.
Tags
None
Referenced Files
F173360037: D5922.id15093.diff
Fri, Sep 25, 10:52 AM
F173348482: D5922.diff
Fri, Sep 25, 9:20 AM
Unknown Object (File)
Tue, Sep 22, 3:25 AM
Unknown Object (File)
Mon, Sep 21, 11:07 AM
Unknown Object (File)
Aug 21 2026, 11:17 PM
Unknown Object (File)
Aug 13 2026, 8:04 PM
Unknown Object (File)
Aug 11 2026, 11:21 AM
Unknown Object (File)
Aug 8 2026, 4:45 PM
View All Files
Subscribers
imp
Contributor Reviews (src)
This revision needs review, but all specified reviewers are disabled or inactive.

Details

Reviewers
• hselasky

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3225
Build 3258: arc lint + arc unit

Event Timeline

howard0su_gmail.com updated this revision to Diff 15093.Apr 12 2016, 12:43 AM
howard0su_gmail.com retitled this revision from to usb: malloc with M_WAITOK never returns NULL.
howard0su_gmail.com updated this object.
howard0su_gmail.com edited the test plan for this revision. (Show Details)
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptApr 12 2016, 12:43 AM
howard0su_gmail.com added a reviewer: • hselasky.Apr 12 2016, 2:23 PM
• hselasky edited edge metadata.Apr 12 2016, 3:00 PM

Hi,

In the USB core M_NOWAIT should be used, and NULL checks should be preserved. The NULL checks are active for embedded products (non-FreeBSD) where the malloc implementation does not support M_WAITOK.

--HPS

howard0su_gmail.com added a comment.Apr 12 2016, 3:33 PM
In D5922#126253, @hselasky wrote:

Hi,

In the USB core M_NOWAIT should be used, and NULL checks should be preserved. The NULL checks are active for embedded products (non-FreeBSD) where the malloc implementation does not support M_WAITOK.

--HPS

So all M_WAITOK should be replaced with M_NOWAIT?

• hselasky added a comment.Apr 13 2016, 6:55 AM

Where there are NULL checks M_NOWAIT is the correct option for malloc(). Else use M_WAITOK.

--HPS

• hselasky added a comment.Jan 23 2020, 2:26 PM

Can you rebase this patch?

Revision Contents
Changeset List

PathSize
sys/
dev/
usb/
input/
8 lines
net/
4 lines
serial/
3 lines
storage/
4 lines
15 lines
11 lines
5 lines
3 lines
7 lines

Diff 15093

View Options

sys/dev/usb/input/uhid.c

Loading...
View Options

sys/dev/usb/net/if_kue.c

Loading...
View Options

sys/dev/usb/serial/ufoma.c

Loading...
View Options

sys/dev/usb/storage/ustorage_fs.c

Loading...
View Options

sys/dev/usb/usb_dev.c

Loading...
View Options

sys/dev/usb/usb_device.c

Loading...
View Options

sys/dev/usb/usb_generic.c

Loading...
View Options

sys/dev/usb/usb_mbuf.c

Loading...
View Options

sys/dev/usb/usb_transfer.c

Loading...