Differential D5922

usb: malloc with M_WAITOK never returns NULL
Needs ReviewPublic
Actions

Authored by howard0su_gmail.com on Apr 12 2016, 12:43 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 28, 1:07 AM

	Unknown Object (File)
	Tue, Jan 28, 1:02 AM

	Unknown Object (File)
	Nov 20 2024, 3:45 PM

	Unknown Object (File)
	Nov 11 2024, 12:57 AM

	Unknown Object (File)
	Oct 31 2024, 8:00 PM

	Unknown Object (File)
	Sep 26 2024, 6:08 AM

	Unknown Object (File)
	Sep 25 2024, 2:23 PM

	Unknown Object (File)
	Sep 25 2024, 8:46 AM

View All 68 Files

Subscribers

Contributor Reviews (src)

This revision needs review, but all specified reviewers are disabled or inactive.

Details

Reviewers

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3225
Build 3258: arc lint + arc unit

Event Timeline

howard0su_gmail.com updated this revision to Diff 15093.Apr 12 2016, 12:43 AM

howard0su_gmail.com retitled this revision from to usb: malloc with M_WAITOK never returns NULL.

howard0su_gmail.com updated this object.

howard0su_gmail.com edited the test plan for this revision. (Show Details)

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptApr 12 2016, 12:43 AM

howard0su_gmail.com added a reviewer: • hselasky.Apr 12 2016, 2:23 PM

Hi,

In the USB core M_NOWAIT should be used, and NULL checks should be preserved. The NULL checks are active for embedded products (non-FreeBSD) where the malloc implementation does not support M_WAITOK.

--HPS

In D5922#126253, @hselasky wrote:

Hi,

In the USB core M_NOWAIT should be used, and NULL checks should be preserved. The NULL checks are active for embedded products (non-FreeBSD) where the malloc implementation does not support M_WAITOK.

--HPS

So all M_WAITOK should be replaced with M_NOWAIT?

Where there are NULL checks M_NOWAIT is the correct option for malloc(). Else use M_WAITOK.

--HPS

Can you rebase this patch?

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

input/

8 lines

net/

4 lines

serial/

3 lines

storage/

4 lines

15 lines

11 lines

5 lines

3 lines

7 lines

Diff 15093

sys/dev/usb/input/uhid.c

Loading...

sys/dev/usb/net/if_kue.c

Loading...

sys/dev/usb/serial/ufoma.c

Loading...

sys/dev/usb/storage/ustorage_fs.c

Loading...

sys/dev/usb/usb_dev.c

Loading...

sys/dev/usb/usb_device.c

Loading...

sys/dev/usb/usb_generic.c

Loading...

sys/dev/usb/usb_mbuf.c

Loading...

sys/dev/usb/usb_transfer.c

Loading...