Page MenuHomeFreeBSD

usb: malloc with M_WAITOK never returns NULL
Needs ReviewPublic

Authored by howard0su_gmail.com on Apr 12 2016, 12:43 AM.

Details

Reviewers
hselasky

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 3225
Build 3258: arc lint + arc unit

Event Timeline

howard0su_gmail.com retitled this revision from to usb: malloc with M_WAITOK never returns NULL.
howard0su_gmail.com updated this object.
howard0su_gmail.com edited the test plan for this revision. (Show Details)

Hi,

In the USB core M_NOWAIT should be used, and NULL checks should be preserved. The NULL checks are active for embedded products (non-FreeBSD) where the malloc implementation does not support M_WAITOK.

--HPS

Hi,

In the USB core M_NOWAIT should be used, and NULL checks should be preserved. The NULL checks are active for embedded products (non-FreeBSD) where the malloc implementation does not support M_WAITOK.

--HPS

So all M_WAITOK should be replaced with M_NOWAIT?

Where there are NULL checks M_NOWAIT is the correct option for malloc(). Else use M_WAITOK.

--HPS