Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5030 Build 5104: arc lint + arc unit
Event Timeline
Looks good. Still a lot of repeated code though :( You up for some deduplication?
If not, this is fine as it is, modulo Rui's comments.
sys/boot/sparc64/loader/Makefile | ||
---|---|---|
99–103 | These are replicated in all the Makefiles. .if ${MK_FORTH} != "no" ???? |
The changes here looks like all duplication inside MK_FORTH. but other files like arm, pc98 contains different code inside MK_FORTH code block. I feel it is not worth to make even bigger change to save #if #endif here.
For you reference:
pc98/loader/Makefile
.if ${MK_FORTH} != "no"
.PATH: ${.CURDIR}/../../forth
.include "${.CURDIR}/../../forth/Makefile.inc"
FILES+= ${.CURDIR}/../../i386/loader/loader.rc menu.rc
.endif
The changes here looks like all duplication inside MK_FORTH. but other files like arm, pc98 contains different code inside MK_FORTH code block. I feel it is not worth to make even bigger change to save #if #endif here.
For you reference:
pc98/loader/Makefile
.if ${MK_FORTH} != "no"
.PATH: ${.CURDIR}/../../forth
.include "${.CURDIR}/../../forth/Makefile.inc"
FILES+= ${.CURDIR}/../../i386/loader/loader.rc menu.rc
.endif