Page MenuHomeFreeBSD

hyperv/vmbus: Redefine SynIC message.
ClosedPublic

Authored by sepherosa_gmail.com on May 30 2016, 1:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 29, 4:32 PM
Unknown Object (File)
Tue, Aug 25, 9:58 AM
Unknown Object (File)
Sat, Aug 15, 3:53 AM
Unknown Object (File)
Sat, Aug 15, 3:53 AM
Unknown Object (File)
Sat, Aug 15, 3:52 AM
Unknown Object (File)
Sat, Aug 8, 7:48 PM
Unknown Object (File)
Sat, Aug 8, 1:42 PM
Unknown Object (File)
Fri, Aug 7, 8:23 AM
Subscribers
None

Details

Summary
  • Avoid unnecessary indirection.
  • Avoid bit fields.
  • Use __packed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com retitled this revision from to hyperv/vmbus: Redefine SynIC message..
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c
131 โ†—(On Diff #17085)

volatile is not needed here since msg pointer will not change out of this context.

sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c
131 โ†—(On Diff #17085)

It will be updated by the host, so we need to make sure that compiler don't over-optimize the msg accessing.

This revision was automatically updated to reflect the committed changes.