Page MenuHomeFreeBSD

hyperv/vmbus: Redefine SynIC message.
ClosedPublic

Authored by sepherosa_gmail.com on May 30 2016, 1:39 AM.
Tags
None
Referenced Files
F153394713: D6636.diff
Mon, Apr 20, 10:00 PM
Unknown Object (File)
Sat, Apr 18, 8:12 PM
Unknown Object (File)
Sat, Apr 18, 1:45 PM
Unknown Object (File)
Wed, Apr 8, 4:03 PM
Unknown Object (File)
Mon, Apr 6, 8:15 PM
Unknown Object (File)
Mon, Apr 6, 7:02 AM
Unknown Object (File)
Sun, Apr 5, 9:11 AM
Unknown Object (File)
Sat, Apr 4, 1:31 AM
Subscribers
None

Details

Summary
  • Avoid unnecessary indirection.
  • Avoid bit fields.
  • Use __packed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com retitled this revision from to hyperv/vmbus: Redefine SynIC message..
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c
131 โ†—(On Diff #17085)

volatile is not needed here since msg pointer will not change out of this context.

sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c
131 โ†—(On Diff #17085)

It will be updated by the host, so we need to make sure that compiler don't over-optimize the msg accessing.

This revision was automatically updated to reflect the committed changes.