Page MenuHomeFreeBSD

hyperv/vmbus: Redefine SynIC message.
ClosedPublic

Authored by sepherosa_gmail.com on May 30 2016, 1:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 30, 12:18 PM
Unknown Object (File)
Sun, Mar 29, 8:53 PM
Unknown Object (File)
Tue, Mar 17, 8:11 PM
Unknown Object (File)
Tue, Mar 17, 12:26 AM
Unknown Object (File)
Tue, Mar 17, 12:07 AM
Unknown Object (File)
Sat, Mar 14, 2:33 PM
Unknown Object (File)
Thu, Mar 12, 10:02 PM
Unknown Object (File)
Tue, Mar 10, 11:43 AM
Subscribers
None

Details

Summary
  • Avoid unnecessary indirection.
  • Avoid bit fields.
  • Use __packed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com retitled this revision from to hyperv/vmbus: Redefine SynIC message..
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c
131 โ†—(On Diff #17085)

volatile is not needed here since msg pointer will not change out of this context.

sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c
131 โ†—(On Diff #17085)

It will be updated by the host, so we need to make sure that compiler don't over-optimize the msg accessing.

This revision was automatically updated to reflect the committed changes.