Page MenuHomeFreeBSD

hyperv/vmbus: Redefine SynIC message.
ClosedPublic

Authored by sepherosa_gmail.com on May 30 2016, 1:39 AM.
Tags
None
Referenced Files
F135533485: D6636.diff
Mon, Nov 10, 2:50 PM
Unknown Object (File)
Sat, Nov 8, 2:49 PM
Unknown Object (File)
Thu, Nov 6, 12:42 PM
Unknown Object (File)
Wed, Nov 5, 7:28 AM
Unknown Object (File)
Mon, Nov 3, 4:56 AM
Unknown Object (File)
Wed, Oct 29, 5:33 PM
Unknown Object (File)
Wed, Oct 29, 5:33 PM
Unknown Object (File)
Wed, Oct 29, 5:33 PM
Subscribers
None

Details

Summary
  • Avoid unnecessary indirection.
  • Avoid bit fields.
  • Use __packed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com retitled this revision from to hyperv/vmbus: Redefine SynIC message..
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c
131 โ†—(On Diff #17085)

volatile is not needed here since msg pointer will not change out of this context.

sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c
131 โ†—(On Diff #17085)

It will be updated by the host, so we need to make sure that compiler don't over-optimize the msg accessing.

This revision was automatically updated to reflect the committed changes.