Page MenuHomeFreeBSD
Differential D6636

hyperv/vmbus: Redefine SynIC message.
ClosedPublic
Actions

Authored by sepherosa_gmail.com on May 30 2016, 1:39 AM.
Tags
None
Referenced Files
F137808305: D6636.diff
Wed, Nov 26, 12:27 AM
Unknown Object (File)
Fri, Nov 21, 3:09 AM
Unknown Object (File)
Fri, Nov 21, 3:04 AM
Unknown Object (File)
Fri, Nov 21, 3:03 AM
Unknown Object (File)
Fri, Nov 21, 3:01 AM
Unknown Object (File)
Thu, Nov 20, 5:34 AM
Unknown Object (File)
Mon, Nov 10, 2:50 PM
Unknown Object (File)
Sat, Nov 8, 2:49 PM
View All Files
Subscribers
None

Details

Reviewers
howard0su_gmail.com
honzhan_microsoft.com
decui_microsoft.com
delphij
royger
Commits
rS301019: hyperv/vmbus: Redefine SynIC message.
Summary
  • Avoid unnecessary indirection.
  • Avoid bit fields.
  • Use __packed.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sepherosa_gmail.com updated this revision to Diff 17085.May 30 2016, 1:39 AM
sepherosa_gmail.com retitled this revision from to hyperv/vmbus: Redefine SynIC message..
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sepherosa_gmail.com added reviewers: delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
howard0su_gmail.com added inline comments.May 30 2016, 12:34 PM
sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c
131

volatile is not needed here since msg pointer will not change out of this context.

sepherosa_gmail.com added inline comments.May 30 2016, 12:53 PM
sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c
131

It will be updated by the host, so we need to make sure that compiler don't over-optimize the msg accessing.

Closed by commit rS301019: hyperv/vmbus: Redefine SynIC message. (authored by sephe). · Explain WhyMay 31 2016, 5:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
hyperv/
vmbus/
45 lines
35 lines
56 lines

Diff 17085

View Options

sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c

Loading...
View Options

sys/dev/hyperv/vmbus/hv_vmbus_priv.h

Loading...
View Options

sys/dev/hyperv/vmbus/vmbus_reg.h

Loading...