tests/netgraph: Inital framework for testing libnetgraph

[donner]

Summary

Provide a framework of functions to test various netgraph modules.
Tests contain:

• creating, renaming, and destroying nodes
• connecting and removing hooks
• sending and receiving data
• sending ASCII messages
• errors can be passed for individual inspection or fail the test
• determine the queue limit for unprocessed packets

Test Plan

$ kyua test
basic:message  ->  passed  [0.005s]
basic:node  ->  passed  [0.113s]
basic:queuelimit  ->  expected_failure: Queue full (320): 1 checks failed as expected; see output for more details  [3.167s]
basic:same_name  ->  passed  [0.005s]
basic:send_recv  ->  passed  [0.057s]
...

[donner]

• Fix names and spacing

[donner]

• Add test for queue limit

[kp]

Minor issue: these tests don't carry the metadata to show they must be run as root, so 'kyua test' fails.

[afedorov]

tests/sys/netgraph/basic.c

17

Do you have any objection to using the two-clause version of the BSD license?

[donner]

tests/sys/netgraph/basic.c

17

Any reasoning?

$ fgrep -lR BSD-3-Clause /usr/include/ | wc -l
     445
$ fgrep -lR BSD-2-Clause /usr/include/ | wc -l
     621

[donner]

In D30629#688115, @kp wrote:

Minor issue: these tests don't carry the metadata to show they must be run as root, so 'kyua test' fails.

Thanks, will add this.

[donner]

• Add root requirements to the tests

[kp]

tests/sys/netgraph/util.c

148

Nit: that { wants to be on the next line.

228

Nit: that { wants to be on the next line.