Page MenuHomeFreeBSD

arm64: add snd_hda to GENERIC
Needs ReviewPublic

Authored by emaste on Jun 2 2021, 7:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 16 2024, 5:22 PM
Unknown Object (File)
Jan 27 2024, 4:44 PM
Unknown Object (File)
Dec 22 2023, 11:22 PM
Unknown Object (File)
Dec 10 2023, 10:41 PM
Unknown Object (File)
Nov 30 2023, 3:28 PM
Unknown Object (File)
Sep 10 2023, 4:28 AM
Unknown Object (File)
Sep 6 2023, 7:47 AM
Unknown Object (File)
Aug 14 2023, 10:16 PM
Subscribers

Details

Reviewers
freebsd_darkain.com
andrew
manu
dch
Group Reviewers
arm64
Summary
It is used by Parallels Desktop on Apple M1 Macs.

Also reformat other sound entries to match amd64 / add details.

PR:             256204
Reported by:    Vincent Milum Jr
MFC after:      1 week
Sponsored by:   The FreeBSD Foundation

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Jun 2 2021, 7:46 PM
manu requested changes to this revision.Jun 2 2021, 7:56 PM

Isn't the module enough ?
Why should we had some intel audio driver into arm64 GENERIC when the only possible ways to have this is either using "Parallels Desktop on Apple M1 Macs" or plugins some compatible pci card into a random board ?
We have a module for this, that should be enough.

This revision now requires changes to proceed.Jun 2 2021, 7:56 PM

This will "just work" out of the box on x86, we should have parity on arm64.

I prefer having sound loaded as a module in fact, but until we have module autoloading by PCI ID this should be available in GENERIC.

I prefer having sound loaded as a module in fact, but until we have module autoloading by PCI ID this should be available in GENERIC.

As I understand it, this is a task for devmatch(8) and MODULE_PNP_INFO(9). snd_hda should be changed to add PNP_INFO support, like this: https://reviews.freebsd.org/D15996#change-lBKZ4iN90pMD