Add bhyve uart raw tcp backend
Needs ReviewPublic
Actions

Authored by aokblast on Wed, May 8, 12:26 PM.

Details

Reviewers

lwhsu
corvink
markj
bz

Group Reviewers

bhyve

Summary

This is a updated patch from this old patch according to the modification from markj on uart part of bhyve.

This patch add raw tcp connection ability on bhyve and has been tested on my own machine.

An example about this is as following:

bhyve -c 2 -m 4G -w -H \
                                       -s 0,hostbridge \
                                       -s 1,virtio-blk,./FreeBSD-14.0-STABLE-amd64-20240118-cef433d3fb38-266364.raw \
                                       -s 30,xhci,tablet \
                                       -s 31,lpc -l com1,tcp=127.0.0.1:8085 \
                                       -l bootrom,/usr/local/share/uefi-firmware/BHYVE_UEFI.fd \
                                        uefivm

Then we can use nc by:

netcat 127.0.0.1 8085

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 57916
Build 54804: arc lint + arc unit

Event Timeline

aokblast created this revision.Wed, May 8, 12:26 PM

Herald added a reviewer: bhyve. · View Herald TranscriptWed, May 8, 12:26 PM

Herald added subscribers: bcran, jonathan, rgrimes, imp. · View Herald Transcript

aokblast requested review of this revision.Wed, May 8, 12:26 PM

Harbormaster completed remote builds in B57612: Diff 138237.Wed, May 8, 12:26 PM

aokblast edited the summary of this revision. (Show Details)Wed, May 8, 12:28 PM

aokblast added reviewers: lwhsu, corvink, markj.

aokblast retitled this revision from Add bhyve uart tcp backend to Add bhyve uart raw tcp backend.

aokblast edited the summary of this revision. (Show Details)Wed, May 8, 12:31 PM

afedorov added a subscriber: afedorov.Wed, May 8, 1:15 PM

lwhsu mentioned this in D43514: Add Bhyve TCP raw socket on console.Wed, May 8, 1:37 PM

emaste added a subscriber: emaste.Wed, May 8, 1:56 PM

corvink added inline comments.Mon, May 13, 7:06 AM

usr.sbin/bhyve/uart_backend.c
339	Shouldn't we lock sc->mtx here?

lwhsu added inline comments.Wed, May 15, 1:07 PM

usr.sbin/bhyve/bhyve.8
1134	`tcp=` ?

bz requested changes to this revision.Wed, May 15, 4:54 PM

bz added a subscriber: bz.

bz added inline comments.

usr.sbin/bhyve/uart_backend.c
303	This won't take an IPv6 address?

This revision now requires changes to proceed.Wed, May 15, 4:54 PM

afedorov added inline comments.Thu, May 16, 6:28 PM

usr.sbin/bhyve/uart_backend.c
335	It's better to use C-style comments.
343	I think we should close the descriptor here to avoid leakage.

Add bhyve uart tcp backend
Add manual page

Harbormaster completed remote builds in B57915: Diff 139082.Sat, May 25, 1:52 PM

I fix the previous error previously mentioned, and because uart_tcp_disconnect is a helper function and it parent has already lock it. I add comment to let everyone use this function in the future know this.