Page MenuHomeFreeBSD

[if_vtnet] Add VIRTIO_NET_F_MTU flag support.
AbandonedPublic

Authored by afedorov on Mar 6 2020, 3:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 11 2024, 7:40 AM
Unknown Object (File)
Dec 23 2023, 11:41 AM
Unknown Object (File)
Dec 5 2023, 4:12 PM
Unknown Object (File)
Nov 27 2023, 2:17 AM
Unknown Object (File)
Nov 22 2023, 7:57 AM
Unknown Object (File)
Nov 13 2023, 4:06 AM
Unknown Object (File)
Nov 12 2023, 10:17 PM
Unknown Object (File)
Nov 11 2023, 5:50 PM
Subscribers
None

Details

Reviewers
vmaffione
bryanv
jhb
rgrimes
krion
Group Reviewers
network
Summary

This feature adds support for MTU host advice.

See details in https://reviews.freebsd.org/D23971

Test Plan

I tested this patch using bhyve + D23971

vmrun.sh -c 4 -m 4G -t tap1001,mtu=2000 -t tap1002,mtu=3000 -d fbsd-1.img freebsd-afedorov-1

root@fbsd-1:~ # ifconfig 
vtnet0: flags=8963<UP,BROADCAST,RUNNING,PROMISC,SIMPLEX,MULTICAST> metric 0 mtu 2000
        options=80028<VLAN_MTU,JUMBO_MTU,LINKSTATE>
        ether 00:a0:98:9e:d6:42
        inet 10.78.67.248 netmask 0xffffff00 broadcast 10.78.67.255
        media: Ethernet 10Gbase-T <full-duplex>
        status: active
        nd6 options=29<PERFORMNUD,IFDISABLED,AUTO_LINKLOCAL>
vtnet1: flags=8922<BROADCAST,PROMISC,SIMPLEX,MULTICAST> metric 0 mtu 3000
        options=80028<VLAN_MTU,JUMBO_MTU,LINKSTATE>
        ether 00:a0:98:de:5e:93
        media: Ethernet 10Gbase-T <full-duplex>
        status: active
        nd6 options=29<PERFORMNUD,IFDISABLED,AUTO_LINKLOCAL>
lo0: flags=8049<UP,LOOPBACK,RUNNING,MULTICAST> metric 0 mtu 16384
        options=680003<RXCSUM,TXCSUM,LINKSTATE,RXCSUM_IPV6,TXCSUM_IPV6>
        inet6 ::1 prefixlen 128
        inet6 fe80::1%lo0 prefixlen 64 scopeid 0x3
        inet 127.0.0.1 netmask 0xff000000
        groups: lo
        nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I have added support for this feature (and more) in my VirtIO V1 branch that I plan on committing soon.

Oh, I'm glad to hear that. May you comment on support from Bhyve side?

This revision is now accepted and ready to land.Mar 6 2020, 7:06 PM

I'll defer to bryanv@ on whether this should be committed now or wait for the V1 patch.

sys/dev/virtio/network/if_vtnet.c
986

Nit: s/intial/initial/

This is done in FreeBSD 13.