Page MenuHomeFreeBSD

mmc: Add mmc-pwrseq driver
ClosedPublic

Authored by manu on May 16 2021, 3:13 PM.

Details

Summary

This driver is used to power up sdio card or eMMC.
It handle the reset-gpio, clocks and needed delays for powerup/powerdown.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

manu requested review of this revision.May 16 2021, 3:13 PM
andrew added inline comments.
sys/dev/mmc/mmc_pwrseq.c
151

What are the units for post_power_on_delay and power_off_delay? They seem to be different if for former has * 1000 but not the latter.

sys/dev/mmc/mmc_pwrseq.c
151

ms and us respectively as noted in the binding names, I'll append the unit in the variable too so it's more clear.

Add units to the variable name.
While here fix getting the power_off one.

afedorov added inline comments.
sys/dev/mmc/mmc_pwrseq.c
1

SPDX-License-Identifier?

This revision was not accepted when it landed; it landed in state Needs Review.May 21 2021, 4:04 PM
This revision was automatically updated to reflect the committed changes.