Page MenuHomeFreeBSD
Differential D30288

mmc: Add mmc-pwrseq driver
ClosedPublic
Actions

Authored by manu on May 16 2021, 3:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 11:48 PM
Unknown Object (File)
Fri, Dec 6, 2:45 PM
Unknown Object (File)
Nov 19 2024, 7:03 PM
Unknown Object (File)
Oct 2 2024, 5:07 PM
Unknown Object (File)
Oct 2 2024, 3:02 PM
Unknown Object (File)
Oct 2 2024, 1:56 PM
Unknown Object (File)
Oct 1 2024, 6:59 AM
Unknown Object (File)
Sep 27 2024, 12:19 PM
View All 68 Files
Subscribers
afedorov
andrew
loos

Details

Reviewers
None
Group Reviewers
ARM
arm64
Commits
rGd35cbeb4b1e6: mmc: Add mmc-pwrseq driver
rG5b2a81f58dc7: mmc: Add mmc-pwrseq driver
Summary

This driver is used to power up sdio card or eMMC.
It handle the reset-gpio, clocks and needed delays for powerup/powerdown.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

manu created this revision.May 16 2021, 3:13 PM
Herald added a subscriber: loos. · View Herald TranscriptMay 16 2021, 3:13 PM
manu requested review of this revision.May 16 2021, 3:13 PM
andrew added a subscriber: andrew.May 17 2021, 11:07 AM
andrew added inline comments.
sys/dev/mmc/mmc_pwrseq.c
152

What are the units for post_power_on_delay and power_off_delay? They seem to be different if for former has * 1000 but not the latter.

manu added inline comments.May 18 2021, 8:28 AM
sys/dev/mmc/mmc_pwrseq.c
152

ms and us respectively as noted in the binding names, I'll append the unit in the variable too so it's more clear.

manu updated this revision to Diff 89397.May 18 2021, 9:21 AM

Add units to the variable name.
While here fix getting the power_off one.

afedorov added a subscriber: afedorov.May 18 2021, 9:47 AM
afedorov added inline comments.
sys/dev/mmc/mmc_pwrseq.c
1

SPDX-License-Identifier?

This revision was not accepted when it landed; it landed in state Needs Review.May 21 2021, 4:04 PM
Closed by commit rG5b2a81f58dc7: mmc: Add mmc-pwrseq driver (authored by manu). · Explain Why
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG5b2a81f58dc7: mmc: Add mmc-pwrseq driver.
manu added a commit: rGd35cbeb4b1e6: mmc: Add mmc-pwrseq driver.Jul 22 2021, 5:17 PM

Revision Contents
Changeset List

PathSize
sys/
conf/
2 lines
dev/
mmc/
192 lines
38 lines

Diff 89397

View Options

sys/conf/files

Loading...
View Options

sys/dev/mmc/mmc_pwrseq.c

Loading...
View Options

sys/dev/mmc/mmc_pwrseq_if.m

Loading...