Page MenuHomeFreeBSD

Update net-p2p/bitmark to version 0.13.3
ClosedPublic

Authored by hsw_bitmark.com on Wed, Jul 14, 9:35 AM.

Details

Summary

A new version is available

Test Plan

poudriere testport -j 13_0-amd64 net-p2p/bitmark

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Hello @hsw_bitmark.com, I'm not doing FreeBSD stuff anymore, all my bits are taking into safekeeping.
The update seems fine but would be good for someone else to take a look at it.

This revision is now accepted and ready to land.Thu, Jul 15, 3:11 AM
jrm added a subscriber: jrm.

Looks good.

Some things to consider.

  • portclippy/portfmt have a few suggestions
  • It would be good at some point to modernize to option helpers. For example (untested, see the Porter's Handbook section on Option Helpers)
.if ${PORT_OPTIONS:MRECORDER}
 USERS+=		bitmark-recorder
 GROUPS+=	bitmark-recorder
 RECORDERD_RUN=	${VAR_DIR}/run/recorderd
 RECORDERD_DATA=	${VAR_DIR}/lib/recorderd
 SERVER_LIST+=	recorderd
 USE_RC_SUBR+=	recorderd
 SUB_LIST+=	RECORDERD_DATA=${RECORDERD_DATA} \
		RECORDERD_GROUP=bitmark-recorder \
		RECORDERD_RUN=${RECORDERD_RUN} \
		RECORDERD_USER=bitmark-recorder
.endif

could be (before .include <bsd.port.options.mk>)

RECORDER_SUBLIST=	RECORDERD_DATA=${RECORDERD_DATA} \
			RECORDERD_GROUP=bitmark-recorder \
			RECORDERD_RUN=${RECORDERD_RUN} \
			RECORDERD_USER=bitmark-recorder
RECORDER_VARS=		USERS+=bitmark-recorder \
			GROUPS+=bitmark-recorder \
			RECORDERD_RUN=${VAR_DIR}/run/recorderd \
			RECORDERD_DATA=${VAR_DIR}/lib/recorderd \
			SERVER_LIST+=recorderd \
			USE_RC_SUBR+=recorderd

Let us know if you would like to make those changes. If you would prefer to wait, let me know and I can commit as is.

modernise options and sort variables using portclippy

This revision now requires review to proceed.Thu, Jul 22, 9:50 AM

here is the portlint output:

# portlint -C -M PORTSDIR=/home/toor/ports        
make: "/home/toor/ports/Mk/bsd.port.mk" line 1219: warning: "It is strongly recommanded to upgrade to a newer vertion of pkg first"
make: "/home/toor/ports/Mk/bsd.port.mk" line 1219: warning: "It is strongly recommanded to upgrade to a newer vertion of pkg first"
make: "/home/toor/ports/Mk/bsd.port.mk" line 1219: warning: "It is strongly recommanded to upgrade to a newer vertion of pkg first"
make: "/home/toor/ports/Mk/bsd.port.mk" line 1219: warning: "It is strongly recommanded to upgrade to a newer vertion of pkg first"
make: "/home/toor/ports/Mk/bsd.port.mk" line 1219: warning: "It is strongly recommanded to upgrade to a newer vertion of pkg first"
make: "/home/toor/ports/Mk/bsd.port.mk" line 1219: warning: "It is strongly recommanded to upgrade to a newer vertion of pkg first"
make: "/home/toor/ports/Mk/bsd.port.mk" line 1219: warning: "It is strongly recommanded to upgrade to a newer vertion of pkg first"
WARN: Makefile: possible use of absolute pathname "/var".
WARN: Makefile: unless this is a master port, COMMENT has to be set by "=", not by "?=".
make: "/usr/local/poudriere/ports/default/Mk/bsd.port.mk" line 1219: warning: "It is strongly recommanded to upgrade to a newer vertion of pkg first"
0 fatal errors and 2 warnings found.

One question @jrm I still have conditional blocks for PLIST_FILES should I move to ops_VARS ?

One question @jrm I still have conditional blocks for PLIST_FILES should I move to ops_VARS ?

You could. I have some proposed changes that includes this, silences the portclippy/portfmt warnings, fixes a problem with SUB_LIST, and fixes a build error when no options are selected. Mind if I update the revision here? If you prefer I can create a diff elsewhere.

please update here, I appreciate any assistance you can give.

net-p2p/bitmark: Modernize and pet portclippy/portfmt

Sorry. Just realized that there is a problem with the slave ports. Will fix this.

net-p2p/bitmark-*: Fix plist and conflict issues

Simplify the error check for no options (suggested by ashish@)

I'm not aware of any problems now and ashish@ reviewed the port. I tested in 11,12,13 jails.

I'll commit this tomorrow unless there are any objections.

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Jul 28, 5:00 PM
This revision was automatically updated to reflect the committed changes.