Page MenuHomeFreeBSD

x11-fm/filerunner : Update MAINTAINER
ClosedPublic

Authored by dmgk on Oct 16 2019, 1:45 AM.

Details

Summary
x11-fm/filerunner : Update MAINTAINER

- Pass maintainership to the submitter

PR:		241285
Submitted by:	Chris Hutchinson <portmaster@bsdforge.com>
Test Plan

poudriere testport: OK (113a, 120a)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dmgk created this revision.Oct 16 2019, 1:45 AM
araujo requested changes to this revision.Oct 16 2019, 9:13 AM

You don't need the gratuitous PORTREVISION bump here!

This revision now requires changes to proceed.Oct 16 2019, 9:13 AM
tz added a comment.Oct 16 2019, 9:56 AM

You don't need the gratuitous PORTREVISION bump here!

araujo is right. For a more detailed explanation: setting or increasing the PORTREVISION will trigger a rebuild of the package. A rebuild is needed if the content of the package changes or its dependencies. Like adding a patch whichout chancing the version or like when a lib used for compiling got an update.

If the change to the port does not change the build binary no PORTREVISION is needed. Typical changes of MAINTAINER, COMMENT or pkg-desc are such changes.

dmgk updated this revision to Diff 63353.Oct 16 2019, 12:08 PM

Don't bump PORTREVISION.

araujo accepted this revision.Oct 16 2019, 12:20 PM

For record only, accepting it from Fukushima, Japan!

This revision is now accepted and ready to land.Oct 16 2019, 12:20 PM
dmgk added a comment.Oct 16 2019, 12:56 PM

The PHB seems to say otherwise:

PORTREVISION must be increased each time a change is made to the port that changes the generated package in any way.

Changing MAINTAINER does change package metadata (and the generated package as a consequence) and according to the above, needs a PORTREVISION bump. But looking at the svn logs, nobody deems this change "important enough" to warrant a rebuild :)

This revision was automatically updated to reflect the committed changes.
In D22051#481744, @dmgk wrote:

The PHB seems to say otherwise:

PORTREVISION must be increased each time a change is made to the port that changes the generated package in any way.

Changing MAINTAINER does change package metadata (and the generated package as a consequence) and according to the above, needs a PORTREVISION bump. But looking at the svn logs, nobody deems this change "important enough" to warrant a rebuild :)

I think your interpretation is wrong, I and everybody else don't want build a port or install a new version only because a maintainer variable changed in the Makefile. We never did that and we'll never do. The section that describes the PORTREVISION on PHB gives room for developers to decide when it is necessary to build a new package and I can assure maintainer metadata is not one of them.

tz added a comment.Oct 16 2019, 4:12 PM

I see, i shouldn't have written "changed package". Like araujo stated, meta-data are not considered as part of the package. PORTREVISION bumps will rebuild the software from which the package is build. As long as the software contained (!) in the "package" does not change, such a bump is not needed.

Consider this from the scope of the user. Do you want to reinstall thousands of packages because in pkg-desc we changed a typo? The user (normally) does not care about such thinks when managing its software. Such a reinstall can trigger a very expensive process, can span many servers and can need many hours of qa. Changing the maintainer should not trigger such a process.