Expose ip6?_var.h kernel decls to sysunit tests
AbandonedPublic
Actions

Authored by rstone on Jan 25 2022, 9:36 PM.

Details

Reviewers

vangyzen
imp

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44095
Build 40983: arc lint + arc unit

Event Timeline

rstone created this revision.Jan 25 2022, 9:36 PM

Herald added subscribers: glebius, melifaro, bz and 2 others. · View Herald TranscriptJan 25 2022, 9:36 PM

rstone requested review of this revision.Jan 25 2022, 9:36 PM

Harbormaster completed remote builds in B44095: Diff 101927.Jan 25 2022, 9:36 PM

imp accepted this revision.Jan 25 2022, 10:03 PM

This revision is now accepted and ready to land.Jan 25 2022, 10:03 PM

Can you please provide more context? Why do we need this? Do we need to go around all of the includes and substitute _KERNEL to "_KERNEL || KERNEL_UT"? Why can't the unit tests just define _KERNEL instead?

In D34038#769853, @glebius wrote:

Can you please provide more context? Why do we need this? Do we need to go around all of the includes and substitute _KERNEL to "_KERNEL || KERNEL_UT"? Why can't the unit tests just define _KERNEL instead?

Ryan gave more context in D34034, which is another in this series of similar reviews.

sys/netinet6/ip6_var.h
259–261	You could remove this `#endif / #if` pair.

glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.