Page MenuHomeFreeBSD

networkUmbrella
ActivePublic

Recent Activity

Wed, Nov 18

mw closed D27120: Update ENA driver version to v2.3.0.
Wed, Nov 18, 3:25 PM · network
mw closed D27119: Rename descriptions of the supported ENA devices.
Wed, Nov 18, 3:20 PM · network
mw closed D27118: Add ENI metrics for the ENA driver.
Wed, Nov 18, 3:18 PM · network
mw closed D27117: Add SPDX license tag to the ENA driver files.
Wed, Nov 18, 3:08 PM · network
mw closed D27116: Add Rx offsets support for the ENA driver.
Wed, Nov 18, 3:02 PM · network
mw closed D27115: Upgrade ENA HAL and driver accordingly.
Wed, Nov 18, 2:59 PM · network
mw closed D27114: Fix completion descriptors alignment for the ENA.
Wed, Nov 18, 2:50 PM · network

Fri, Nov 6

mk_semihalf.com requested review of D27120: Update ENA driver version to v2.3.0.
Fri, Nov 6, 1:36 PM · network
mk_semihalf.com requested review of D27119: Rename descriptions of the supported ENA devices.
Fri, Nov 6, 1:35 PM · network
mk_semihalf.com requested review of D27118: Add ENI metrics for the ENA driver.
Fri, Nov 6, 1:34 PM · network
mk_semihalf.com requested review of D27117: Add SPDX license tag to the ENA driver files.
Fri, Nov 6, 1:33 PM · network
mk_semihalf.com requested review of D27116: Add Rx offsets support for the ENA driver.
Fri, Nov 6, 1:31 PM · network
mk_semihalf.com requested review of D27115: Upgrade ENA HAL and driver accordingly.
Fri, Nov 6, 1:31 PM · network
mk_semihalf.com requested review of D27114: Fix completion descriptors alignment for the ENA.
Fri, Nov 6, 1:29 PM · network

Sat, Oct 31

bz added a reviewer for D26489: IP address parsing in netgraph eating too many characters: network.
Sat, Oct 31, 7:25 PM · network

Oct 21 2020

melifaro closed D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..
Oct 21 2020, 9:28 PM · network
lutz_donnerhacke.de added inline comments to D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..
Oct 21 2020, 3:25 PM · network
lutz_donnerhacke.de added a comment to D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

May I point you to D22076, which deals with vlan stacking, too.
And may I point you to D24179, which removes a show stopper for vlan stacking on Intel devices.

Oct 21 2020, 3:22 PM · network

Oct 20 2020

freebsd_oprs.eu updated the diff for D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

Ah, I should have anticipated that. It's done, thank you.

Oct 20 2020, 7:12 PM · network
melifaro added a comment to D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

I'm going to commit this tomorrow, October 21 unless there are any objections.

Oct 20 2020, 6:33 PM · network
melifaro added a reviewer for D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q).: network.
Oct 20 2020, 6:27 PM · network
freebsd_oprs.eu updated the diff for D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

This revision implements the test plan above as a proper set of ATF(7)/KYUA(1) test cases.
It also addresses the small nit in if_vlan.c (lowercase "802.1q" for consistency).

Oct 20 2020, 5:21 PM · network

Oct 19 2020

freebsd_oprs.eu added a comment to D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

That's great news, thanks ! I'm currently catching up on Kyua & the ATF; I'll push some tests today.

Oct 19 2020, 10:08 AM · network

Oct 17 2020

melifaro accepted D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

I'll just slip in a small cosmetic update while I still can (MT_LAMBDA becomes MT_FILTER).

To summarize:

  • This patch adds support for stacked VLANs. It supports both 802.1Q over 802.1ad, and legacy 802.1Q over 802.1Q.
  • Since we now need to differentiate between IEEE 802.1Q "customer VLANs" and IEEE 802.1ad "service VLANs", two options were explored:
    1. The OpenBSD-style svlan interface naming scheme, where a "svlan" prefix in the interface name denotes an IEEE 802.1ad VLAN, while a "vlan" prefix denotes an IEEE 802.1Q VLAN. This option was implemented in diff #77589.
    2. A new vlanproto <vlan_proto> option to ifconfig, allowing users to explicitly set the VLAN encapsulation protocol on interface creation (possible values for vlan_proto: "802.1Q" and "802.1ad", case insensitive). Presumably what users from other obediences (i.e. the Linux crowd) may be most familiar with.

Both options are based on similar kernel-side mods and do behave well. Now the question is: which one shall we go with ?

Personal opinion: I have a marginal preference for option #1. The implementation is slightly more straightforward, and I like the fact that the choice, as presented to users, pertains more to the nature of the VLAN than to a mere property of it. This is just a gut feeling though. I'd be happy with either.

Thank you all for your time and comments.

Thank you for working on this!

Oct 17 2020, 2:37 PM · network
hsw_bitmark.com added inline comments to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Oct 17 2020, 9:18 AM · network
kib added inline comments to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Oct 17 2020, 8:18 AM · network

Oct 12 2020

neel_neelc.org abandoned D24989: netinet: Generate a random RSS key on boot..
Oct 12 2020, 10:40 PM · csprng, network
neel_neelc.org abandoned D23737: nat64: Get the IPv4 address from a NAT64 address when comparing addresses in a ICMP translate.
Oct 12 2020, 10:39 PM · network

Oct 11 2020

neel_neelc.org abandoned D23794: nat64lsn: When allocating, check if we already allocated pg in nat64lsn_alloc_pg().
Oct 11 2020, 10:30 PM · network

Oct 4 2020

freebsd_oprs.eu updated the diff for D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

I'll just slip in a small cosmetic update while I still can (MT_LAMBDA becomes MT_FILTER).

Oct 4 2020, 2:38 PM · network
cy added a member for network: cy.
Oct 4 2020, 3:59 AM

Sep 28 2020

freebsd_oprs.eu added inline comments to D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..
Sep 28 2020, 7:56 AM · network
freebsd_oprs.eu updated the diff for D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

This updated revision implements the alternative solution discussed earlier. I've updated the test plan to account for the new parameter-based syntax, so I will not dwell on that here, but in a nutshell:

ifconfig svlan5 create vlandev em0 vlan 5 up
ifconfig vlan42 create vlandev svlan5 vlan 42 inet 10.5.42.1/24

becomes

ifconfig vlan5 create vlandev em0 vlan 5 vlanproto 802.1ad up
ifconfig vlan42 create vlandev vlan5 vlan 42 inet 10.5.42.1/24

Dot notation is supported, as long as everyone agrees that any interface with a dot in its name is a VLAN.

Sep 28 2020, 7:38 AM · network
freebsd_oprs.eu updated the diff for D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

This is mostly a cosmetic update. It fixes the small issues (typos, etc...) raised in the previous revision. The idea is to have a clean base to compare the (upcoming) alternative implementation to.

Sep 28 2020, 7:20 AM · network

Sep 21 2020

hselasky closed D26488: Add additional example to ng_bpf(4).
Sep 21 2020, 6:17 PM · network
bcr accepted D26488: Add additional example to ng_bpf(4).

Also good from manpages (again).

Sep 21 2020, 3:38 PM · network
hselasky accepted D26488: Add additional example to ng_bpf(4).

Looks good to me.

Sep 21 2020, 9:46 AM · network
pi accepted D26488: Add additional example to ng_bpf(4).
Sep 21 2020, 5:11 AM · network

Sep 20 2020

melifaro added a comment to D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

Re "vlan"/"svlan" naming - I don't have extremely strong opinion on this, but it would be nice if we could still consider using the same name for both. "Svlan" looks a bit like low-level implementation detail somehow leaked to the upper layers.

For example, it can be implemented in the following fashion:
ifconfig vlan5 create vlan 5 vlandev em0 vlanproto 802.1ad <-- svlan
ifconfig vlan5.25 create vlan 5 vlandev vlan5 <-- 8021.q on top of 802.1ad
ifconfig em0.5 create vlanproto 802.1ad <-- svlan

Do you think it would be more confusing for users?

Thanks for bringing up this issue again. This is really the user-facing part, so it does requires special care; in fact, I think it would be great if more people voiced their opinion about it.
As for me, I don't really have a strong opinion on this neither, I like both options. Yours definitely sounds more explicit though, so let's try that too.

I'll update this differential revision and create another one, implementing your proposed solution. This way we can easily compare both approaches, and hopefully decide which feels better/more natural from a user's standpoint.
I hope it's OK to do that, otherwise please let me know.

I don't have major concerns on the kernel implementation part, it's not worth doing for the sake of comparison. I guess description of both approaches is enough, :-)
I would suggest considering looking into what UI other major players have implemented. For example, looking at Linux implementation from the OS side and Cisco/Juniper from the NOS side could potentially provide enough datapoints to make a data-driven decision on what's the preferred UI should be.

Sep 20 2020, 8:19 PM · network
markus_stoffdv.at updated the diff for D26488: Add additional example to ng_bpf(4).
In D26488#589662, @pi wrote:

The change is fine, with or without removing awk(1), and the root requirement is implicit, you can't modify hooks as normal user anyway (or can you?).

Sep 20 2020, 7:46 PM · network
pi accepted D26488: Add additional example to ng_bpf(4).

The change is fine, with or without removing awk(1), and the root requirement is implicit, you can't modify hooks as normal user anyway (or can you?).

Sep 20 2020, 7:41 PM · network
pi added a comment to D26488: Add additional example to ng_bpf(4).
  1. about awk: So the mention of awk(1) can be removed from the EXAMPLES section ?
Sep 20 2020, 7:15 PM · network
lutz_donnerhacke.de added inline comments to D26488: Add additional example to ng_bpf(4).
Sep 20 2020, 7:09 PM · network
lutz_donnerhacke.de accepted D26489: IP address parsing in netgraph eating too many characters.

I'm fine with this fix for a special case.
I agree, that a more complete approach would be fine, but this can be done in a later stage.

Sep 20 2020, 7:04 PM · network
pi added a comment to D26488: Add additional example to ng_bpf(4).

The EXAMPLES section mentions tcpdump to generate BPF instructions that are fed into awk -- I do not see the awk(1) call in the example ? Is awk really needed for the example ?

Sep 20 2020, 7:02 PM · network
markus_stoffdv.at updated the diff for D26488: Add additional example to ng_bpf(4).
In D26488#589643, @pi wrote:

There are two ways to check man pages:

textproc/igor, it reports:

$ igor ng_bpf.4
ng_bpf.4:38:date not today, September 20, 2020:.Dd [April 29, 2020]
ng_bpf.4:173:blank line:

and mandoc -Tlint, which reports:

$ mandoc -Tlint ng_bpf.4
mandoc: ng_bpf.4:173:1: WARNING: blank line in fill mode, using .sp
mandoc: ng_bpf.4:117:2: STYLE: useless macro: Tn
mandoc: ng_bpf.4:124:2: STYLE: useless macro: Tn
mandoc: ng_bpf.4:130:2: STYLE: useless macro: Tn

Can you fix them ?

Sep 20 2020, 6:26 PM · network
freebsd_oprs.eu added a comment to D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

Re "vlan"/"svlan" naming - I don't have extremely strong opinion on this, but it would be nice if we could still consider using the same name for both. "Svlan" looks a bit like low-level implementation detail somehow leaked to the upper layers.

For example, it can be implemented in the following fashion:
ifconfig vlan5 create vlan 5 vlandev em0 vlanproto 802.1ad <-- svlan
ifconfig vlan5.25 create vlan 5 vlandev vlan5 <-- 8021.q on top of 802.1ad
ifconfig em0.5 create vlanproto 802.1ad <-- svlan

Do you think it would be more confusing for users?

Sep 20 2020, 6:18 PM · network
pi added a comment to D26488: Add additional example to ng_bpf(4).

There are two ways to check man pages:

Sep 20 2020, 5:42 PM · network
markus_stoffdv.at updated the diff for D26488: Add additional example to ng_bpf(4).

Now using documentation IP space and full context diff.

Sep 20 2020, 2:11 PM · network
markus_stoffdv.at added a comment to D26489: IP address parsing in netgraph eating too many characters.

After looking at your abandoned review (D26420) where you add parsing of IPv6 addresses. I wondered if we could use the generic inet_aton(3) functions available from kernel space?

Sep 20 2020, 2:07 PM · network