Wed, Nov 18
Fri, Nov 6
Sat, Oct 31
Oct 21 2020
Oct 20 2020
Ah, I should have anticipated that. It's done, thank you.
I'm going to commit this tomorrow, October 21 unless there are any objections.
This revision implements the test plan above as a proper set of ATF(7)/KYUA(1) test cases.
It also addresses the small nit in if_vlan.c (lowercase "802.1q" for consistency).
Oct 19 2020
That's great news, thanks ! I'm currently catching up on Kyua & the ATF; I'll push some tests today.
Oct 17 2020
Thank you for working on this!
Oct 12 2020
Oct 11 2020
Oct 4 2020
I'll just slip in a small cosmetic update while I still can (MT_LAMBDA becomes MT_FILTER).
Sep 28 2020
This updated revision implements the alternative solution discussed earlier. I've updated the test plan to account for the new parameter-based syntax, so I will not dwell on that here, but in a nutshell:
ifconfig svlan5 create vlandev em0 vlan 5 up ifconfig vlan42 create vlandev svlan5 vlan 42 inet 10.5.42.1/24
ifconfig vlan5 create vlandev em0 vlan 5 vlanproto 802.1ad up ifconfig vlan42 create vlandev vlan5 vlan 42 inet 10.5.42.1/24
Dot notation is supported, as long as everyone agrees that any interface with a dot in its name is a VLAN.
This is mostly a cosmetic update. It fixes the small issues (typos, etc...) raised in the previous revision. The idea is to have a clean base to compare the (upcoming) alternative implementation to.
Sep 21 2020
Also good from manpages (again).
Looks good to me.
Sep 20 2020
I don't have major concerns on the kernel implementation part, it's not worth doing for the sake of comparison. I guess description of both approaches is enough, :-)
I would suggest considering looking into what UI other major players have implemented. For example, looking at Linux implementation from the OS side and Cisco/Juniper from the NOS side could potentially provide enough datapoints to make a data-driven decision on what's the preferred UI should be.
The change is fine, with or without removing awk(1), and the root requirement is implicit, you can't modify hooks as normal user anyway (or can you?).
- about awk: So the mention of awk(1) can be removed from the EXAMPLES section ?
I'm fine with this fix for a special case.
I agree, that a more complete approach would be fine, but this can be done in a later stage.
The EXAMPLES section mentions tcpdump to generate BPF instructions that are fed into awk -- I do not see the awk(1) call in the example ? Is awk really needed for the example ?
Re "vlan"/"svlan" naming - I don't have extremely strong opinion on this, but it would be nice if we could still consider using the same name for both. "Svlan" looks a bit like low-level implementation detail somehow leaked to the upper layers.
For example, it can be implemented in the following fashion:
ifconfig vlan5 create vlan 5 vlandev em0 vlanproto 802.1ad <-- svlan
ifconfig vlan5.25 create vlan 5 vlandev vlan5 <-- 8021.q on top of 802.1ad
ifconfig em0.5 create vlanproto 802.1ad <-- svlan
Do you think it would be more confusing for users?
There are two ways to check man pages:
Now using documentation IP space and full context diff.