In D25380#1028541, @emaste wrote:

Do you intend to proceed with this?

Do you intend to proceed with this?

That's the way how DragonFlyBSD devs solved the problem
https://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/451640b7cf6bcf7826b901ac9a51647442adb96b

Resigning from this; I tried to provide feedback over IRC, but that was seemingly not well-received (and questions unanswered) and I'm not interested in reviewing this as-is. I'd much prefer splitting it into two scripts, one with, e.g., verbs, that manages wireguard interfaces and then the rc script that simply drives that in an obvious way. The last objection I heard was that there's too much state to pass around, but it's not at all clear why unless this is trying to mix way too much rc.conf configuration in with wg config.

In D41318#980524, @pauamma_gundo.com wrote:

No manual page to review, yet manpages is a group reviewer. Did a file get accidentally left out?

No manual page to review, yet manpages is a group reviewer. Did a file get accidentally left out?

This is my first review here, I hope to not be stepping on any toes. If I have, please correct me so I might do better next time. Overall your wireguard startup mechanism looks good and my suggestions are strictly cosmetic in nature. I would not be at all disappointed if this patch were committed unaltered.

The interface name restriction function is a judgment call restricting users from creating problematic (for shell scripts) interface names. Applying the same restrictions to existing services like netif and routing could break (partly) working configurations.

Manual page English LGTM.

first pass…

In our repo this is two separate commits, one for adding the enum and a second for the -r option. Anyone who wants to commit this, I'd be happy to provide git format-patch format.

Restructured to use an enum for output formats rather than a bool, making it easier to change the defaults or add additional formats in the future. This was rebased onto 13.2 as a part of our migration; I haven't checked whether it still applies to 14-current.

I rewrote this to use an enum for the format type rather than a boolean, making it more flexible in the future. Will re-upload some day.

Minor nits, fixable on commit if nothing else requires another round.

Upated ipfw.8, fix some mandoc -T lint warnings.

This patch is no longer needed since I'm trying to use wpa_supplicant(8) on wtap(4). See D38508.

@glebius ?

Ref the wiki of ifnet project: https://wiki.freebsd.org/projects/ifnet

In D37070#841801, @bz wrote:

See also https://reviews.freebsd.org/D32847

See also https://reviews.freebsd.org/D32847