Page MenuHomeFreeBSD

zec (Marko Zec)
User

Projects

User Details

User Since
Dec 14 2014, 3:26 PM (406 w, 4 d)

Recent Activity

May 4 2022

zec committed rGc4585b938a04: tests: vnet tests started failing in CI, disable temporarily (authored by zec).
tests: vnet tests started failing in CI, disable temporarily
May 4 2022, 4:30 AM
zec closed D35119: Disable VNET tests on CI temporarily.
May 4 2022, 4:30 AM

May 3 2022

zec added a reverting change for rG91f44749c6fe: ifnet: make if_index global: rGd461deeaa4a4: VNET: Revert "ifnet: make if_index global".
May 3 2022, 5:30 PM
zec committed rGd461deeaa4a4: VNET: Revert "ifnet: make if_index global" (authored by zec).
VNET: Revert "ifnet: make if_index global"
May 3 2022, 5:30 PM
zec added a reverting change for rGe1882428dcbb: ifnet/mbuf: provide KPI to serialize/restore m->m_pkthdr.rcvif: rG6c741ffbfa7f: Revert "mbuf: do not restore dying interfaces".
May 3 2022, 5:30 PM
zec added a reverting change for rG165746f4e4bf: dummynet: use m_rcvif_serialize/restore when queueing packets: rG894c574ed2f2: Revert "dummynet: use m_rcvif_serialize/restore when queueing packets".
May 3 2022, 5:30 PM
zec added a reverting change for rG703e533da5e2: mbuf: do not restore dying interfaces: rG6c741ffbfa7f: Revert "mbuf: do not restore dying interfaces".
May 3 2022, 5:30 PM
zec added a reverting change for rG6871de9363e5: netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs: rG0fa5636966c9: Revert "netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs".
May 3 2022, 5:30 PM
zec added a reverting change for D33672: ifnet: make if_index global: rGd461deeaa4a4: VNET: Revert "ifnet: make if_index global".
May 3 2022, 5:29 PM
zec committed rG6c741ffbfa7f: Revert "mbuf: do not restore dying interfaces" (authored by zec).
Revert "mbuf: do not restore dying interfaces"
May 3 2022, 5:29 PM
zec committed rG894c574ed2f2: Revert "dummynet: use m_rcvif_serialize/restore when queueing packets" (authored by zec).
Revert "dummynet: use m_rcvif_serialize/restore when queueing packets"
May 3 2022, 5:29 PM
zec added a reverting change for D33266: ifnet/mbuf: provide KPI to serialize/restore m->m_pkthdr.rcvif: rG6c741ffbfa7f: Revert "mbuf: do not restore dying interfaces".
May 3 2022, 5:29 PM
zec added a reverting change for D34076: mbuf: do not restore dying interfaces: rG6c741ffbfa7f: Revert "mbuf: do not restore dying interfaces".
May 3 2022, 5:29 PM
zec committed rG0fa5636966c9: Revert "netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs" (authored by zec).
Revert "netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs"
May 3 2022, 5:29 PM
zec committed rG711524d96123: tests/dummynet: disable since mbuf pointer serialization KPI to be backed out (authored by zec).
tests/dummynet: disable since mbuf pointer serialization KPI to be backed out
May 3 2022, 5:29 PM
zec added a reverting change for D33267: dummynet: use m_rcvif_serialize/restore when queueing packets: rG894c574ed2f2: Revert "dummynet: use m_rcvif_serialize/restore when queueing packets".
May 3 2022, 5:29 PM
zec added a reverting change for D33268: netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs: rG0fa5636966c9: Revert "netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs".
May 3 2022, 5:29 PM

Mar 30 2022

zec requested changes to D34704: if: avoid interface destroy race.

This change builds on top if_index globalization (91f44749c6feb50f39af8805dd803e860f0418f1) which I strongly objected to, and which glebius agreed to back out as outlined in https://github.com/glebius/FreeBSD/commits/backout-ifindex, but that never happened. Hence, pls. don't proceed with this until if_index is reverted back to per-VNET state.

Mar 30 2022, 7:08 PM

Feb 6 2022

zec committed rGd055313f8c60: fib_algo: shift / mask by constants in dxr_lookup() (authored by zec).
fib_algo: shift / mask by constants in dxr_lookup()
Feb 6 2022, 7:35 AM

Jan 31 2022

zec added a watcher for network: zec.
Jan 31 2022, 10:43 PM

Jan 16 2022

zec committed rGe7abe200c27b: fib_algo: shift / mask by constants in dxr_lookup() (authored by zec).
fib_algo: shift / mask by constants in dxr_lookup()
Jan 16 2022, 11:32 PM

Oct 13 2021

zec committed rG602f81ea50d5: [fib_algo][dxr] Retire counters which are no longer used (authored by zec).
[fib_algo][dxr] Retire counters which are no longer used
Oct 13 2021, 8:10 PM
zec committed rG0eeef61aec4b: [fib_algo][dxr] Improve incremental updating strategy (authored by zec).
[fib_algo][dxr] Improve incremental updating strategy
Oct 13 2021, 8:10 PM

Oct 9 2021

zec committed rGbc8b8e106bd1: [fib_algo][dxr] Retire counters which are no longer used (authored by zec).
[fib_algo][dxr] Retire counters which are no longer used
Oct 9 2021, 11:54 AM
zec committed rG1549575f22d1: [fib_algo][dxr] Improve incremental updating strategy (authored by zec).
[fib_algo][dxr] Improve incremental updating strategy
Oct 9 2021, 11:38 AM

Sep 29 2021

zec committed rGc5981a8130e2: [fib_algo][dxr] Merge adjacent empty range table chunks. (authored by zec).
[fib_algo][dxr] Merge adjacent empty range table chunks.
Sep 29 2021, 8:44 PM
zec committed rG94ad8d7c7a35: [fib_algo][dxr] Split unused range chunk list in multiple buckets (authored by zec).
[fib_algo][dxr] Split unused range chunk list in multiple buckets
Sep 29 2021, 8:44 PM

Sep 25 2021

zec committed rG43880c511cef: [fib_algo][dxr] Split unused range chunk list in multiple buckets (authored by zec).
[fib_algo][dxr] Split unused range chunk list in multiple buckets
Sep 25 2021, 4:54 AM

Sep 20 2021

zec committed rG2ac039f7be62: [fib_algo][dxr] Merge adjacent empty range table chunks. (authored by zec).
[fib_algo][dxr] Merge adjacent empty range table chunks.
Sep 20 2021, 4:38 AM

Sep 18 2021

zec committed rGec47ee78b461: [fib algo][dxr] Fix division by zero. (authored by zec).
[fib algo][dxr] Fix division by zero.
Sep 18 2021, 5:41 PM
zec committed rGad2cca48ed53: [fib algo][dxr] Optimize trie updating. (authored by zec).
[fib algo][dxr] Optimize trie updating.
Sep 18 2021, 5:40 PM
zec committed rGd3b9b83623f2: [fib algo][dxr] Fix undefined behavior. (authored by zec).
[fib algo][dxr] Fix undefined behavior.
Sep 18 2021, 5:40 PM

Sep 16 2021

zec committed rGeb3148cc4d25: [fib algo][dxr] Fix division by zero. (authored by zec).
[fib algo][dxr] Fix division by zero.
Sep 16 2021, 2:44 PM

Sep 15 2021

zec committed rGb51f8bae570b: [fib algo][dxr] Optimize trie updating. (authored by zec).
[fib algo][dxr] Optimize trie updating.
Sep 15 2021, 8:50 PM
zec committed rG442c8a245ee3: [fib algo][dxr] Fix undefined behavior. (authored by zec).
[fib algo][dxr] Fix undefined behavior.
Sep 15 2021, 8:50 PM

Jun 20 2021

zec committed rG402ddb85eed2: Add IPv4 fib lookup performance tests with uniform keys. (authored by melifaro).
Add IPv4 fib lookup performance tests with uniform keys.
Jun 20 2021, 11:32 AM
zec committed rG09274116f4d9: tests: Revise FIB lookups per second benchmarking routines (authored by zec).
tests: Revise FIB lookups per second benchmarking routines
Jun 20 2021, 11:32 AM
zec committed rG2b6b8ea60cb5: Revise FIB lookups per second benchmarking routines. (authored by zec).
Revise FIB lookups per second benchmarking routines.
Jun 20 2021, 11:32 AM

Jun 17 2021

zec committed rG4715d948c593: Introduce DXR as an IPv4 longest prefix matching / FIB module (authored by zec).
Introduce DXR as an IPv4 longest prefix matching / FIB module
Jun 17 2021, 10:36 AM
zec committed rGb6f8436b094d: tests: Revise FIB lookups per second benchmarking routines (authored by zec).
tests: Revise FIB lookups per second benchmarking routines
Jun 17 2021, 6:52 AM

May 18 2021

zec updated the summary of D30311: Revise FIB lookups per second benchmarking routines.
May 18 2021, 11:04 AM
zec updated the summary of D30311: Revise FIB lookups per second benchmarking routines.
May 18 2021, 11:03 AM

May 17 2021

zec updated the summary of D30311: Revise FIB lookups per second benchmarking routines.
May 17 2021, 10:20 AM
zec added reviewers for D30311: Revise FIB lookups per second benchmarking routines: melifaro, olivier.
May 17 2021, 10:17 AM
zec requested review of D30311: Revise FIB lookups per second benchmarking routines.
May 17 2021, 10:16 AM

May 13 2021

zec accepted D28601: netgraph/ng_bridge: Avoid cache thrashing.
May 13 2021, 5:00 PM

May 8 2021

zec added a comment to D29821: Introduce DXR IPv4 LPM as a fib_algo module..

function dxr_build with caller dxr_change_rib_batch seems to be still active

May 8 2021, 9:06 PM

May 5 2021

zec added a comment to D29821: Introduce DXR IPv4 LPM as a fib_algo module..

...

I assume that it's another independent routing algo module and should be considered as full replacement, not any supplementation.

May 5 2021, 8:14 PM
zec committed rG2aca58e16f50: Introduce DXR as an IPv4 longest prefix matching / FIB module (authored by zec).
Introduce DXR as an IPv4 longest prefix matching / FIB module
May 5 2021, 11:48 AM
zec closed D29821: Introduce DXR IPv4 LPM as a fib_algo module..
May 5 2021, 11:48 AM
zec committed rGa43104ebe763: Revise FIB lookups per second benchmarking routines. (authored by zec).
Revise FIB lookups per second benchmarking routines.
May 5 2021, 10:34 AM
zec closed D30096: Revise FIB lookups per second benchmarking routines.
May 5 2021, 10:34 AM

May 4 2021

zec updated the diff for D30096: Revise FIB lookups per second benchmarking routines.

Simplify injection of artificial dependencies between successive lookups in an attempt to fool / defeat apparently nifty and mighty Ryzen's value predictors.

May 4 2021, 1:42 PM
zec added inline comments to D30096: Revise FIB lookups per second benchmarking routines.
May 4 2021, 10:24 AM

May 3 2021

zec updated the summary of D30096: Revise FIB lookups per second benchmarking routines.
May 3 2021, 10:28 PM
zec requested review of D30096: Revise FIB lookups per second benchmarking routines.
May 3 2021, 10:16 PM
zec added inline comments to D29821: Introduce DXR IPv4 LPM as a fib_algo module..
May 3 2021, 6:19 PM
zec updated the diff for D29821: Introduce DXR IPv4 LPM as a fib_algo module..
May 3 2021, 6:09 PM

Apr 29 2021

zec updated the diff for D29821: Introduce DXR IPv4 LPM as a fib_algo module..

Switch to the new rib_walk_from KPI.

Apr 29 2021, 5:34 AM

Apr 21 2021

zec added inline comments to D29821: Introduce DXR IPv4 LPM as a fib_algo module..
Apr 21 2021, 12:02 PM
zec updated the diff for D29821: Introduce DXR IPv4 LPM as a fib_algo module..

Update.

Apr 21 2021, 11:36 AM

Apr 18 2021

zec requested review of D29821: Introduce DXR IPv4 LPM as a fib_algo module..
Apr 18 2021, 3:41 PM
zec accepted D29799: Fib algo: extend KPI by allowing algo to set datapath pointers..
Apr 18 2021, 1:04 PM

Apr 15 2021

zec accepted D29588: [FIB algo] Add support for the batched updates..

Do not update size of route change queue on failure.

Apr 15 2021, 9:29 AM

Apr 14 2021

zec added a comment to D29588: [FIB algo] Add support for the batched updates..

Fix case with small number of updates.

Apr 14 2021, 9:43 AM

Apr 9 2021

zec added inline comments to D29661: Appease -Wsign-compare in radix.c.
Apr 9 2021, 6:09 PM
zec added inline comments to D29661: Appease -Wsign-compare in radix.c.
Apr 9 2021, 12:57 PM
zec updated subscribers of D29661: Appease -Wsign-compare in radix.c.
Apr 9 2021, 9:59 AM

Apr 8 2021

zec added a comment to D29661: Appease -Wsign-compare in radix.c.

May you please provide a full context diff?
I can't see, why the compiler issued a warning and how the fix will break other things (i.e. logic errors)

Apr 8 2021, 10:11 PM
zec updated the diff for D29661: Appease -Wsign-compare in radix.c.

Expand the diff to -U30 per request from donner@.

Apr 8 2021, 10:10 PM
zec requested review of D29661: Appease -Wsign-compare in radix.c.
Apr 8 2021, 9:40 PM
zec added inline comments to D29588: [FIB algo] Add support for the batched updates..
Apr 8 2021, 9:04 PM

Dec 13 2020

zec committed R9:c367f0a18724: Add myself to the list. (authored by zec).
Add myself to the list.
Dec 13 2020, 5:46 PM
zec committed R9:4ab1878453ac: Add myself to the list. (authored by zec).
Add myself to the list.
Dec 13 2020, 5:46 PM
zec committed R9:330516587a80: Add log for __FreeBSD_version levels 800074 and 800075, corresponding (authored by zec).
Add log for __FreeBSD_version levels 800074 and 800075, corresponding
Dec 13 2020, 5:41 PM
zec committed R9:328645eec699: Document __FreeBSD_version bump to 800097 - introduction of vnet (authored by zec).
Document __FreeBSD_version bump to 800097 - introduction of vnet
Dec 13 2020, 5:39 PM

Sep 6 2020

zec committed rS365375: MFC r364973:.
MFC r364973:
Sep 6 2020, 10:23 AM
zec committed rS365374: MFC r364973:.
MFC r364973:
Sep 6 2020, 10:19 AM

Aug 30 2020

zec committed rS364973: Driver for 4x10Gb Ethernet reference NIC FPGA design for NetFPGA SUME.
Driver for 4x10Gb Ethernet reference NIC FPGA design for NetFPGA SUME
Aug 30 2020, 7:35 AM
zec closed D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Aug 30 2020, 7:35 AM

Aug 28 2020

zec added a comment to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.

I've tested the driver on 11.4-STABLE, and it works reasonably well, given the limitations of the (experimental) FPGA design. Denis made a "make universe" run on CURRENT and I did on 12.1 and the current patch didn't introduce any regressions. Hence, I'm inclined to commit this to HEAD as-is, ideally with a few cosmetic / non-functional changes I suggested in most recent comments. I intend to put on record Reviewed by: zec, bz (source), rgrimes, bcr (manpage)? Any further objections from the reviewers?

Aug 28 2020, 8:53 PM

Aug 27 2020

zec added inline comments to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Aug 27 2020, 10:26 AM
zec added inline comments to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Aug 27 2020, 9:43 AM
zec added inline comments to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Aug 27 2020, 9:09 AM

Aug 25 2020

zec added a comment to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.

rgrimes: me being essentially a manpage rookie as well, unfortunately I can't provide an advice to Denis on how proceed from here. None of the lines fill entirely or extend past 80 columns, and all sentences are terminated by line breaks. What else should we improve re. formatting? As non-native English speakers, we can also try to improve text composition and flow a bit, but I guess this is not what you had in mind?

Aug 25 2020, 9:07 PM
zec added inline comments to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Aug 25 2020, 4:05 PM

Aug 19 2020

zec added inline comments to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Aug 19 2020, 9:01 AM
zec added inline comments to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Aug 19 2020, 8:40 AM
zec added inline comments to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Aug 19 2020, 8:21 AM

Aug 18 2020

zec committed rS364368: Increase BER to PER lookup table size in an attempt to mitigate panics.
Increase BER to PER lookup table size in an attempt to mitigate panics
Aug 18 2020, 10:47 PM
zec committed rS364367: Fix ber parameter description..
Fix ber parameter description.
Aug 18 2020, 10:16 PM
zec added inline comments to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Aug 18 2020, 3:07 PM

Aug 16 2020

zec added inline comments to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Aug 16 2020, 8:55 PM

Aug 15 2020

zec added inline comments to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Aug 15 2020, 12:18 PM

Jun 25 2019

zec committed rS349371: Croatian calendar: update / fix names, dates, group national public.
Croatian calendar: update / fix names, dates, group national public
Jun 25 2019, 2:50 PM

Jun 19 2019

zec committed rS349186: V_ip6_forwarding and V_ipforwarding have been defined in ip6_var.h /.
V_ip6_forwarding and V_ipforwarding have been defined in ip6_var.h /
Jun 19 2019, 8:49 AM
zec committed rS349185: Evaluating htons() at compile time is more efficient than doing ntohs().
Evaluating htons() at compile time is more efficient than doing ntohs()
Jun 19 2019, 8:39 AM

May 16 2018

zec committed rS333680: A belated note crediting the FreeBSD Foundation for sponsoring.
A belated note crediting the FreeBSD Foundation for sponsoring
May 16 2018, 4:57 PM

May 4 2017

zec accepted D10592: pf: Fix vnet initialisation.
May 4 2017, 8:10 AM

Apr 25 2017

zec committed rS317400: Fix VNET leakages in PF by V_irtualizing pfr_ktables and friends..
Fix VNET leakages in PF by V_irtualizing pfr_ktables and friends.
Apr 25 2017, 8:34 AM