Address feedback from lwhsu@; thanks!

i could forsee someone writing something like a network manager plugin that doesn't specifically just want to call and parse shell output.

Where would it be reused?

(also nice work!)

out of curiousity - what do people think about extracting a bunch of code out of umbctl and stuffing it in a library that can be reused?

just and fyi, I've broken this down to 5 commits and only pushed the first so far

Looks good to me too.

From my testing this seems good. From there I will break this down a bit so the commits are smaller and start adding stuff next week

Thank you!

I'm sorry, I won't do it again. I thought it would be a hilarious way to ping.

Please don't accept your own revisions. That's implied ;-)

In D46689#1083011, @thj wrote:

In D46689#1082245, @damjan.jov_gmail.com wrote:

This update:

• Makes EIM opt-in, off by default, although I still think this decision needs broader discussion, or even a vote.

To be clear your position is that eim should be on by default?

And this one adds more context to the patch.

This update also changes NG_NAT_UDP_EIM from 0x800 to 0x200.

In D46689#1082245, @damjan.jov_gmail.com wrote:

This update:

• Makes EIM opt-in, off by default, although I still think this decision needs broader discussion, or even a vote.

This update:

• Makes EIM opt-in, off by default, although I still think this decision needs broader discussion, or even a vote.
• Adds "udp_eim" options to all the libalias uses: ipfw, natd, ng_nat, and ppp.
• Rewrites the man pages and header files so they are shorter and clearer.
• Man pages don't introduce new errors in igor.
• Uses PKT_ALIAS_UDP_EIM instead of PKT_ALIAS_ENDPOINT_INDEPENDENT.
• Renames the splay tree from "source" to "internal_endpoint" in the source code.
• Simplifies some conditions.

In D47410#1082152, @thj wrote:

Is there a reason this moves in the ordering of nat rules? We tend to aim for roughly alphabetical ordering if there isn't a reason for something different?

Moves the "endpoint-independent" section to come after "bitmask", so they're in alphabetical order.

Is there a reason this moves in the ordering of nat rules? We tend to aim for roughly alphabetical ordering if there isn't a reason for something different?

Also fix the typo: "caues" -> "causes".

I also need to patch ipfw and natd with user-settable options for the new flag, before this patch is fully ready... I am busy so that will probably take a few more weeks.

Generally looks good, there are some small nits, but I'm happy for this to land once you've made the changes to the man page and the comment at the top.

Sorry one more thing, can you upload future diffs with full context. It makes reviewing on phabricator much easier.

Two small things, I will start testing now

This new version adds a flag that can be used to turn this feature on and off (it is on by default for greater compatibility), adds documentation to the header file and man page, and wraps lines at 80 characters.

I really don't remember much of libalias internals. Trusting your expertise, Tom! Thanks, Damjan!

So far this generally looks ok to me and the tests seem to work.

In D25380#1028541, @emaste wrote:

Do you intend to proceed with this?

Do you intend to proceed with this?

That's the way how DragonFlyBSD devs solved the problem
https://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/451640b7cf6bcf7826b901ac9a51647442adb96b

Resigning from this; I tried to provide feedback over IRC, but that was seemingly not well-received (and questions unanswered) and I'm not interested in reviewing this as-is. I'd much prefer splitting it into two scripts, one with, e.g., verbs, that manages wireguard interfaces and then the rc script that simply drives that in an obvious way. The last objection I heard was that there's too much state to pass around, but it's not at all clear why unless this is trying to mix way too much rc.conf configuration in with wg config.

In D41318#980524, @pauamma_gundo.com wrote:

No manual page to review, yet manpages is a group reviewer. Did a file get accidentally left out?

No manual page to review, yet manpages is a group reviewer. Did a file get accidentally left out?

This is my first review here, I hope to not be stepping on any toes. If I have, please correct me so I might do better next time. Overall your wireguard startup mechanism looks good and my suggestions are strictly cosmetic in nature. I would not be at all disappointed if this patch were committed unaltered.

The interface name restriction function is a judgment call restricting users from creating problematic (for shell scripts) interface names. Applying the same restrictions to existing services like netif and routing could break (partly) working configurations.

Manual page English LGTM.

first pass…

In our repo this is two separate commits, one for adding the enum and a second for the -r option. Anyone who wants to commit this, I'd be happy to provide git format-patch format.

Restructured to use an enum for output formats rather than a bool, making it easier to change the defaults or add additional formats in the future. This was rebased onto 13.2 as a part of our migration; I haven't checked whether it still applies to 14-current.

I rewrote this to use an enum for the format type rather than a boolean, making it more flexible in the future. Will re-upload some day.

Minor nits, fixable on commit if nothing else requires another round.

Upated ipfw.8, fix some mandoc -T lint warnings.

This patch is no longer needed since I'm trying to use wpa_supplicant(8) on wtap(4). See D38508.

@glebius ?

Ref the wiki of ifnet project: https://wiki.freebsd.org/projects/ifnet

In D37070#841801, @bz wrote:

See also https://reviews.freebsd.org/D32847