Stuck on athn_usb_detach code or executes athn_usb_stop multiple times
I suspect this is due to the msleep on one threat and a wakeup on another, but I am not certain how to isolate the problem.

Abandoning because it's already fixed.

In D47410#1137166, @ziaee wrote:

Hey Damjan. Are you still interested in this? Your latest patch is just removing those blocks. Please squash your commits into one and try remaking the patch. If not, please close this. Thanks for your submission!

Thank you for this fix. Works fine with Netlink.

Current Problem: Running into a recursive mutex based on FreeBSD/OpenBSD mutex styles.

Working to update the athn_usb_init, currently working through the newstate handler.

In D49884#1137462, @imp wrote:

In D49884#1137457, @lwhsu wrote:

I think the current idea is avoiding directly import firmware file into repo. Perhaps we can separate the firmware out. The current approach is using firmware ports/pkg, before having that, we can just put it somewhere and ask people to grab it and put to the required place, for testing.

Or point them at the linux wireless firmware archive repo....

In D49884#1137457, @lwhsu wrote:

I think the current idea is avoiding directly import firmware file into repo. Perhaps we can separate the firmware out. The current approach is using firmware ports/pkg, before having that, we can just put it somewhere and ask people to grab it and put to the required place, for testing.

I think the current idea is avoiding directly import firmware file into repo. Perhaps we can separate the firmware out. The current approach is using firmware ports/pkg, before having that, we can just put it somewhere and ask people to grab it and put to the required place, for testing.

Hey Damjan. Are you still interested in this? Your latest patch is just removing those blocks. Please squash your commits into one and try remaking the patch. If not, please close this. Thanks for your submission!

In D49677#1132641, @tuexen wrote:

If I understand the patch correctly, it contains three components:

• the fix by replacing in_delayed_cksum(m) with in_delayed_cksum_o(m, ipofs) in ng_nat.c.
• adding protection code which logs a warning.
• refactoring the code to remove indentation by using goto send.

It might be useful to separate these three when committing the code.

If I understand the patch correctly, it contains three components:

• the fix by replacing in_delayed_cksum(m) with in_delayed_cksum_o(m, ipofs) in ng_nat.c.
• adding protection code which logs a warning.
• refactoring the code to remove indentation by using goto send.

It might be useful to separate these three when committing the code.

printf() -> log(). Fix type mismatch.

Fix error message.

Fix mismerge.

Thank you for working on this! Can we add tests here?

I vastly under appreciated that folks rely upon the ng_eiface not moving with the struct ifnet. Probably because I've been using them in jails for over a decade and only recently noticed myself.

In D49158#1121374, @zec wrote:

Your obsession with getting rid of the "flawed" if_vmove() is noted, but for the sake of other people who may have a different view, and who have applications relying on this very concept for 20+ years, please do not take that route.

In D49158#1121338, @glebius wrote:

I do not like the plan. The picture drawn shows that a netgraph node in one vnet is connected to a node in a different vnet. This is basically a violation of the idea of vnet. Virtualized stacks should communicate with each other via network protocols, not kernel pointers. The only legal exclusion is epair(4).

I think I'll just accept my understanding is flawed now to save time and withdraw this. Thank you.

I do not like the plan. The picture drawn shows that a netgraph node in one vnet is connected to a node in a different vnet. This is basically a violation of the idea of vnet. Virtualized stacks should communicate with each other via network protocols, not kernel pointers. The only legal exclusion is epair(4). You may create a new netgraph node for your purpose - a node that is present in two vnets, that would be a second legal exclusion to the virtualization rule.

By design, moving an eiface ifnet from one vnet to another always implied that its netgraph node will remain attached in the parent vnet. This is not an omission or a mistake, but a well established mode of operation on which certain applications heavily depend on, and which this patch proposes to change, for reasons not clearly stated.

yay!

Updated to compile and work with the new ifabi changes.

Thanks for the heads up! Looking into it...

hi! I just tried compiling this on -HEAD (to land it today!) and it failed; it looks like you need to go adapt it to the iflib/ifnet changes (ie, that hid struct ifnet behind if_private.h.)

Integrate suggestions from Zhenlei Huang (zlei@); thank you!

@glebius: Also, Here is my github repo as you requested.
spmzt/freebsd-src/tree/ksocket_ipv6: D48204

Bump .Dd in ng_ksocket.4
update value from January 9, 2012 to January 9, 2025

Also, any meaningful change to a manual page requires bumping the .Dd value at the beginning of the page to today's date.

The manpage changes look great to me!

In D48167#1103394, @ziaee wrote:

I'm so excited to test this driver this weekend! Thank you so much for submitting this! All of the suggestions I made are to bring it into alignment with the rest of the freebsd manual and are specified in the manual page style guide, style.mdoc(5). Sorry I'm so late.

This change applies the rest of the changes suggested to the manual pages.

I'm so excited to test this driver this weekend! Thank you so much for submitting this! All of the suggestions I made are to bring it into alignment with the rest of the freebsd manual and are specified in the manual page style guide, style.mdoc(5). Sorry I'm so late.

This update to the diff brings:

Here's what I've got so far for the manual. I ordered some parts to test but they're not all here yet.

In D48167#1103157, @khorben_defora.org wrote:

I am currently looking into adding the SPDX license identifier, but it can also be done in a separate review.

Ok, i'll wait for the SPDX addition and then if I don't get any other feedback I'll land it

In D48167#1103156, @adrian wrote:

I think it's fine as-is to go in the tree, it's been two years and I'd like to see this in before -15.

I think it's fine as-is to go in the tree, it's been two years and I'd like to see this in before -15.

Address feedback from lwhsu@; thanks!

i could forsee someone writing something like a network manager plugin that doesn't specifically just want to call and parse shell output.

Where would it be reused?

(also nice work!)

out of curiousity - what do people think about extracting a bunch of code out of umbctl and stuffing it in a library that can be reused?

just and fyi, I've broken this down to 5 commits and only pushed the first so far

Looks good to me too.

From my testing this seems good. From there I will break this down a bit so the commits are smaller and start adding stuff next week

Thank you!

I'm sorry, I won't do it again. I thought it would be a hilarious way to ping.

Please don't accept your own revisions. That's implied ;-)

In D46689#1083011, @thj wrote:

In D46689#1082245, @damjan.jov_gmail.com wrote:

This update:

• Makes EIM opt-in, off by default, although I still think this decision needs broader discussion, or even a vote.

To be clear your position is that eim should be on by default?

And this one adds more context to the patch.

This update also changes NG_NAT_UDP_EIM from 0x800 to 0x200.

In D46689#1082245, @damjan.jov_gmail.com wrote:

This update:

• Makes EIM opt-in, off by default, although I still think this decision needs broader discussion, or even a vote.

This update:

• Makes EIM opt-in, off by default, although I still think this decision needs broader discussion, or even a vote.
• Adds "udp_eim" options to all the libalias uses: ipfw, natd, ng_nat, and ppp.
• Rewrites the man pages and header files so they are shorter and clearer.
• Man pages don't introduce new errors in igor.
• Uses PKT_ALIAS_UDP_EIM instead of PKT_ALIAS_ENDPOINT_INDEPENDENT.
• Renames the splay tree from "source" to "internal_endpoint" in the source code.
• Simplifies some conditions.

In D47410#1082152, @thj wrote:

Is there a reason this moves in the ordering of nat rules? We tend to aim for roughly alphabetical ordering if there isn't a reason for something different?

Moves the "endpoint-independent" section to come after "bitmask", so they're in alphabetical order.