Page MenuHomeFreeBSD

Fix the pf.conf(5) man page "endpoint-independent" section
AbandonedPublic

Authored by damjan.jov_gmail.com on Nov 3 2024, 12:12 PM.
Referenced Files
Unknown Object (File)
Thu, Sep 25, 1:55 AM
Unknown Object (File)
Mon, Sep 22, 4:32 AM
Unknown Object (File)
Sep 15 2025, 3:22 PM
Unknown Object (File)
Sep 14 2025, 1:23 AM
Unknown Object (File)
Sep 11 2025, 5:18 AM
Unknown Object (File)
Sep 10 2025, 8:31 AM
Unknown Object (File)
Sep 10 2025, 7:31 AM
Unknown Object (File)
Sep 6 2025, 12:30 AM
Subscribers

Details

Reviewers
thj
Group Reviewers
manpages
Summary

In commit 390dc369efaaeca2802baf168ddbd7a40e3afcc8, the "endpoint-independent" section was inserted in the middle of the "map-e-portset" section. Fix this.

Test Plan

Visibly check the look of the man page.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Also fix the typo: "caues" -> "causes".

Is there a reason this moves in the ordering of nat rules? We tend to aim for roughly alphabetical ordering if there isn't a reason for something different?

Moves the "endpoint-independent" section to come after "bitmask", so they're in alphabetical order.

In D47410#1082152, @thj wrote:

Is there a reason this moves in the ordering of nat rules? We tend to aim for roughly alphabetical ordering if there isn't a reason for something different?

That's fixed now, although most of the other entries are not in alphabetical order.

Also this is meant to repair the "map-e-portset" option, which began on line 2284, and was corrupted by having the "endpoint-independent" section pasted in the middle of it.

Hey Damjan. Are you still interested in this? Your latest patch is just removing those blocks. Please squash your commits into one and try remaking the patch. If not, please close this. Thanks for your submission!

Hey Damjan. Are you still interested in this? Your latest patch is just removing those blocks. Please squash your commits into one and try remaking the patch. If not, please close this. Thanks for your submission!

This was already fixed in the following commit:

---snip---
commit 725003da53021c15b1d2274d5c4440c7c6e6602a
Author: Ed Maste <emaste@FreeBSD.org>
Date: Thu Dec 19 20:33:53 2024 -0500

pf.conf.5: Fix endpoint-independent description

The description of the endpoint-independent option accidentally ended up
in the middle of map-e-portset's text.

Fixes: 390dc369efaa ("pf: Add support for endpoint independent NAT bindings for UDP")

Reviewed by:    kp
Sponsored by:   Tailscale
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D48158

---snip---

So this review can be closed now, we don't need it any more.

Abandoning because it's already fixed.