Page MenuHomeFreeBSD

enweiwu (EN-WEU WU)
User

Projects

User Details

User Since
May 27 2022, 6:57 AM (79 w, 1 d)

Recent Activity

May 2 2023

enweiwu updated the diff for D36243: wtap(4): Implement STA/HostAP mode and support WPA/WPA2.
May 2 2023, 4:52 PM · wireless
enweiwu added inline comments to D36243: wtap(4): Implement STA/HostAP mode and support WPA/WPA2.
May 2 2023, 4:51 PM · wireless
enweiwu updated the diff for D36243: wtap(4): Implement STA/HostAP mode and support WPA/WPA2.
May 2 2023, 4:46 PM · wireless

Apr 19 2023

enweiwu updated the diff for D36243: wtap(4): Implement STA/HostAP mode and support WPA/WPA2.
Apr 19 2023, 4:47 PM · wireless

Mar 6 2023

enweiwu accepted D38807: WPA: backout upstream IFF_ change and add logging.

I have updated the D36243 and now it works well !

Mar 6 2023, 2:31 AM

Mar 5 2023

enweiwu updated the diff for D36243: wtap(4): Implement STA/HostAP mode and support WPA/WPA2.
Mar 5 2023, 8:15 AM · wireless
enweiwu updated the diff for D36243: wtap(4): Implement STA/HostAP mode and support WPA/WPA2.
Mar 5 2023, 8:05 AM · wireless
enweiwu abandoned D38753: wpa_supplicant(8): fix the connection-fail problem.

See D38807.

Mar 5 2023, 7:51 AM · wireless

Mar 2 2023

enweiwu abandoned D38508: net80211(4): fix the connection-fail problem in wpa_supplicant(8).

See D38807 and D38753.

Mar 2 2023, 12:40 PM · wireless
enweiwu added a comment to D38807: WPA: backout upstream IFF_ change and add logging.

This patch works well with my rtl8188eu.

Mar 2 2023, 12:39 PM
enweiwu updated the diff for D36243: wtap(4): Implement STA/HostAP mode and support WPA/WPA2.
Mar 2 2023, 12:27 PM · wireless
enweiwu abandoned D36242: ifconfig: 80211, add assoc parameter.

This patch is no longer needed since I'm trying to use wpa_supplicant(8) on wtap(4). See D38508.

Mar 2 2023, 12:17 PM · network

Feb 26 2023

enweiwu added a comment to D38753: wpa_supplicant(8): fix the connection-fail problem.
In D38753#882303, @cy wrote:
Feb 26 2023, 6:54 AM · wireless

Feb 24 2023

enweiwu updated the diff for D38753: wpa_supplicant(8): fix the connection-fail problem.
Feb 24 2023, 6:04 AM · wireless
enweiwu updated the diff for D38753: wpa_supplicant(8): fix the connection-fail problem.
Feb 24 2023, 6:03 AM · wireless
enweiwu requested review of D38753: wpa_supplicant(8): fix the connection-fail problem.
Feb 24 2023, 5:48 AM · wireless

Feb 18 2023

enweiwu accepted D38660: net80211: ieee80211_swscan_bg_scan() track return variable under lock.
Feb 18 2023, 5:13 PM
enweiwu added a comment to D38508: net80211(4): fix the connection-fail problem in wpa_supplicant(8).

I think the reason might be (though I haven't traced this yet) is that we exploit a race with ic_parent and the 2d time we come through ieee80211_start_locked() though this time with the interface UP. This then calls ieee80211_new_state_locked() which will then kick off another task. If we manage to call the ioctl for scanning in between we'll still be in INIT. Basically the IFF_DOWN kicks us back to INIT, no scan running and then on IFF_UP it's a simple race for the 1st VAP (only).

Feb 18 2023, 3:23 PM · wireless
enweiwu added a member for wireless: enweiwu.
Feb 18 2023, 8:17 AM

Feb 17 2023

enweiwu added a comment to D38508: net80211(4): fix the connection-fail problem in wpa_supplicant(8).

Now that would mean SCAN_ONCE should not be unset and we should not enter in the early case above even if match_bss et al decide they couldn't find a result.

Feb 17 2023, 4:34 PM · wireless

Feb 15 2023

enweiwu updated the diff for D38508: net80211(4): fix the connection-fail problem in wpa_supplicant(8).

Move ieee80211_notify_scan_done() to a more reasonable place after seeing the comments of @bz.

Feb 15 2023, 5:17 PM · wireless
enweiwu added a comment to D38508: net80211(4): fix the connection-fail problem in wpa_supplicant(8).

Can you check that what you are seeing is not caused by an early return in ieee80211_scan_sw.c::scan_end() in the block which has a debug message containing "done, restart"?

Feb 15 2023, 5:01 PM · wireless
enweiwu added a comment to D38508: net80211(4): fix the connection-fail problem in wpa_supplicant(8).

Phabricator should automatically make likes, at least for hashes in plain text:
5fcdc19a81115
d06d7eb09131

Feb 15 2023, 4:03 PM · wireless
enweiwu updated the summary of D38508: net80211(4): fix the connection-fail problem in wpa_supplicant(8).
Feb 15 2023, 4:02 PM · wireless

Feb 13 2023

enweiwu added a comment to D38508: net80211(4): fix the connection-fail problem in wpa_supplicant(8).

I have found that Linux drivers don't always notify the scan result event to nl80211, so in wpa_supplicant, Linux code just registers timeout on the scan function (wpa_driver_nl80211_scan()). Once the timeout fire, it reports the EVENT_SCAN_RESULTS to wpa_supplicant_event().

Feb 13 2023, 5:35 AM · wireless

Feb 12 2023

enweiwu added a comment to D38508: net80211(4): fix the connection-fail problem in wpa_supplicant(8).
In D38508#876443, @bz wrote:

Has this always been a problem or did something in wpa_supplicant change that it now is a problem?

I traced wpa_supplicant 2.4 but the mechanism (use routing socket to wait for RTM_IEEE80211_SCAN) seems the same as 2.10.

Feb 12 2023, 7:00 AM · wireless

Feb 11 2023

enweiwu requested review of D38508: net80211(4): fix the connection-fail problem in wpa_supplicant(8).
Feb 11 2023, 5:59 PM · wireless

Jan 19 2023

enweiwu updated the diff for D37973: wtapctl(8): Introduce new tool for wtap(4).

Remove unnecessary .El and the term "vap" in wtapctl.8.

Jan 19 2023, 10:25 AM · wireless

Jan 7 2023

enweiwu requested review of D37973: wtapctl(8): Introduce new tool for wtap(4).
Jan 7 2023, 8:37 AM · wireless

Dec 3 2022

enweiwu requested review of D37596: Makefile.inc1: Replace obsolete comment NO_CLEAN by WITHOUT_CLEAN.
Dec 3 2022, 11:58 AM · Src Committers

Nov 9 2022

enweiwu updated the diff for D36469: wtap(4): implement monitor mode and handle radiotap.
Nov 9 2022, 6:23 AM · wireless

Oct 20 2022

enweiwu added a comment to D37070: ifconfig(8): scan list SSID UTF-32 support.
In D37070#841801, @bz wrote:
Oct 20 2022, 4:57 PM · network, wireless
enweiwu updated the test plan for D37070: ifconfig(8): scan list SSID UTF-32 support.
Oct 20 2022, 3:11 PM · network, wireless
enweiwu requested review of D37070: ifconfig(8): scan list SSID UTF-32 support.
Oct 20 2022, 3:10 PM · network, wireless

Sep 25 2022

enweiwu updated the diff for D36480: wtap(4): write atf test scripts to test all iface mode.
Sep 25 2022, 1:48 PM · wireless

Sep 7 2022

enweiwu requested review of D36480: wtap(4): write atf test scripts to test all iface mode.
Sep 7 2022, 12:09 PM · wireless

Sep 6 2022

enweiwu updated the test plan for D36469: wtap(4): implement monitor mode and handle radiotap.
Sep 6 2022, 3:04 PM · wireless
enweiwu updated the test plan for D36469: wtap(4): implement monitor mode and handle radiotap.
Sep 6 2022, 2:22 PM · wireless
enweiwu requested review of D36469: wtap(4): implement monitor mode and handle radiotap.
Sep 6 2022, 2:21 PM · wireless
enweiwu updated the diff for D36243: wtap(4): Implement STA/HostAP mode and support WPA/WPA2.
Sep 6 2022, 1:45 PM · wireless

Aug 20 2022

enweiwu added a comment to D36242: ifconfig: 80211, add assoc parameter.
In D36242#823477, @cy wrote:

Will there be a man page update for this at some point?

Aug 20 2022, 1:09 PM · network

Aug 17 2022

enweiwu requested review of D36243: wtap(4): Implement STA/HostAP mode and support WPA/WPA2.
Aug 17 2022, 2:56 PM · wireless
enweiwu requested review of D36242: ifconfig: 80211, add assoc parameter.
Aug 17 2022, 2:23 PM · network

Aug 12 2022

enweiwu updated the diff for D35841: wtap(4): Implement IBSS mode on wtap(4).
Aug 12 2022, 8:04 AM · wireless

Jul 27 2022

enweiwu added inline comments to D35841: wtap(4): Implement IBSS mode on wtap(4).
Jul 27 2022, 10:29 AM · wireless

Jul 25 2022

enweiwu updated the test plan for D35841: wtap(4): Implement IBSS mode on wtap(4).
Jul 25 2022, 12:37 PM · wireless

Jul 19 2022

enweiwu updated the diff for D35841: wtap(4): Implement IBSS mode on wtap(4).

Update diff.

Jul 19 2022, 7:47 AM · wireless
enweiwu added inline comments to D35841: wtap(4): Implement IBSS mode on wtap(4).
Jul 19 2022, 7:13 AM · wireless
enweiwu added inline comments to D35841: wtap(4): Implement IBSS mode on wtap(4).
Jul 19 2022, 7:05 AM · wireless

Jul 18 2022

enweiwu updated the test plan for D35841: wtap(4): Implement IBSS mode on wtap(4).
Jul 18 2022, 4:32 PM · wireless
enweiwu updated the summary of D35841: wtap(4): Implement IBSS mode on wtap(4).
Jul 18 2022, 11:59 AM · wireless
enweiwu updated the summary of D35841: wtap(4): Implement IBSS mode on wtap(4).
Jul 18 2022, 11:54 AM · wireless
enweiwu requested review of D35841: wtap(4): Implement IBSS mode on wtap(4).
Jul 18 2022, 10:48 AM · wireless

Jul 8 2022

enweiwu updated the summary of D35752: wtap(4): Fix bug in wtap_node_write() and wtap_vap_create().
Jul 8 2022, 3:47 PM · wireless
enweiwu updated the summary of D35751: wtap(4): Rename physical interface.
Jul 8 2022, 3:47 PM · wireless
enweiwu updated the diff for D35752: wtap(4): Fix bug in wtap_node_write() and wtap_vap_create().
Jul 8 2022, 10:07 AM · wireless
enweiwu updated the diff for D35751: wtap(4): Rename physical interface.
Jul 8 2022, 10:03 AM · wireless
enweiwu retitled D35752: wtap(4): Fix bug in wtap_node_write() and wtap_vap_create() from [wtap(4)] Fix bug in wtap_node_write() and wtap_vap_create() to wtap(4): Fix bug in wtap_node_write() and wtap_vap_create().
Jul 8 2022, 7:35 AM · wireless
enweiwu retitled D35752: wtap(4): Fix bug in wtap_node_write() and wtap_vap_create() from [wtap] Fix bug in wtap_node_write() and wtap_vap_create() to [wtap(4)] Fix bug in wtap_node_write() and wtap_vap_create().
Jul 8 2022, 7:35 AM · wireless
enweiwu updated the summary of D35752: wtap(4): Fix bug in wtap_node_write() and wtap_vap_create().
Jul 8 2022, 7:34 AM · wireless
enweiwu updated the summary of D35752: wtap(4): Fix bug in wtap_node_write() and wtap_vap_create().
Jul 8 2022, 7:34 AM · wireless
enweiwu retitled D35752: wtap(4): Fix bug in wtap_node_write() and wtap_vap_create() from Fix bug in wtap_node_write() and wtap_vap_create() to [wtap] Fix bug in wtap_node_write() and wtap_vap_create().
Jul 8 2022, 6:55 AM · wireless
enweiwu retitled D35751: wtap(4): Rename physical interface from Rename physical interface to [wtap] Rename physical interface.
Jul 8 2022, 6:54 AM · wireless
enweiwu abandoned D35743: [wtap] Format the code and rename physical interface.
Jul 8 2022, 6:53 AM · wireless
enweiwu updated the summary of D35752: wtap(4): Fix bug in wtap_node_write() and wtap_vap_create().
Jul 8 2022, 6:46 AM · wireless
enweiwu requested review of D35752: wtap(4): Fix bug in wtap_node_write() and wtap_vap_create().
Jul 8 2022, 6:35 AM · wireless
enweiwu updated the summary of D35751: wtap(4): Rename physical interface.
Jul 8 2022, 5:08 AM · wireless
enweiwu requested review of D35751: wtap(4): Rename physical interface.
Jul 8 2022, 5:07 AM · wireless

Jul 7 2022

enweiwu requested review of D35743: [wtap] Format the code and rename physical interface.
Jul 7 2022, 2:14 PM · wireless

Jun 29 2022

enweiwu added a comment to D35624: wtap: remove unused variable and bzero.

Probably the commit message can be more precise. For example:

Remove store only variable and unnecessary bzero()

- Remove the variable set but not used to fix build on -CURRENT
- Remove bzero() on the space malloc'd with M_ZERO flag.

@rickywu0421_gmail.com: is this message correct?

Jun 29 2022, 6:27 AM · wireless

Jun 28 2022

lwhsu renamed enweiwu from rickywu0421_gmail.com to enweiwu.
Jun 28 2022, 8:26 PM
enweiwu requested review of D35624: wtap: remove unused variable and bzero.
Jun 28 2022, 9:09 AM · wireless