net80211: ieee80211_swscan_bg_scan() track return variable under lock
ClosedPublic
Actions

Authored by bz on Feb 18 2023, 1:22 AM.

Tags

None

Referenced Files

	F135915513: D38660.id117839.diff
	Fri, Nov 14, 3:09 AM

	Unknown Object (File)
	Sat, Nov 1, 12:48 AM

	Unknown Object (File)
	Tue, Oct 28, 4:42 AM

	Unknown Object (File)
	Sat, Oct 25, 7:07 PM

	Unknown Object (File)
	Sun, Oct 19, 11:57 AM

	Unknown Object (File)
	Sun, Oct 19, 4:14 AM

	Unknown Object (File)
	Fri, Oct 17, 8:07 AM

	Unknown Object (File)
	Thu, Oct 16, 4:12 PM

Subscribers

Details

Reviewers

enweiwu
adrian

Group Reviewers

wireless

Commits

rGc9ba91435a01: net80211: ieee80211_swscan_bg_scan() track return variable under lock

Summary

As the comment says it probably does not matter but use a local
variable to track state under lock so we can return the last known
good state of what we thought we were operating under after unlocking.

Likely no functional changes.

Sponsored by: The FreeBSD Foundation
MFC atfer: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Feb 18 2023, 1:22 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptFeb 18 2023, 1:22 AM

bz requested review of this revision.Feb 18 2023, 1:22 AM

Harbormaster completed remote builds in B49871: Diff 117520.Feb 18 2023, 1:22 AM

enweiwu accepted this revision.Feb 18 2023, 5:13 PM

This revision is now accepted and ready to land.Feb 18 2023, 5:13 PM

adrian accepted this revision.Feb 18 2023, 5:17 PM

Closed by commit rGc9ba91435a01: net80211: ieee80211_swscan_bg_scan() track return variable under lock (authored by bz). · Explain WhyFeb 23 2023, 9:14 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGc9ba91435a01: net80211: ieee80211_swscan_bg_scan() track return variable under lock.

Revision Contents
Changeset List

Path

Size

sys/

net80211/

ieee80211_scan_sw.c

8 lines

Diff 117839

View Options

sys/net80211/ieee80211_scan_sw.c

net80211: ieee80211_swscan_bg_scan() track return variable under lockClosedPublicActions