wtap: remove unused variable and bzero
ClosedPublic
Actions

Authored by enweiwu on Jun 28 2022, 9:09 AM.

Details

Reviewers

bz
lwhsu

Commits

rGcf337fcd7413: Remove store-only variable and unnecessary bzero()

Summary

bzero is not necessary because the flag M_ZERO is ORed and passed into malloc().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

enweiwu created this revision.Jun 28 2022, 9:09 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 28 2022, 9:09 AM

enweiwu requested review of this revision.Jun 28 2022, 9:09 AM

lwhsu accepted this revision.Jun 28 2022, 4:30 PM

This revision is now accepted and ready to land.Jun 28 2022, 4:30 PM

Probably the commit message can be more precise. For example:

Remove store only variable and unnecessary bzero()

- Remove the variable set but not used to fix build on -CURRENT
- Remove bzero() on the space malloc'd with M_ZERO flag.

@rickywu0421_gmail.com: is this message correct?

In D35624#808065, @lwhsu wrote:
Probably the commit message can be more precise. For example:
Remove store only variable and unnecessary bzero()

- Remove the variable set but not used to fix build on -CURRENT
- Remove bzero() on the space malloc'd with M_ZERO flag.
@rickywu0421_gmail.com: is this message correct?

Yes, correct. I think "store only" may be "store-only".

Closed by commit rGcf337fcd7413: Remove store-only variable and unnecessary bzero() (authored by En-Wei Wu <enweiwu@FreeBSD.org>, committed by lwhsu). · Explain WhyJun 29 2022, 12:04 PM

This revision was automatically updated to reflect the committed changes.

lwhsu added a commit: rGcf337fcd7413: Remove store-only variable and unnecessary bzero().

enweiwu added a child revision: D35751: wtap(4): Rename physical interface.Jul 8 2022, 5:08 AM