Page MenuHomeFreeBSD

wtap: remove unused variable and bzero
ClosedPublic

Authored by enweiwu on Jun 28 2022, 9:09 AM.

Details

Summary

bzero is not necessary because the flag M_ZERO is ORed and passed into malloc().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 28 2022, 4:30 PM

Probably the commit message can be more precise. For example:

Remove store only variable and unnecessary bzero()

- Remove the variable set but not used to fix build on -CURRENT
- Remove bzero() on the space malloc'd with M_ZERO flag.

@rickywu0421_gmail.com: is this message correct?

Probably the commit message can be more precise. For example:

Remove store only variable and unnecessary bzero()

- Remove the variable set but not used to fix build on -CURRENT
- Remove bzero() on the space malloc'd with M_ZERO flag.

@rickywu0421_gmail.com: is this message correct?

Yes, correct. I think "store only" may be "store-only".