Page MenuHomeFreeBSD

pkg-serve(8): serve pkg repositories over TCP via inetd
ClosedPublic

Authored by bapt on Mar 17 2026, 11:04 AM.
Tags
None
Referenced Files
F153939277: D55895.id174001.diff
Fri, Apr 24, 11:11 PM
Unknown Object (File)
Sun, Apr 19, 1:14 AM
Unknown Object (File)
Sat, Apr 18, 2:09 PM
Unknown Object (File)
Sat, Apr 18, 11:44 AM
Unknown Object (File)
Sat, Apr 18, 11:44 AM
Unknown Object (File)
Sat, Apr 18, 9:46 AM
Unknown Object (File)
Fri, Apr 17, 1:04 AM
Unknown Object (File)
Wed, Apr 15, 10:11 AM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bapt requested review of this revision.Mar 17 2026, 11:04 AM
manu added a subscriber: manu.
manu added inline comments.
libexec/pkg-serve/pkg-serve.8
2

s/6/2026/

This revision is now accepted and ready to land.Mar 17 2026, 12:29 PM
This revision now requires review to proceed.Mar 17 2026, 12:41 PM
bdrewery added a subscriber: bdrewery.

Nice work

libexec/pkg-serve/pkg-serve.c
176–177

Resources get cleaned up on successful exit but not on setup errors.

This revision is now accepted and ready to land.Mar 17 2026, 3:38 PM
libexec/pkg-serve/pkg-serve.c
134

is this actually necessary if it's running under Capsicum? it could flag on some legitimate files, depending on what people are using it for.

168

this will write too much data if the file grows in size while writing. probably it needs to track total size and indicate some sort of protocol error if the file is larger than expected.

libexec/Makefile
17

imo, this is preferable:

SUBDIR.${MK_PKGSERVE}+= pkgserve

this is the syntax we've been using for man, confs, etc., and it's much easier to read.

i wonder: why is this in base, when pkg repository can only be built when pkg(8) is installed?

This revision now requires review to proceed.Mar 20 2026, 8:31 AM

Address bdrewery's comments

bapt marked 4 inline comments as done.Mar 20 2026, 8:55 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 20 2026, 12:33 PM
This revision was automatically updated to reflect the committed changes.