Page MenuHomeFreeBSD

pkg-serve(8): serve pkg repositories over TCP via inetd
AcceptedPublic

Authored by bapt on Tue, Mar 17, 11:04 AM.

Details

Reviewers
manu
bdrewery

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71455
Build 68338: arc lint + arc unit

Event Timeline

bapt requested review of this revision.Tue, Mar 17, 11:04 AM
manu added a subscriber: manu.
manu added inline comments.
libexec/pkg-serve/pkg-serve.8
2

s/6/2026/

This revision is now accepted and ready to land.Tue, Mar 17, 12:29 PM
This revision now requires review to proceed.Tue, Mar 17, 12:41 PM
bdrewery added a subscriber: bdrewery.

Nice work

libexec/pkg-serve/pkg-serve.c
175–176

Resources get cleaned up on successful exit but not on setup errors.

This revision is now accepted and ready to land.Tue, Mar 17, 3:38 PM
libexec/pkg-serve/pkg-serve.c
133

is this actually necessary if it's running under Capsicum? it could flag on some legitimate files, depending on what people are using it for.

167

this will write too much data if the file grows in size while writing. probably it needs to track total size and indicate some sort of protocol error if the file is larger than expected.

libexec/Makefile
17

imo, this is preferable:

SUBDIR.${MK_PKGSERVE}+= pkgserve

this is the syntax we've been using for man, confs, etc., and it's much easier to read.

i wonder: why is this in base, when pkg repository can only be built when pkg(8) is installed?