Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 71455 Build 68338: arc lint + arc unit
Event Timeline
| libexec/pkg-serve/pkg-serve.8 | ||
|---|---|---|
| 2 | s/6/2026/ | |
Comment Actions
Nice work
| libexec/pkg-serve/pkg-serve.c | ||
|---|---|---|
| 175–176 | Resources get cleaned up on successful exit but not on setup errors. | |
| libexec/pkg-serve/pkg-serve.c | ||
|---|---|---|
| 133 | is this actually necessary if it's running under Capsicum? it could flag on some legitimate files, depending on what people are using it for. | |
| 167 | this will write too much data if the file grows in size while writing. probably it needs to track total size and indicate some sort of protocol error if the file is larger than expected. | |
| libexec/Makefile | ||
|---|---|---|
| 17 | imo, this is preferable: SUBDIR.${MK_PKGSERVE}+= pkgservethis is the syntax we've been using for man, confs, etc., and it's much easier to read. | |
Comment Actions
i wonder: why is this in base, when pkg repository can only be built when pkg(8) is installed?