- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Tue, Apr 16
In D44811#1021514, @glebius wrote:IMHO, such trivial changes do not require posting a review.
Mon, Apr 15
Fri, Apr 12
In D44529#1020279, @jhb wrote:Looking at all those, I think we probably don't need a separate SI_SUB_DEVCTL_NOTIFY (though I wonder why that isn't SI_ORDER_FIRST), but I do think a separate SI_SUB_GEOM for GEOM classes to use (and the fdt_slicer thing) would be sensible. It could be defined as 0x3400000 and would untangle a bit of this more cleanly I think.
In D44620#1020403, @jhb wrote:LGTM. If the file was using normal style it wouldn't need the indentation fixup (which will add a lot of noise). I would maybe suggest instead to fix the indentation to not be unusual in lieu of the one char fixup.
Wed, Apr 10
Tue, Apr 9
Do you want me to just switch things to use __unused instead of the macros to conditionally add it?
Fri, Apr 5
In D44623#1017858, @kib wrote:In D44623#1017833, @markj wrote:In D44623#1017481, @kib wrote:I have some bad feeling about all that <feature>_unused macros. Would it better to change it to unconditionally apply unused globall?
I guess __unused has no effect if the compiler can observe that the annotated variable is in fact used? Maybe it would trigger warnings?
I don't really like all the __unused aliases either, but I also don't want to just use __unused everywhere, it would be confusing.
gcc manual describes the attribute((unused)) as possible unused, with the only mentioned consequence of gcc not issuing warning if really unused.
In D44632#1017491, @glebius wrote:I was about to ask "where is #ifdef TCP_HHOOKS?" But then I realized that socket_hhh isn't hidden under any ifdef.
Unrelated to this review, but may I ask if it is possible to hide socket_hhh and other stuff that came in 4ec7371233268 under TCP_HHOOKS? Or maybe SOCKET_HHOOKS, if these two are used as two independent features.
Thu, Apr 4
Wed, Apr 3
Update summary
In D10469#794487, @emaste wrote:There seems to be no change here or in https://github.com/trixirt/libc11ext in the last five years. @trix_juniper.net are you still planning to pursue this?
Made changes according to review comments.
Also fixed an issue when compiling gve_adminq.c due to the addition of
prototypes that use "bool", but the .c file was not including sys/types.h
Mon, Apr 1
Updated based on review comments
Thu, Mar 28
Updated based on review comments
In D44535#1015791, @andrew wrote:Is there a reason to not have cpu_reset_hook = psci_reset by default so we can remove the NULL check?
Wed, Mar 27
Fixed typo in comment.
Thu, Mar 21
Mar 1 2024
Feb 15 2024
Dec 30 2023
Dec 1 2023
Nov 30 2023
Changed iiccopyinmsgs32 to iic_copyinmsgs32, per suggested comments
Addressed comments from jhb
Nov 29 2023
Nov 20 2023
Nov 15 2023
Nov 3 2023
Looks good, verified with the board where we had seen the issue.