Add newlog.sh and setops.sh to share/mk
ClosedPublic
Actions

Authored by sjg on Jan 31 2025, 12:15 AM.

Details

Reviewers

imp
stevek
emaste
jrtc27

Commits

rGe9c2838d93ca: Add newlog.sh and setops.sh to share/mk

Summary

jobs.mk makes use of newlog.sh if found.

Set NEWLOG_SH in local.sys.env.mk to save jobs.mk searching for it.

PR: 284390

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sjg created this revision.Jan 31 2025, 12:15 AM

Herald added a subscriber: bdrewery. · View Herald TranscriptJan 31 2025, 12:15 AM

sjg requested review of this revision.Jan 31 2025, 12:15 AM

Harbormaster completed remote builds in B62167: Diff 150229.Jan 31 2025, 12:15 AM

Note, an alternative arrangement would be for local.sys.env.mk to set NEWLOG_SH= ${SRCTOP}/contrib/bmake/mk/newlog.sh and have share/mk/Makefile install the two scripts from contrib too - as is done with posix.mk

In D48737#1112404, @sjg wrote:

Note, an alternative arrangement would be for local.sys.env.mk to set NEWLOG_SH= ${SRCTOP}/contrib/bmake/mk/newlog.sh and have share/mk/Makefile install the two scripts from contrib too - as is done with posix.mk

I think that would probably be better.

Use newlog.sh out of contrib/bmake/mk

Harbormaster completed remote builds in B62348: Diff 150810.Feb 10 2025, 10:34 PM

Ensure scripts are installed executable

Harbormaster completed remote builds in B62349: Diff 150811.Feb 10 2025, 10:42 PM

stevek accepted this revision.Feb 11 2025, 4:20 PM

This revision is now accepted and ready to land.Feb 11 2025, 4:20 PM

Closed by commit rGe9c2838d93ca: Add newlog.sh and setops.sh to share/mk (authored by sjg). · Explain WhyFeb 11 2025, 5:46 PM

This revision was automatically updated to reflect the committed changes.

sjg added a commit: rGe9c2838d93ca: Add newlog.sh and setops.sh to share/mk.