Page MenuHomeFreeBSD
Differential D44811

iflib: Correct indentation according to style(9)
ClosedPublic
Actions

Authored by stevek on Apr 16 2024, 6:40 PM.
Tags
None
Referenced Files
F131964099: D44811.id137118.diff
Sun, Oct 12, 1:33 PM
F131953703: D44811.diff
Sun, Oct 12, 11:37 AM
Unknown Object (File)
Sun, Oct 12, 6:50 AM
Unknown Object (File)
Fri, Oct 10, 6:49 AM
Unknown Object (File)
Mon, Sep 22, 1:02 PM
Unknown Object (File)
Fri, Sep 19, 2:43 AM
Unknown Object (File)
Sep 12 2025, 10:30 PM
Unknown Object (File)
Sep 11 2025, 10:17 AM
View All 73 Files
Subscribers
ae
glebius
melifaro

Details

Reviewers
jhb
gallatin
erj
imp
shurd
glebius
Group Reviewers
iflib
Commits
rG2f3af838e6fc: iflib: Correct indentation according to style(9)
rGd381220e4ee1: iflib: Correct indentation according to style(9)
rGe4a0c92e7aea: iflib: Correct indentation according to style(9)
Summary

The indentation style for the SYSCTL_* macros used was not matching KNF.

Reported by: jhb

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

stevek created this revision.Apr 16 2024, 6:40 PM
Herald added a reviewer: iflib. · View Herald TranscriptApr 16 2024, 6:40 PM
Herald added subscribers: glebius, melifaro, ae. · View Herald Transcript
Harbormaster completed remote builds in B57128: Diff 137118.Apr 16 2024, 6:40 PM
stevek requested review of this revision.Apr 16 2024, 6:40 PM
glebius accepted this revision.Apr 16 2024, 6:44 PM

IMHO, such trivial changes do not require posting a review.

stevek added a comment.Apr 16 2024, 8:17 PM
In D44811#1021514, @glebius wrote:

IMHO, such trivial changes do not require posting a review.

It was just a follow-up to D44620

I'm fine with just going ahead with committing it, I wanted to put it up to close the loop, so to speak.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 16 2024, 8:38 PM
Closed by commit rGe4a0c92e7aea: iflib: Correct indentation according to style(9) (authored by stevek). · Explain Why
This revision was automatically updated to reflect the committed changes.
stevek added a commit: rGe4a0c92e7aea: iflib: Correct indentation according to style(9).
erj added a commit: rGd381220e4ee1: iflib: Correct indentation according to style(9).Jul 31 2024, 4:39 AM
zlei added a commit: rG2f3af838e6fc: iflib: Correct indentation according to style(9).Sep 26 2024, 5:20 AM

Revision Contents
Changeset List

PathSize
sys/
net/
277 lines

Diff 137174

View Options

sys/net/iflib.c

Loading...