Page MenuHomeFreeBSD
Differential D37688

kern/intr: remove support for passing trap frame as argument
Needs ReviewPublic
Actions

Authored by ehem_freebsd_m5p.com on Dec 13 2022, 9:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 22, 6:44 PM
Unknown Object (File)
Mon, Mar 20, 6:38 AM
Unknown Object (File)
Mon, Mar 6, 3:41 AM
Unknown Object (File)
Fri, Mar 3, 10:17 AM
Unknown Object (File)
Feb 8 2023, 12:41 AM
Unknown Object (File)
Jan 8 2023, 3:08 PM
Unknown Object (File)
Jan 5 2023, 11:27 AM
Unknown Object (File)
Dec 18 2022, 7:39 AM
Subscribers
imp
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

While otherwise a handy potential approach, getting the trap frame via
the argument isn't documented and isn't supposed to be used. With all
uses removed, now remove support to end the mixed calling conventions.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 48704
Build 45590: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Dec 13 2022, 9:45 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 13 2022, 9:45 PM
ehem_freebsd_m5p.com requested review of this revision.Dec 13 2022, 9:45 PM
Harbormaster completed remote builds in B48704: Diff 114111.Dec 13 2022, 9:45 PM
ehem_freebsd_m5p.com added a parent revision: D30006: xen/intr: adjust xen_intr_handle_upcall() to match interrupt filter.Dec 13 2022, 9:48 PM
ehem_freebsd_m5p.com added a comment.Dec 13 2022, 10:00 PM

Presently there are 4 uses of the NULL => trap_frame functionality. xenpci_intr_filter() in sys/dev/xen/xenpci/xenpci.c, which gets removed by D30006. xen_ipi_bitmap_handler() and xen_ipi_swi_handler() in sys/x86/xen/xen_apic.c. Lastly pmu_intr() in sys/arm/arm/pmu.c.

As long as no one tries to add new uses, this seems to have potential for 14.0.

Revision Contents
Changeset List

PathSize
sys/
kern/
15 lines

Diff 114111

View Options

sys/kern/kern_intr.c

Loading...